public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] i915/gem_eio: Break early for small rings
@ 2019-07-29 12:27 Chris Wilson
  2019-07-29 14:27 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
  2019-08-06 21:38 ` [Intel-gfx] [igt-dev] [PATCH i-g-t] " Matthew Auld
  0 siblings, 2 replies; 3+ messages in thread
From: Chris Wilson @ 2019-07-29 12:27 UTC (permalink / raw)
  To: intel-gfx; +Cc: igt-dev

If the shared legacy ringbuffer is too small to fit 64 new contexts, it
will hang and report -EIO before we are expecting it. Accommodate this
eio as it part of the ABI we are testing.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/i915/gem_eio.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/tests/i915/gem_eio.c b/tests/i915/gem_eio.c
index 4d7362d8f..dcbcefa97 100644
--- a/tests/i915/gem_eio.c
+++ b/tests/i915/gem_eio.c
@@ -559,6 +559,7 @@ static void test_inflight_contexts(int fd, unsigned int wait)
 		const uint32_t bbe = MI_BATCH_BUFFER_END;
 		struct drm_i915_gem_exec_object2 obj[2];
 		struct drm_i915_gem_execbuffer2 execbuf;
+		unsigned int count;
 		igt_spin_t *hang;
 		uint32_t ctx[64];
 		int fence[64];
@@ -587,16 +588,19 @@ static void test_inflight_contexts(int fd, unsigned int wait)
 		execbuf.buffer_count = 2;
 		execbuf.flags = engine | I915_EXEC_FENCE_OUT;
 
+		count = 0;
 		for (unsigned int n = 0; n < ARRAY_SIZE(fence); n++) {
 			execbuf.rsvd1 = ctx[n];
-			gem_execbuf_wr(fd, &execbuf);
+			if (__gem_execbuf_wr(fd, &execbuf))
+				break; /* small shared ring */
 			fence[n] = execbuf.rsvd2 >> 32;
 			igt_assert(fence[n] != -1);
+			count++;
 		}
 
 		check_wait(fd, obj[1].handle, wait, NULL);
 
-		for (unsigned int n = 0; n < ARRAY_SIZE(fence); n++) {
+		for (unsigned int n = 0; n < count; n++) {
 			igt_assert_eq(sync_fence_status(fence[n]), -EIO);
 			close(fence[n]);
 		}
-- 
2.22.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [igt-dev] ✗ Fi.CI.BAT: failure for i915/gem_eio: Break early for small rings
  2019-07-29 12:27 [igt-dev] [PATCH i-g-t] i915/gem_eio: Break early for small rings Chris Wilson
@ 2019-07-29 14:27 ` Patchwork
  2019-08-06 21:38 ` [Intel-gfx] [igt-dev] [PATCH i-g-t] " Matthew Auld
  1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2019-07-29 14:27 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev

== Series Details ==

Series: i915/gem_eio: Break early for small rings
URL   : https://patchwork.freedesktop.org/series/64381/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_6573 -> IGTPW_3302
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_3302 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_3302, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/64381/revisions/1/mbox/

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_3302:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_module_load@reload:
    - fi-hsw-4770r:       [PASS][1] -> [DMESG-WARN][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6573/fi-hsw-4770r/igt@i915_module_load@reload.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3302/fi-hsw-4770r/igt@i915_module_load@reload.html
    - fi-hsw-4770:        [PASS][3] -> [DMESG-WARN][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6573/fi-hsw-4770/igt@i915_module_load@reload.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3302/fi-hsw-4770/igt@i915_module_load@reload.html

  * igt@i915_selftest@live_contexts:
    - fi-byt-n2820:       NOTRUN -> [DMESG-WARN][5]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3302/fi-byt-n2820/igt@i915_selftest@live_contexts.html

  * igt@i915_selftest@live_hugepages:
    - fi-byt-j1900:       NOTRUN -> [DMESG-WARN][6]
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3302/fi-byt-j1900/igt@i915_selftest@live_hugepages.html

  * igt@i915_selftest@live_vma:
    - fi-ivb-3770:        NOTRUN -> [DMESG-WARN][7]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3302/fi-ivb-3770/igt@i915_selftest@live_vma.html

  
#### Warnings ####

  * igt@runner@aborted:
    - fi-hsw-4770r:       [FAIL][8] ([fdo#107732]) -> [FAIL][9]
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6573/fi-hsw-4770r/igt@runner@aborted.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3302/fi-hsw-4770r/igt@runner@aborted.html
    - fi-byt-n2820:       [FAIL][10] ([fdo#110326 ]) -> [FAIL][11]
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6573/fi-byt-n2820/igt@runner@aborted.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3302/fi-byt-n2820/igt@runner@aborted.html

  
Known issues
------------

  Here are the changes found in IGTPW_3302 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@kms_chamelium@common-hpd-after-suspend:
    - fi-kbl-7567u:       [PASS][12] -> [WARN][13] ([fdo#109380])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6573/fi-kbl-7567u/igt@kms_chamelium@common-hpd-after-suspend.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3302/fi-kbl-7567u/igt@kms_chamelium@common-hpd-after-suspend.html

  * igt@kms_pipe_crc_basic@read-crc-pipe-c:
    - fi-kbl-7567u:       [PASS][14] -> [SKIP][15] ([fdo#109271]) +23 similar issues
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6573/fi-kbl-7567u/igt@kms_pipe_crc_basic@read-crc-pipe-c.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3302/fi-kbl-7567u/igt@kms_pipe_crc_basic@read-crc-pipe-c.html

  * igt@prime_vgem@basic-fence-flip:
    - fi-kbl-7500u:       [PASS][16] -> [SKIP][17] ([fdo#109271]) +23 similar issues
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6573/fi-kbl-7500u/igt@prime_vgem@basic-fence-flip.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3302/fi-kbl-7500u/igt@prime_vgem@basic-fence-flip.html

  
#### Possible fixes ####

  * igt@i915_module_load@reload-no-display:
    - fi-byt-j1900:       [DMESG-WARN][18] -> [PASS][19]
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6573/fi-byt-j1900/igt@i915_module_load@reload-no-display.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3302/fi-byt-j1900/igt@i915_module_load@reload-no-display.html
    - fi-ivb-3770:        [DMESG-WARN][20] -> [PASS][21]
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6573/fi-ivb-3770/igt@i915_module_load@reload-no-display.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3302/fi-ivb-3770/igt@i915_module_load@reload-no-display.html

  * igt@i915_selftest@live_execlists:
    - fi-skl-gvtdvm:      [DMESG-FAIL][22] ([fdo#111108]) -> [PASS][23]
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6573/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3302/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html

  * igt@i915_selftest@live_hugepages:
    - fi-byt-n2820:       [DMESG-WARN][24] -> [PASS][25]
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6573/fi-byt-n2820/igt@i915_selftest@live_hugepages.html
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3302/fi-byt-n2820/igt@i915_selftest@live_hugepages.html

  * igt@kms_busy@basic-flip-a:
    - fi-kbl-7567u:       [SKIP][26] ([fdo#109271] / [fdo#109278]) -> [PASS][27] +2 similar issues
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6573/fi-kbl-7567u/igt@kms_busy@basic-flip-a.html
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3302/fi-kbl-7567u/igt@kms_busy@basic-flip-a.html

  * igt@kms_busy@basic-flip-c:
    - fi-kbl-7500u:       [SKIP][28] ([fdo#109271] / [fdo#109278]) -> [PASS][29] +2 similar issues
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6573/fi-kbl-7500u/igt@kms_busy@basic-flip-c.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3302/fi-kbl-7500u/igt@kms_busy@basic-flip-c.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-icl-u2:          [FAIL][30] ([fdo#103167]) -> [PASS][31]
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6573/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3302/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html

  
#### Warnings ####

  * igt@runner@aborted:
    - fi-byt-j1900:       [FAIL][32] -> [FAIL][33] ([fdo#110326 ])
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6573/fi-byt-j1900/igt@runner@aborted.html
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3302/fi-byt-j1900/igt@runner@aborted.html

  
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#107732]: https://bugs.freedesktop.org/show_bug.cgi?id=107732
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109380]: https://bugs.freedesktop.org/show_bug.cgi?id=109380
  [fdo#110326 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110326 
  [fdo#111108]: https://bugs.freedesktop.org/show_bug.cgi?id=111108


Participating hosts (52 -> 44)
------------------------------

  Missing    (8): fi-kbl-soraka fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-icl-u3 fi-icl-y fi-icl-dsi fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5114 -> IGTPW_3302

  CI-20190529: 20190529
  CI_DRM_6573: 69756063f5af4bf16b5af96e929860163a2d340d @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3302: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3302/
  IGT_5114: 54450721c3b323d01e0c6e5d5e883b7499c8022c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3302/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/gem_eio: Break early for small rings
  2019-07-29 12:27 [igt-dev] [PATCH i-g-t] i915/gem_eio: Break early for small rings Chris Wilson
  2019-07-29 14:27 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
@ 2019-08-06 21:38 ` Matthew Auld
  1 sibling, 0 replies; 3+ messages in thread
From: Matthew Auld @ 2019-08-06 21:38 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev, Intel Graphics Development

On Mon, 29 Jul 2019 at 13:27, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> If the shared legacy ringbuffer is too small to fit 64 new contexts, it
> will hang and report -EIO before we are expecting it. Accommodate this
> eio as it part of the ABI we are testing.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-08-06 21:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-29 12:27 [igt-dev] [PATCH i-g-t] i915/gem_eio: Break early for small rings Chris Wilson
2019-07-29 14:27 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2019-08-06 21:38 ` [Intel-gfx] [igt-dev] [PATCH i-g-t] " Matthew Auld

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox