public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Petri Latvala <petri.latvala@intel.com>
To: "José Roberto de Souza" <jose.souza@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] README: Add missing dependencies
Date: Tue, 30 Jul 2019 14:15:41 +0300	[thread overview]
Message-ID: <20190730111541.GD3698@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20190729222606.8690-1-jose.souza@intel.com>

On Mon, Jul 29, 2019 at 03:26:06PM -0700, José Roberto de Souza wrote:
> Doing a fresh Ubuntu 18.10 install this dependencies were also
> needed to build IGT.
> 
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
>  README.md | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/README.md b/README.md
> index 865ed6e0..e9798419 100644
> --- a/README.md
> +++ b/README.md
> @@ -139,13 +139,16 @@ Requirements
>  This is a non-exhaustive list of package dependencies required for building
>  the default configuration (package names may vary):
>  
> +	bison	

You have extra whitespace at the end of this line.


With that fixed,
Reviewed-by: Petri Latvala <petri.latvala@intel.com>

I wonder if it's soon time to remove the list of packages and
emphasise the reference to dockerfiles...
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2019-07-30 11:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-29 22:26 [igt-dev] [PATCH i-g-t] README: Add missing dependencies José Roberto de Souza
2019-07-29 23:18 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-07-30  7:35 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-07-30 11:15 ` Petri Latvala [this message]
2019-07-30 18:00   ` [igt-dev] [PATCH i-g-t] " Souza, Jose
2019-07-31  7:01     ` Ser, Simon
2019-07-31 10:40       ` Petri Latvala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190730111541.GD3698@platvala-desk.ger.corp.intel.com \
    --to=petri.latvala@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jose.souza@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox