Re: [igt-dev] [PATCH i-g-t] README: Add missing dependencies

["Souza, Jose" <jose.souza@intel.com>]

On Tue, 2019-07-30 at 14:15 +0300, Petri Latvala wrote:
> On Mon, Jul 29, 2019 at 03:26:06PM -0700, José Roberto de Souza
> wrote:
> > Doing a fresh Ubuntu 18.10 install this dependencies were also
> > needed to build IGT.
> > 
> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > ---
> >  README.md | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/README.md b/README.md
> > index 865ed6e0..e9798419 100644
> > --- a/README.md
> > +++ b/README.md
> > @@ -139,13 +139,16 @@ Requirements
> >  This is a non-exhaustive list of package dependencies required for
> > building
> >  the default configuration (package names may vary):
> >  
> > +	bison	
> 
> You have extra whitespace at the end of this line.

Thanks for spotting this.

> 
> 
> With that fixed,
> Reviewed-by: Petri Latvala <petri.latvala@intel.com>

Thanks, fixed and pushed.

> 
> I wonder if it's soon time to remove the list of packages and
> emphasise the reference to dockerfiles...


Well I don't plan to run IGT inside of docker my one cent vote is to
keep it.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev