public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests: Remove calls to igt_pipe_crc_drain()
@ 2019-07-25  7:43 Swati Sharma
  2019-07-25  8:08 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Swati Sharma @ 2019-07-25  7:43 UTC (permalink / raw)
  To: igt-dev

Calls to igt_pipe_crc_drain + get_single are already replaced with
igt_pipe_crc_get_current() in patch
https://patchwork.freedesktop.org/patch/240651/?series=47129&rev=1
so removing igt_pipe_crc_drain() shouldn't matter since tests are using
igt_pipe_crc_get_current() which will drain the old junk anyway. Its
double to do drain + get_current(), so calls to drain() can be removed.

Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 tests/kms_available_modes_crc.c | 3 ---
 tests/kms_cursor_edge_walk.c    | 2 --
 2 files changed, 5 deletions(-)

diff --git a/tests/kms_available_modes_crc.c b/tests/kms_available_modes_crc.c
index 0777276..786d50e 100644
--- a/tests/kms_available_modes_crc.c
+++ b/tests/kms_available_modes_crc.c
@@ -102,7 +102,6 @@ static void generate_comparison_crc_list(data_t *data, igt_output_t *output)
 	igt_plane_set_fb(primary, &data->primary_fb);
 	igt_display_commit2(&data->display, data->commit);
 
-	igt_pipe_crc_drain(data->pipe_crc);
 	igt_pipe_crc_get_current(data->gfx_fd, data->pipe_crc, &data->cursor_crc);
 	igt_plane_set_fb(primary, NULL);
 	igt_display_commit2(&data->display, data->commit);
@@ -114,7 +113,6 @@ static void generate_comparison_crc_list(data_t *data, igt_output_t *output)
 	igt_plane_set_fb(primary, &data->primary_fb);
 	igt_display_commit2(&data->display, data->commit);
 
-	igt_pipe_crc_drain(data->pipe_crc);
 	igt_pipe_crc_get_current(data->gfx_fd, data->pipe_crc, &data->fullscreen_crc);
 
 	igt_remove_fb(data->gfx_fd, &data->primary_fb);
@@ -313,7 +311,6 @@ test_one_mode(data_t* data, igt_output_t *output, igt_plane_t* plane,
 		igt_display_commit2(&data->display, data->commit);
 
 		igt_wait_for_vblank(data->gfx_fd, pipe);
-		igt_pipe_crc_drain(data->pipe_crc);
 		igt_pipe_crc_get_current(data->gfx_fd, data->pipe_crc, &current_crc);
 
 		if (plane->type != DRM_PLANE_TYPE_CURSOR) {
diff --git a/tests/kms_cursor_edge_walk.c b/tests/kms_cursor_edge_walk.c
index 809dca4..87d17e0 100644
--- a/tests/kms_cursor_edge_walk.c
+++ b/tests/kms_cursor_edge_walk.c
@@ -114,8 +114,6 @@ static void test_edge_pos(data_t *data, int sx, int ex, int y, bool swap_axis)
 
 	dx = (ex - sx)/XSTEP;
 
-	igt_pipe_crc_drain(data->pipe_crc);
-
 	i = 0;
 
 	for (x = sx; xdir * (x - ex) <= 0; x += dx) {
-- 
1.9.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-08-01 10:42 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-25  7:43 [igt-dev] [PATCH i-g-t] tests: Remove calls to igt_pipe_crc_drain() Swati Sharma
2019-07-25  8:08 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork
2019-07-25  8:23 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2019-07-25  9:51 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-08-01 10:42 ` [igt-dev] [PATCH i-g-t] " Ramalingam C

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox