public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH i-g-t] i915/gem_persistent_relocs: Don't call DROP_IDLE in the middle of submitting
@ 2019-08-06  8:10 Chris Wilson
  2019-08-06  8:46 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (4 more replies)
  0 siblings, 5 replies; 8+ messages in thread
From: Chris Wilson @ 2019-08-06  8:10 UTC (permalink / raw)
  To: intel-gfx; +Cc: igt-dev

To actually DROP_IDLE means that we have to wait for ongoing submission,
and any new concurrently submitted, i.e. it should only be called during
single-threaded submission to ensure the GPU is idle before the new
action.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/i915/gem_persistent_relocs.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/tests/i915/gem_persistent_relocs.c b/tests/i915/gem_persistent_relocs.c
index 452fe686e..14b86e11d 100644
--- a/tests/i915/gem_persistent_relocs.c
+++ b/tests/i915/gem_persistent_relocs.c
@@ -281,10 +281,13 @@ static void do_forked_test(int fd, unsigned flags)
 	struct igt_helper_process thrasher = {};
 
 	if (flags & (THRASH | THRASH_INACTIVE)) {
-		uint64_t val = (flags & THRASH_INACTIVE) ?
-				(DROP_RETIRE | DROP_BOUND | DROP_UNBOUND) : DROP_ALL;
-
 		igt_fork_helper(&thrasher) {
+			uint64_t val;
+
+			val = DROP_RETIRE | DROP_BOUND | DROP_UNBOUND;
+			if (!(flags & THRASH_INACTIVE))
+				val |= DROP_ACTIVE;
+
 			while (1) {
 				usleep(1000);
 				igt_drop_caches_set(fd, val);
-- 
2.23.0.rc1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2019-08-08 15:34 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-06  8:10 [Intel-gfx] [PATCH i-g-t] i915/gem_persistent_relocs: Don't call DROP_IDLE in the middle of submitting Chris Wilson
2019-08-06  8:46 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-08-06  8:49 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
2019-08-08 15:26   ` Mika Kuoppala
2019-08-08 15:34     ` Chris Wilson
2019-08-06  9:55 ` [igt-dev] ✓ Fi.CI.BAT: success for i915/gem_persistent_relocs: Don't call DROP_IDLE in the middle of submitting (rev2) Patchwork
2019-08-06 16:13 ` [igt-dev] ✗ Fi.CI.IGT: failure for i915/gem_persistent_relocs: Don't call DROP_IDLE in the middle of submitting Patchwork
2019-08-06 18:43 ` [igt-dev] ✓ Fi.CI.IGT: success for i915/gem_persistent_relocs: Don't call DROP_IDLE in the middle of submitting (rev2) Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox