From: Chris Wilson <chris@chris-wilson.co.uk>
To: igt-dev@lists.freedesktop.org
Cc: petri.latvala@intel.com
Subject: [igt-dev] [PATCH i-g-t] kms_ccs: Add the missing '\n' for igt_require_f
Date: Tue, 6 Aug 2019 22:02:27 +0100 [thread overview]
Message-ID: <20190806210227.28141-1-chris@chris-wilson.co.uk> (raw)
Currently the runner sees
Starting subtest: pipe-C-bad-aux-stride
Test requirement not met in function test_output, file ../tests/kms_ccs.c:324:
Test requirement: valid_tests > 0
CCS not supported, skippingSubtest pipe-C-bad-aux-stride: SKIP (0.330s)
and manages to explode.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/kms_ccs.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c
index 6cd30aad8..1ce66cdec 100644
--- a/tests/kms_ccs.c
+++ b/tests/kms_ccs.c
@@ -321,7 +321,7 @@ static int __test_output(data_t *data)
static void test_output(data_t *data)
{
int valid_tests = __test_output(data);
- igt_require_f(valid_tests > 0, "CCS not supported, skipping");
+ igt_require_f(valid_tests > 0, "CCS not supported, skipping\n");
}
static data_t data;
@@ -373,7 +373,8 @@ igt_main
valid_tests += __test_output(&data);
}
- igt_require_f(valid_tests > 0, "CCS not supported, skipping");
+ igt_require_f(valid_tests > 0,
+ "CCS not supported, skipping\n");
}
data.plane = NULL;
--
2.23.0.rc1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2019-08-06 21:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 21:02 Chris Wilson [this message]
2019-08-06 21:51 ` [igt-dev] ✓ Fi.CI.BAT: success for kms_ccs: Add the missing '\n' for igt_require_f Patchwork
2019-08-07 8:20 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2019-08-13 8:00 ` [igt-dev] [PATCH i-g-t] " Ser, Simon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190806210227.28141-1-chris@chris-wilson.co.uk \
--to=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox