From: "Ser, Simon" <simon.ser@intel.com>
To: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
"chris@chris-wilson.co.uk" <chris@chris-wilson.co.uk>
Cc: "Latvala, Petri" <petri.latvala@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] kms_ccs: Add the missing '\n' for igt_require_f
Date: Tue, 13 Aug 2019 08:00:51 +0000 [thread overview]
Message-ID: <ef8213d9b77d0a39e4e58856b300183c5c355675.camel@intel.com> (raw)
In-Reply-To: <20190806210227.28141-1-chris@chris-wilson.co.uk>
On Tue, 2019-08-06 at 22:02 +0100, Chris Wilson wrote:
> Currently the runner sees
>
> Starting subtest: pipe-C-bad-aux-stride
> Test requirement not met in function test_output, file
> ../tests/kms_ccs.c:324:
> Test requirement: valid_tests > 0
> CCS not supported, skippingSubtest pipe-C-bad-aux-stride: SKIP
> (0.330s)
>
> and manages to explode.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Simon Ser <simon.ser@intel.com>
> ---
> tests/kms_ccs.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c
> index 6cd30aad8..1ce66cdec 100644
> --- a/tests/kms_ccs.c
> +++ b/tests/kms_ccs.c
> @@ -321,7 +321,7 @@ static int __test_output(data_t *data)
> static void test_output(data_t *data)
> {
> int valid_tests = __test_output(data);
> - igt_require_f(valid_tests > 0, "CCS not supported, skipping");
> + igt_require_f(valid_tests > 0, "CCS not supported,
> skipping\n");
> }
>
> static data_t data;
> @@ -373,7 +373,8 @@ igt_main
> valid_tests += __test_output(&data);
> }
>
> - igt_require_f(valid_tests > 0, "CCS not
> supported, skipping");
> + igt_require_f(valid_tests > 0,
> + "CCS not supported, skipping\n");
> }
>
> data.plane = NULL;
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2019-08-13 8:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 21:02 [igt-dev] [PATCH i-g-t] kms_ccs: Add the missing '\n' for igt_require_f Chris Wilson
2019-08-06 21:51 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-08-07 8:20 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2019-08-13 8:00 ` Ser, Simon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef8213d9b77d0a39e4e58856b300183c5c355675.camel@intel.com \
--to=simon.ser@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox