public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] .gitlab-ci: List test binaries with missing top-level description correctly
@ 2019-09-04 13:39 Arkadiusz Hiler
  2019-09-04 14:21 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
  2019-09-04 17:36 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  0 siblings, 2 replies; 3+ messages in thread
From: Arkadiusz Hiler @ 2019-09-04 13:39 UTC (permalink / raw)
  To: igt-dev; +Cc: Petri Latvala

Boolean logic with string is hard.

Cc: Petri Latvala <petri.latvala@intel.com>
Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
 .gitlab-ci/list_undocumented_tests.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/.gitlab-ci/list_undocumented_tests.py b/.gitlab-ci/list_undocumented_tests.py
index ee836559..0ce3f330 100755
--- a/.gitlab-ci/list_undocumented_tests.py
+++ b/.gitlab-ci/list_undocumented_tests.py
@@ -47,12 +47,12 @@ def main():
     for test in tests:
         subtests = get_subtests(testdir, test)
 
-        if subtests and subtests[0].name:
-            # no top level description
+        if subtests and subtests[0].name is None:
+            # top level description missing, list binary
             print(test)
 
         for name, description in subtests:
-            if not name:
+            if name is None: # top level description, skipping
                 continue
 
             if "NO DOCUMENTATION!" in description:
-- 
2.21.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-09-04 17:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-04 13:39 [igt-dev] [PATCH i-g-t] .gitlab-ci: List test binaries with missing top-level description correctly Arkadiusz Hiler
2019-09-04 14:21 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-09-04 17:36 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox