* [igt-dev] [PATCH i-g-t 1/2] igt_eld: add igt_is_igt
@ 2019-09-12 10:28 Simon Ser
2019-09-12 10:28 ` [igt-dev] [PATCH i-g-t 2/2] lib/igt_alsa: check ELD comes from IGT Simon Ser
` (7 more replies)
0 siblings, 8 replies; 10+ messages in thread
From: Simon Ser @ 2019-09-12 10:28 UTC (permalink / raw)
To: igt-dev
This function parses the monitor name from an ELD blob and checks whether it
comes from an IGT EDID.
Signed-off-by: Simon Ser <simon.ser@intel.com>
---
lib/igt_eld.c | 23 +++++++++++++++++++++++
lib/igt_eld.h | 1 +
2 files changed, 24 insertions(+)
diff --git a/lib/igt_eld.c b/lib/igt_eld.c
index 16c4ac06c6f6..640496b0a160 100644
--- a/lib/igt_eld.c
+++ b/lib/igt_eld.c
@@ -262,3 +262,26 @@ bool eld_has_igt(void)
struct eld_entry eld;
return eld_get_igt(&eld);
}
+
+/** eld_is_igt: check whether the ELD blob comes from an IGT EDID */
+bool eld_is_igt(const char *eld, size_t eld_size)
+{
+ char name[17];
+ int name_size;
+
+ igt_assert_f(eld_size >= 20 && eld_size <= 256,
+ "Invalid ELD size: %zu\n", eld_size);
+
+ name_size = eld[4] & 0x1F;
+ igt_assert_f(name_size <= 16 && 20 + name_size <= eld_size,
+ "Invalid monitor name size in ELD: %d\n", name_size);
+ if (name_size == 0) {
+ igt_debug("ELD doesn't contain a monitor name\n");
+ return false;
+ }
+
+ memcpy(name, &eld[20], name_size);
+ name[name_size] = '\0';
+ igt_debug("Checking ELD with monitor name: %s\n", name);
+ return strcmp(name, "IGT") == 0;
+}
diff --git a/lib/igt_eld.h b/lib/igt_eld.h
index 7c4489f054f1..36f000abe3f9 100644
--- a/lib/igt_eld.h
+++ b/lib/igt_eld.h
@@ -51,5 +51,6 @@ struct eld_entry {
bool eld_get_igt(struct eld_entry *eld);
bool eld_has_igt(void);
+bool eld_is_igt(const char *eld, size_t eld_size);
#endif
--
2.23.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [igt-dev] [PATCH i-g-t 2/2] lib/igt_alsa: check ELD comes from IGT
2019-09-12 10:28 [igt-dev] [PATCH i-g-t 1/2] igt_eld: add igt_is_igt Simon Ser
@ 2019-09-12 10:28 ` Simon Ser
2019-09-12 10:53 ` [igt-dev] [PATCH i-g-t 1/2] igt_eld: add igt_is_igt Chris Wilson
` (6 subsequent siblings)
7 siblings, 0 replies; 10+ messages in thread
From: Simon Ser @ 2019-09-12 10:28 UTC (permalink / raw)
To: igt-dev
Prior to this commit, audio tests play sound on all HDMI/DisplayPort PCM
devices (by filtering devices with the "HDMI" prefix). This had several issues.
First, the PCM device → connector mapping via the ELD wasn't checked. Second,
it makes debugging more complicated: if ALSA doesn't detect the screen, we just
get a Chamelium failure (because it doesn't receive any audio stream). Third,
it would play sounds on real screens too (not only Chamelium) and this could
theorically damage bad hardware (though this is just speculation).
To mitigate this issue, check the monitor name of PCM devices we open and only
keep them if it's an IGT EDID (ie. connected to the Chamelium board).
Note that while this is a good improvement, it isn't a complete fix: the ELD
is only exposed by the HDA Intel driver. This means non-IGT PCM devices won't
be filtered out on non-Intel hardware. There is no driver-agnostic way to get
the screen name, I'm afraid.
Signed-off-by: Simon Ser <simon.ser@intel.com>
---
lib/igt_alsa.c | 93 +++++++++++++++++++++++++++++++++++++++++++-------
1 file changed, 81 insertions(+), 12 deletions(-)
diff --git a/lib/igt_alsa.c b/lib/igt_alsa.c
index 5b5980a94888..e1836be7cdd5 100644
--- a/lib/igt_alsa.c
+++ b/lib/igt_alsa.c
@@ -31,6 +31,7 @@
#include "igt_alsa.h"
#include "igt_aux.h"
#include "igt_core.h"
+#include "igt_eld.h"
#define HANDLES_MAX 8
@@ -105,6 +106,68 @@ struct alsa *alsa_init(void)
return alsa;
}
+static bool alsa_dev_has_igt_eld(snd_ctl_t *ctl, int dev)
+{
+ snd_hctl_t *handle;
+ snd_hctl_elem_t *elem;
+ snd_ctl_elem_info_t *info;
+ snd_ctl_elem_value_t *value;
+ const char *name;
+ snd_ctl_elem_type_t type;
+ unsigned int count;
+ const char *eld;
+ bool is_igt, eld_found;
+
+ igt_assert(snd_hctl_open_ctl(&handle, ctl) == 0);
+ igt_assert(snd_hctl_load(handle) == 0);
+ igt_assert(snd_ctl_elem_info_malloc(&info) == 0);
+ igt_assert(snd_ctl_elem_value_malloc(&value) == 0);
+
+ is_igt = eld_found = false;
+ for (elem = snd_hctl_first_elem(handle); elem;
+ elem = snd_hctl_elem_next(elem)) {
+ igt_assert(snd_hctl_elem_info(elem, info) == 0);
+ name = snd_ctl_elem_info_get_name(info);
+ type = snd_ctl_elem_info_get_type(info);
+ count = snd_ctl_elem_info_get_count(info);
+
+ if (strcmp(name, "ELD") != 0)
+ continue;
+ igt_assert(type == SND_CTL_ELEM_TYPE_BYTES);
+ if (snd_ctl_elem_info_get_device(info) != dev)
+ continue;
+
+ eld_found = true;
+
+ igt_assert(snd_hctl_elem_read(elem, value) == 0);
+ if (count == 0) {
+ igt_debug("ELD found for device %s,%d, but it's empty "
+ "(the screen is probably disconnected)\n",
+ snd_hctl_name(handle), dev);
+ break;
+ }
+
+ igt_debug("ELD found for device %s,%d\n",
+ snd_hctl_name(handle), dev);
+ eld = snd_ctl_elem_value_get_bytes(value);
+ is_igt = eld_is_igt(eld, count);
+ break;
+ }
+
+ if (!eld_found) {
+ /* ELDs are probably not supported */
+ igt_debug("ELD not found for device %s,%d, skipping ELD check\n",
+ snd_hctl_name(handle), dev);
+ is_igt = true;
+ }
+
+ snd_ctl_elem_info_free(info);
+ snd_ctl_elem_value_free(value);
+ snd_hctl_free(handle);
+
+ return is_igt;
+}
+
static char *alsa_resolve_indentifier(const char *device_name, int skip)
{
snd_ctl_card_info_t *card_info;
@@ -148,7 +211,6 @@ static char *alsa_resolve_indentifier(const char *device_name, int skip)
}
dev = -1;
-
do {
ret = snd_ctl_pcm_next_device(handle, &dev);
if (ret < 0 || dev < 0)
@@ -167,21 +229,28 @@ static char *alsa_resolve_indentifier(const char *device_name, int skip)
ret = strncmp(device_name, pcm_name,
strlen(device_name));
+ if (ret != 0)
+ continue;
- if (ret == 0) {
- if (skip > 0) {
- skip--;
- continue;
- }
+ if (!alsa_dev_has_igt_eld(handle, dev)) {
+ igt_debug("Device hw:%d,%d matches the name "
+ "but doesn't have an IGT ELD\n",
+ card, dev);
+ continue;
+ }
- igt_debug("Matched device \"%s\"\n", pcm_name);
+ if (skip > 0) {
+ skip--;
+ continue;
+ }
- snprintf(name, sizeof(name), "hw:%d,%d", card,
- dev);
+ igt_debug("Matched device \"%s\" (hw:%d,%d)\n",
+ pcm_name, card, dev);
- identifier = strdup(name);
- goto resolved;
- }
+ snprintf(name, sizeof(name), "hw:%d,%d", card,
+ dev);
+ identifier = strdup(name);
+ goto resolved;
} while (dev >= 0);
snd_ctl_close(handle);
--
2.23.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/2] igt_eld: add igt_is_igt
2019-09-12 10:28 [igt-dev] [PATCH i-g-t 1/2] igt_eld: add igt_is_igt Simon Ser
2019-09-12 10:28 ` [igt-dev] [PATCH i-g-t 2/2] lib/igt_alsa: check ELD comes from IGT Simon Ser
@ 2019-09-12 10:53 ` Chris Wilson
2019-09-12 11:41 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] " Patchwork
` (5 subsequent siblings)
7 siblings, 0 replies; 10+ messages in thread
From: Chris Wilson @ 2019-09-12 10:53 UTC (permalink / raw)
To: Simon Ser, igt-dev
igt_is_igt, or igt_is_not_igt.
Quoting Simon Ser (2019-09-12 11:28:14)
> This function parses the monitor name from an ELD blob and checks whether it
> comes from an IGT EDID.
>
> Signed-off-by: Simon Ser <simon.ser@intel.com>
> ---
> lib/igt_eld.c | 23 +++++++++++++++++++++++
> lib/igt_eld.h | 1 +
> 2 files changed, 24 insertions(+)
>
> diff --git a/lib/igt_eld.c b/lib/igt_eld.c
> index 16c4ac06c6f6..640496b0a160 100644
> --- a/lib/igt_eld.c
> +++ b/lib/igt_eld.c
> @@ -262,3 +262,26 @@ bool eld_has_igt(void)
> struct eld_entry eld;
> return eld_get_igt(&eld);
> }
> +
> +/** eld_is_igt: check whether the ELD blob comes from an IGT EDID */
> +bool eld_is_igt(const char *eld, size_t eld_size)
> +{
> + char name[17];
> + int name_size;
> +
> + igt_assert_f(eld_size >= 20 && eld_size <= 256,
> + "Invalid ELD size: %zu\n", eld_size);
> +
> + name_size = eld[4] & 0x1F;
> + igt_assert_f(name_size <= 16 && 20 + name_size <= eld_size,
> + "Invalid monitor name size in ELD: %d\n", name_size);
Not reading too much into either our name[] or from the eld blob.
name_size <= sizeof(name) - 1
to have one less floating number.
#define ELD_NAME_LOC 20 ???
> + if (name_size == 0) {
> + igt_debug("ELD doesn't contain a monitor name\n");
> + return false;
> + }
> +
> + memcpy(name, &eld[20], name_size);
> + name[name_size] = '\0';
> + igt_debug("Checking ELD with monitor name: %s\n", name);
> + return strcmp(name, "IGT") == 0;
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 10+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] igt_eld: add igt_is_igt
2019-09-12 10:28 [igt-dev] [PATCH i-g-t 1/2] igt_eld: add igt_is_igt Simon Ser
2019-09-12 10:28 ` [igt-dev] [PATCH i-g-t 2/2] lib/igt_alsa: check ELD comes from IGT Simon Ser
2019-09-12 10:53 ` [igt-dev] [PATCH i-g-t 1/2] igt_eld: add igt_is_igt Chris Wilson
@ 2019-09-12 11:41 ` Patchwork
2019-09-12 15:01 ` [igt-dev] [PATCH i-g-t 1/2] " Andi Shyti
` (4 subsequent siblings)
7 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-09-12 11:41 UTC (permalink / raw)
To: Ser, Simon; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/2] igt_eld: add igt_is_igt
URL : https://patchwork.freedesktop.org/series/66592/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6877 -> IGTPW_3446
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/66592/revisions/1/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_3446:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_pm_rpm@basic-pci-d3-state:
- {fi-tgl-u}: NOTRUN -> [SKIP][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3446/fi-tgl-u/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@i915_pm_rpm@basic-rte:
- {fi-tgl-u}: NOTRUN -> [FAIL][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3446/fi-tgl-u/igt@i915_pm_rpm@basic-rte.html
Known issues
------------
Here are the changes found in IGTPW_3446 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_mmap_gtt@basic-write-no-prefault:
- fi-icl-u3: [PASS][3] -> [DMESG-WARN][4] ([fdo#107724]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6877/fi-icl-u3/igt@gem_mmap_gtt@basic-write-no-prefault.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3446/fi-icl-u3/igt@gem_mmap_gtt@basic-write-no-prefault.html
#### Possible fixes ####
* igt@i915_module_load@reload:
- fi-blb-e6850: [INCOMPLETE][5] ([fdo#107718]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6877/fi-blb-e6850/igt@i915_module_load@reload.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3446/fi-blb-e6850/igt@i915_module_load@reload.html
* igt@i915_module_load@reload-with-fault-injection:
- {fi-icl-u4}: [DMESG-WARN][7] ([fdo#106107] / [fdo#106350]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6877/fi-icl-u4/igt@i915_module_load@reload-with-fault-injection.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3446/fi-icl-u4/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_selftest@live_execlists:
- {fi-kbl-soraka}: [DMESG-FAIL][9] ([fdo#111108]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6877/fi-kbl-soraka/igt@i915_selftest@live_execlists.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3446/fi-kbl-soraka/igt@i915_selftest@live_execlists.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][11] ([fdo#111096]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6877/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3446/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@prime_busy@basic-wait-after-default:
- fi-icl-u3: [DMESG-WARN][13] ([fdo#107724]) -> [PASS][14] +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6877/fi-icl-u3/igt@prime_busy@basic-wait-after-default.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3446/fi-icl-u3/igt@prime_busy@basic-wait-after-default.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
[fdo#106350]: https://bugs.freedesktop.org/show_bug.cgi?id=106350
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#111108]: https://bugs.freedesktop.org/show_bug.cgi?id=111108
Participating hosts (53 -> 48)
------------------------------
Additional (2): fi-tgl-u fi-tgl-u2
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5178 -> IGTPW_3446
CI-20190529: 20190529
CI_DRM_6877: 3b81bdb5c914e9bd1dc870ec0696fd6c7c867878 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3446: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3446/
IGT_5178: efb4539494d94f03374874d3b61bd04ef3802aaa @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3446/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/2] igt_eld: add igt_is_igt
2019-09-12 10:28 [igt-dev] [PATCH i-g-t 1/2] igt_eld: add igt_is_igt Simon Ser
` (2 preceding siblings ...)
2019-09-12 11:41 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] " Patchwork
@ 2019-09-12 15:01 ` Andi Shyti
2019-09-12 15:44 ` [igt-dev] [PATCH i-g-t v2] " Simon Ser
` (3 subsequent siblings)
7 siblings, 0 replies; 10+ messages in thread
From: Andi Shyti @ 2019-09-12 15:01 UTC (permalink / raw)
To: Simon Ser; +Cc: igt-dev
Hi Simon,
> +/** eld_is_igt: check whether the ELD blob comes from an IGT EDID */
> +bool eld_is_igt(const char *eld, size_t eld_size)
> +{
> + char name[17];
> + int name_size;
> +
> + igt_assert_f(eld_size >= 20 && eld_size <= 256,
> + "Invalid ELD size: %zu\n", eld_size);
> +
> + name_size = eld[4] & 0x1F;
> + igt_assert_f(name_size <= 16 && 20 + name_size <= eld_size,
> + "Invalid monitor name size in ELD: %d\n", name_size);
> + if (name_size == 0) {
> + igt_debug("ELD doesn't contain a monitor name\n");
> + return false;
> + }
> +
> + memcpy(name, &eld[20], name_size);
17/20/256/4/0x1f/16/20/20 too many constants and no comments.
Overdefining constants is not nice, but then you need to explain
them.
Andi
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 10+ messages in thread
* [igt-dev] [PATCH i-g-t v2] igt_eld: add igt_is_igt
2019-09-12 10:28 [igt-dev] [PATCH i-g-t 1/2] igt_eld: add igt_is_igt Simon Ser
` (3 preceding siblings ...)
2019-09-12 15:01 ` [igt-dev] [PATCH i-g-t 1/2] " Andi Shyti
@ 2019-09-12 15:44 ` Simon Ser
2019-09-13 11:08 ` Ser, Simon
2019-09-12 16:37 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v2] igt_eld: add igt_is_igt (rev2) Patchwork
` (2 subsequent siblings)
7 siblings, 1 reply; 10+ messages in thread
From: Simon Ser @ 2019-09-12 15:44 UTC (permalink / raw)
To: igt-dev
This function parses the monitor name from an ELD blob and checks whether it
comes from an IGT EDID.
v2: replace a bunch of random numbers with constants (Chris, Andi)
Signed-off-by: Simon Ser <simon.ser@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Andi Shyti <andi.shyti@intel.com>
---
Hrm, indeed, you're right, constants make the code much better.
lib/igt_eld.c | 29 +++++++++++++++++++++++++++++
lib/igt_eld.h | 1 +
2 files changed, 30 insertions(+)
diff --git a/lib/igt_eld.c b/lib/igt_eld.c
index 16c4ac06c6f6..d565a4c04773 100644
--- a/lib/igt_eld.c
+++ b/lib/igt_eld.c
@@ -262,3 +262,32 @@ bool eld_has_igt(void)
struct eld_entry eld;
return eld_get_igt(&eld);
}
+
+#define ELD_MAX_SIZE 256
+#define MONITOR_NAME_OFFSET 20
+#define MONITOR_NAME_MAX_SIZE 16
+
+/** eld_is_igt: check whether the ELD blob comes from an IGT EDID */
+bool eld_is_igt(const char *eld, size_t eld_size)
+{
+ char name[MONITOR_NAME_MAX_SIZE + 1];
+ int name_size;
+
+ igt_assert_f(eld_size >= MONITOR_NAME_OFFSET &&
+ eld_size <= ELD_MAX_SIZE,
+ "Invalid ELD size: %zu\n", eld_size);
+
+ name_size = eld[4] & 0x1F;
+ igt_assert_f(name_size <= MONITOR_NAME_MAX_SIZE &&
+ MONITOR_NAME_OFFSET + name_size <= eld_size,
+ "Invalid monitor name size in ELD: %d\n", name_size);
+ if (name_size == 0) {
+ igt_debug("ELD doesn't contain a monitor name\n");
+ return false;
+ }
+
+ memcpy(name, &eld[MONITOR_NAME_OFFSET], name_size);
+ name[name_size] = '\0';
+ igt_debug("Checking ELD with monitor name: %s\n", name);
+ return strcmp(name, "IGT") == 0;
+}
diff --git a/lib/igt_eld.h b/lib/igt_eld.h
index 7c4489f054f1..36f000abe3f9 100644
--- a/lib/igt_eld.h
+++ b/lib/igt_eld.h
@@ -51,5 +51,6 @@ struct eld_entry {
bool eld_get_igt(struct eld_entry *eld);
bool eld_has_igt(void);
+bool eld_is_igt(const char *eld, size_t eld_size);
#endif
--
2.23.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v2] igt_eld: add igt_is_igt (rev2)
2019-09-12 10:28 [igt-dev] [PATCH i-g-t 1/2] igt_eld: add igt_is_igt Simon Ser
` (4 preceding siblings ...)
2019-09-12 15:44 ` [igt-dev] [PATCH i-g-t v2] " Simon Ser
@ 2019-09-12 16:37 ` Patchwork
2019-09-12 20:11 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/2] igt_eld: add igt_is_igt Patchwork
2019-09-13 5:39 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,v2] igt_eld: add igt_is_igt (rev2) Patchwork
7 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-09-12 16:37 UTC (permalink / raw)
To: Simon Ser; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,v2] igt_eld: add igt_is_igt (rev2)
URL : https://patchwork.freedesktop.org/series/66592/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6882 -> IGTPW_3449
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/66592/revisions/2/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_3449:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_pm_rpm@basic-pci-d3-state:
- {fi-tgl-u}: NOTRUN -> [SKIP][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3449/fi-tgl-u/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@i915_pm_rpm@basic-rte:
- {fi-tgl-u}: NOTRUN -> [FAIL][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3449/fi-tgl-u/igt@i915_pm_rpm@basic-rte.html
Known issues
------------
Here are the changes found in IGTPW_3449 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_close_race@basic-process:
- fi-icl-u3: [PASS][3] -> [DMESG-WARN][4] ([fdo#107724]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6882/fi-icl-u3/igt@gem_close_race@basic-process.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3449/fi-icl-u3/igt@gem_close_race@basic-process.html
* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: [PASS][5] -> [INCOMPLETE][6] ([fdo#107718])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6882/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3449/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-icl-u2: [PASS][7] -> [FAIL][8] ([fdo#109483])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6882/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3449/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u3: [PASS][9] -> [FAIL][10] ([fdo#103167])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6882/fi-icl-u3/igt@kms_frontbuffer_tracking@basic.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3449/fi-icl-u3/igt@kms_frontbuffer_tracking@basic.html
#### Possible fixes ####
* igt@gem_sync@basic-store-each:
- {fi-tgl-u}: [INCOMPLETE][11] ([fdo#111647]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6882/fi-tgl-u/igt@gem_sync@basic-store-each.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3449/fi-tgl-u/igt@gem_sync@basic-store-each.html
* igt@i915_module_load@reload-with-fault-injection:
- {fi-icl-u4}: [DMESG-WARN][13] ([fdo#106107] / [fdo#106350]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6882/fi-icl-u4/igt@i915_module_load@reload-with-fault-injection.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3449/fi-icl-u4/igt@i915_module_load@reload-with-fault-injection.html
* igt@prime_vgem@basic-fence-mmap:
- fi-icl-u3: [DMESG-WARN][15] ([fdo#107724]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6882/fi-icl-u3/igt@prime_vgem@basic-fence-mmap.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3449/fi-icl-u3/igt@prime_vgem@basic-fence-mmap.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
[fdo#106350]: https://bugs.freedesktop.org/show_bug.cgi?id=106350
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483
[fdo#111600]: https://bugs.freedesktop.org/show_bug.cgi?id=111600
[fdo#111647]: https://bugs.freedesktop.org/show_bug.cgi?id=111647
Participating hosts (55 -> 46)
------------------------------
Missing (9): fi-ilk-m540 fi-bxt-dsi fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-icl-y fi-icl-dsi fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5178 -> IGTPW_3449
CI-20190529: 20190529
CI_DRM_6882: a7f950bbf06a55e6a47934b2891ef595f97165d4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3449: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3449/
IGT_5178: efb4539494d94f03374874d3b61bd04ef3802aaa @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3449/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 10+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/2] igt_eld: add igt_is_igt
2019-09-12 10:28 [igt-dev] [PATCH i-g-t 1/2] igt_eld: add igt_is_igt Simon Ser
` (5 preceding siblings ...)
2019-09-12 16:37 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v2] igt_eld: add igt_is_igt (rev2) Patchwork
@ 2019-09-12 20:11 ` Patchwork
2019-09-13 5:39 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,v2] igt_eld: add igt_is_igt (rev2) Patchwork
7 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-09-12 20:11 UTC (permalink / raw)
To: Simon Ser; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/2] igt_eld: add igt_is_igt
URL : https://patchwork.freedesktop.org/series/66592/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6877_full -> IGTPW_3446_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/66592/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_3446_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#110841])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6877/shard-iclb5/igt@gem_ctx_shared@exec-single-timeline-bsd.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3446/shard-iclb4/igt@gem_ctx_shared@exec-single-timeline-bsd.html
* igt@gem_exec_schedule@independent-bsd1:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276]) +19 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6877/shard-iclb2/igt@gem_exec_schedule@independent-bsd1.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3446/shard-iclb6/igt@gem_exec_schedule@independent-bsd1.html
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#111325]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6877/shard-iclb3/igt@gem_exec_schedule@preempt-other-chain-bsd.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3446/shard-iclb1/igt@gem_exec_schedule@preempt-other-chain-bsd.html
* igt@i915_suspend@debugfs-reader:
- shard-apl: [PASS][7] -> [DMESG-WARN][8] ([fdo#108566]) +6 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6877/shard-apl3/igt@i915_suspend@debugfs-reader.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3446/shard-apl7/igt@i915_suspend@debugfs-reader.html
* igt@kms_flip@2x-flip-vs-expired-vblank:
- shard-glk: [PASS][9] -> [FAIL][10] ([fdo#105363])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6877/shard-glk4/igt@kms_flip@2x-flip-vs-expired-vblank.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3446/shard-glk9/igt@kms_flip@2x-flip-vs-expired-vblank.html
* igt@kms_flip@flip-vs-suspend:
- shard-snb: [PASS][11] -> [INCOMPLETE][12] ([fdo#105411])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6877/shard-snb1/igt@kms_flip@flip-vs-suspend.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3446/shard-snb1/igt@kms_flip@flip-vs-suspend.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-render:
- shard-iclb: [PASS][13] -> [FAIL][14] ([fdo#103167]) +2 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6877/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-render.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3446/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@psr-farfromfence:
- shard-iclb: [PASS][15] -> [INCOMPLETE][16] ([fdo#106978] / [fdo#107713])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6877/shard-iclb4/igt@kms_frontbuffer_tracking@psr-farfromfence.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3446/shard-iclb7/igt@kms_frontbuffer_tracking@psr-farfromfence.html
* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#109441]) +3 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6877/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3446/shard-iclb7/igt@kms_psr@psr2_cursor_plane_onoff.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][19] -> [FAIL][20] ([fdo#99912])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6877/shard-apl1/igt@kms_setmode@basic.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3446/shard-apl2/igt@kms_setmode@basic.html
- shard-kbl: [PASS][21] -> [FAIL][22] ([fdo#99912])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6877/shard-kbl7/igt@kms_setmode@basic.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3446/shard-kbl1/igt@kms_setmode@basic.html
* igt@prime_busy@hang-render:
- shard-iclb: [PASS][23] -> [INCOMPLETE][24] ([fdo#107713])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6877/shard-iclb4/igt@prime_busy@hang-render.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3446/shard-iclb1/igt@prime_busy@hang-render.html
#### Possible fixes ####
* igt@gem_ctx_switch@rcs0-queue:
- shard-iclb: [INCOMPLETE][25] ([fdo#107713]) -> [PASS][26] +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6877/shard-iclb4/igt@gem_ctx_switch@rcs0-queue.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3446/shard-iclb2/igt@gem_ctx_switch@rcs0-queue.html
* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][27] ([fdo#110854]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6877/shard-iclb6/igt@gem_exec_balancer@smoke.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3446/shard-iclb1/igt@gem_exec_balancer@smoke.html
* igt@gem_exec_schedule@preempt-other-bsd1:
- shard-iclb: [SKIP][29] ([fdo#109276]) -> [PASS][30] +17 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6877/shard-iclb8/igt@gem_exec_schedule@preempt-other-bsd1.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3446/shard-iclb2/igt@gem_exec_schedule@preempt-other-bsd1.html
* igt@gem_exec_schedule@reorder-wide-bsd:
- shard-iclb: [SKIP][31] ([fdo#111325]) -> [PASS][32] +4 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6877/shard-iclb1/igt@gem_exec_schedule@reorder-wide-bsd.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3446/shard-iclb3/igt@gem_exec_schedule@reorder-wide-bsd.html
* igt@i915_pm_rpm@modeset-stress-extra-wait:
- shard-glk: [DMESG-WARN][33] ([fdo#105763] / [fdo#106538]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6877/shard-glk8/igt@i915_pm_rpm@modeset-stress-extra-wait.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3446/shard-glk8/igt@i915_pm_rpm@modeset-stress-extra-wait.html
* igt@i915_suspend@sysfs-reader:
- shard-apl: [DMESG-WARN][35] ([fdo#108566]) -> [PASS][36] +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6877/shard-apl6/igt@i915_suspend@sysfs-reader.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3446/shard-apl3/igt@i915_suspend@sysfs-reader.html
* igt@kms_cursor_legacy@cursorb-vs-flipb-atomic-transitions:
- shard-hsw: [INCOMPLETE][37] ([fdo#103540]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6877/shard-hsw2/igt@kms_cursor_legacy@cursorb-vs-flipb-atomic-transitions.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3446/shard-hsw6/igt@kms_cursor_legacy@cursorb-vs-flipb-atomic-transitions.html
* igt@kms_frontbuffer_tracking@fbc-stridechange:
- shard-iclb: [FAIL][39] ([fdo#103167]) -> [PASS][40] +5 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6877/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-stridechange.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3446/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-stridechange.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [SKIP][41] ([fdo#109642] / [fdo#111068]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6877/shard-iclb4/igt@kms_psr2_su@frontbuffer.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3446/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [SKIP][43] ([fdo#109441]) -> [PASS][44] +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6877/shard-iclb8/igt@kms_psr@psr2_cursor_mmap_cpu.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3446/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [FAIL][45] ([fdo#111329]) -> [SKIP][46] ([fdo#109276])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6877/shard-iclb1/igt@gem_ctx_isolation@vcs1-nonpriv.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3446/shard-iclb5/igt@gem_ctx_isolation@vcs1-nonpriv.html
* igt@gem_mocs_settings@mocs-settings-bsd2:
- shard-iclb: [FAIL][47] ([fdo#111330]) -> [SKIP][48] ([fdo#109276]) +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6877/shard-iclb1/igt@gem_mocs_settings@mocs-settings-bsd2.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3446/shard-iclb7/igt@gem_mocs_settings@mocs-settings-bsd2.html
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#106538]: https://bugs.freedesktop.org/show_bug.cgi?id=106538
[fdo#106978]: https://bugs.freedesktop.org/show_bug.cgi?id=106978
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
[fdo#111329]: https://bugs.freedesktop.org/show_bug.cgi?id=111329
[fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (10 -> 6)
------------------------------
Missing (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5178 -> IGTPW_3446
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_6877: 3b81bdb5c914e9bd1dc870ec0696fd6c7c867878 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3446: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3446/
IGT_5178: efb4539494d94f03374874d3b61bd04ef3802aaa @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3446/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 10+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,v2] igt_eld: add igt_is_igt (rev2)
2019-09-12 10:28 [igt-dev] [PATCH i-g-t 1/2] igt_eld: add igt_is_igt Simon Ser
` (6 preceding siblings ...)
2019-09-12 20:11 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/2] igt_eld: add igt_is_igt Patchwork
@ 2019-09-13 5:39 ` Patchwork
7 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-09-13 5:39 UTC (permalink / raw)
To: Simon Ser; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,v2] igt_eld: add igt_is_igt (rev2)
URL : https://patchwork.freedesktop.org/series/66592/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6882_full -> IGTPW_3449_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/66592/revisions/2/mbox/
Known issues
------------
Here are the changes found in IGTPW_3449_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_schedule@preempt-other-bsd1:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#109276]) +15 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6882/shard-iclb2/igt@gem_exec_schedule@preempt-other-bsd1.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3449/shard-iclb5/igt@gem_exec_schedule@preempt-other-bsd1.html
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#111325]) +8 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6882/shard-iclb3/igt@gem_exec_schedule@preemptive-hang-bsd.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3449/shard-iclb4/igt@gem_exec_schedule@preemptive-hang-bsd.html
* igt@gem_tiled_blits@normal:
- shard-apl: [PASS][5] -> [INCOMPLETE][6] ([fdo#103927])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6882/shard-apl7/igt@gem_tiled_blits@normal.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3449/shard-apl5/igt@gem_tiled_blits@normal.html
* igt@i915_suspend@debugfs-reader:
- shard-apl: [PASS][7] -> [DMESG-WARN][8] ([fdo#108566]) +5 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6882/shard-apl7/igt@i915_suspend@debugfs-reader.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3449/shard-apl7/igt@i915_suspend@debugfs-reader.html
* igt@kms_busy@extended-modeset-hang-oldfb-render-a:
- shard-hsw: [PASS][9] -> [INCOMPLETE][10] ([fdo#103540]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6882/shard-hsw1/igt@kms_busy@extended-modeset-hang-oldfb-render-a.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3449/shard-hsw6/igt@kms_busy@extended-modeset-hang-oldfb-render-a.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
- shard-iclb: [PASS][11] -> [FAIL][12] ([fdo#103167]) +4 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6882/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3449/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt.html
* igt@kms_psr@psr2_sprite_render:
- shard-iclb: [PASS][13] -> [SKIP][14] ([fdo#109441]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6882/shard-iclb2/igt@kms_psr@psr2_sprite_render.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3449/shard-iclb4/igt@kms_psr@psr2_sprite_render.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][15] -> [FAIL][16] ([fdo#99912])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6882/shard-apl6/igt@kms_setmode@basic.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3449/shard-apl7/igt@kms_setmode@basic.html
* igt@perf_pmu@rc6:
- shard-kbl: [PASS][17] -> [SKIP][18] ([fdo#109271])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6882/shard-kbl1/igt@perf_pmu@rc6.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3449/shard-kbl1/igt@perf_pmu@rc6.html
#### Possible fixes ####
* igt@gem_exec_schedule@independent-bsd:
- shard-iclb: [SKIP][19] ([fdo#111325]) -> [PASS][20] +2 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6882/shard-iclb4/igt@gem_exec_schedule@independent-bsd.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3449/shard-iclb5/igt@gem_exec_schedule@independent-bsd.html
* igt@gem_exec_schedule@independent-bsd1:
- shard-iclb: [SKIP][21] ([fdo#109276]) -> [PASS][22] +13 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6882/shard-iclb8/igt@gem_exec_schedule@independent-bsd1.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3449/shard-iclb4/igt@gem_exec_schedule@independent-bsd1.html
* igt@i915_pm_rc6_residency@rc6-accuracy:
- shard-snb: [SKIP][23] ([fdo#109271]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6882/shard-snb7/igt@i915_pm_rc6_residency@rc6-accuracy.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3449/shard-snb6/igt@i915_pm_rc6_residency@rc6-accuracy.html
* igt@kms_frontbuffer_tracking@fbc-stridechange:
- shard-iclb: [FAIL][25] ([fdo#103167]) -> [PASS][26] +3 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6882/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-stridechange.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3449/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-stridechange.html
* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: [SKIP][27] ([fdo#109441]) -> [PASS][28] +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6882/shard-iclb4/igt@kms_psr@psr2_cursor_plane_onoff.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3449/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-apl: [DMESG-WARN][29] ([fdo#108566]) -> [PASS][30] +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6882/shard-apl8/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3449/shard-apl6/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [SKIP][31] ([fdo#109276]) -> [FAIL][32] ([fdo#111329])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6882/shard-iclb5/igt@gem_ctx_isolation@vcs1-nonpriv.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3449/shard-iclb4/igt@gem_ctx_isolation@vcs1-nonpriv.html
* igt@gem_mocs_settings@mocs-reset-bsd2:
- shard-iclb: [FAIL][33] ([fdo#111330]) -> [SKIP][34] ([fdo#109276]) +2 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6882/shard-iclb4/igt@gem_mocs_settings@mocs-reset-bsd2.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3449/shard-iclb8/igt@gem_mocs_settings@mocs-reset-bsd2.html
* igt@gem_mocs_settings@mocs-settings-bsd2:
- shard-iclb: [SKIP][35] ([fdo#109276]) -> [FAIL][36] ([fdo#111330])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6882/shard-iclb5/igt@gem_mocs_settings@mocs-settings-bsd2.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3449/shard-iclb1/igt@gem_mocs_settings@mocs-settings-bsd2.html
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
[fdo#111329]: https://bugs.freedesktop.org/show_bug.cgi?id=111329
[fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (9 -> 6)
------------------------------
Missing (3): pig-skl-6260u shard-skl pig-glk-j5005
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5178 -> IGTPW_3449
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_6882: a7f950bbf06a55e6a47934b2891ef595f97165d4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3449: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3449/
IGT_5178: efb4539494d94f03374874d3b61bd04ef3802aaa @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3449/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2] igt_eld: add igt_is_igt
2019-09-12 15:44 ` [igt-dev] [PATCH i-g-t v2] " Simon Ser
@ 2019-09-13 11:08 ` Ser, Simon
0 siblings, 0 replies; 10+ messages in thread
From: Ser, Simon @ 2019-09-13 11:08 UTC (permalink / raw)
To: igt-dev@lists.freedesktop.org
On Thu, 2019-09-12 at 18:44 +0300, Simon Ser wrote:
> This function parses the monitor name from an ELD blob and checks
> whether it
> comes from an IGT EDID.
>
> v2: replace a bunch of random numbers with constants (Chris, Andi)
And of course the commit message is still wrong…
> Signed-off-by: Simon Ser <simon.ser@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Andi Shyti <andi.shyti@intel.com>
> ---
>
> Hrm, indeed, you're right, constants make the code much better.
>
> lib/igt_eld.c | 29 +++++++++++++++++++++++++++++
> lib/igt_eld.h | 1 +
> 2 files changed, 30 insertions(+)
>
> diff --git a/lib/igt_eld.c b/lib/igt_eld.c
> index 16c4ac06c6f6..d565a4c04773 100644
> --- a/lib/igt_eld.c
> +++ b/lib/igt_eld.c
> @@ -262,3 +262,32 @@ bool eld_has_igt(void)
> struct eld_entry eld;
> return eld_get_igt(&eld);
> }
> +
> +#define ELD_MAX_SIZE 256
> +#define MONITOR_NAME_OFFSET 20
> +#define MONITOR_NAME_MAX_SIZE 16
> +
> +/** eld_is_igt: check whether the ELD blob comes from an IGT EDID */
> +bool eld_is_igt(const char *eld, size_t eld_size)
> +{
> + char name[MONITOR_NAME_MAX_SIZE + 1];
> + int name_size;
> +
> + igt_assert_f(eld_size >= MONITOR_NAME_OFFSET &&
> + eld_size <= ELD_MAX_SIZE,
> + "Invalid ELD size: %zu\n", eld_size);
> +
> + name_size = eld[4] & 0x1F;
> + igt_assert_f(name_size <= MONITOR_NAME_MAX_SIZE &&
> + MONITOR_NAME_OFFSET + name_size <= eld_size,
> + "Invalid monitor name size in ELD: %d\n",
> name_size);
> + if (name_size == 0) {
> + igt_debug("ELD doesn't contain a monitor name\n");
> + return false;
> + }
> +
> + memcpy(name, &eld[MONITOR_NAME_OFFSET], name_size);
> + name[name_size] = '\0';
> + igt_debug("Checking ELD with monitor name: %s\n", name);
> + return strcmp(name, "IGT") == 0;
> +}
> diff --git a/lib/igt_eld.h b/lib/igt_eld.h
> index 7c4489f054f1..36f000abe3f9 100644
> --- a/lib/igt_eld.h
> +++ b/lib/igt_eld.h
> @@ -51,5 +51,6 @@ struct eld_entry {
>
> bool eld_get_igt(struct eld_entry *eld);
> bool eld_has_igt(void);
> +bool eld_is_igt(const char *eld, size_t eld_size);
>
> #endif
> --
> 2.23.0
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-09-13 11:08 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-12 10:28 [igt-dev] [PATCH i-g-t 1/2] igt_eld: add igt_is_igt Simon Ser
2019-09-12 10:28 ` [igt-dev] [PATCH i-g-t 2/2] lib/igt_alsa: check ELD comes from IGT Simon Ser
2019-09-12 10:53 ` [igt-dev] [PATCH i-g-t 1/2] igt_eld: add igt_is_igt Chris Wilson
2019-09-12 11:41 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] " Patchwork
2019-09-12 15:01 ` [igt-dev] [PATCH i-g-t 1/2] " Andi Shyti
2019-09-12 15:44 ` [igt-dev] [PATCH i-g-t v2] " Simon Ser
2019-09-13 11:08 ` Ser, Simon
2019-09-12 16:37 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v2] igt_eld: add igt_is_igt (rev2) Patchwork
2019-09-12 20:11 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/2] igt_eld: add igt_is_igt Patchwork
2019-09-13 5:39 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,v2] igt_eld: add igt_is_igt (rev2) Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox