* [igt-dev] [PATCH i-g-t v3 0/2] Adding gpgpu_fill and media_fill on TGL
@ 2019-09-18 8:17 Katarzyna Dec
2019-09-18 8:17 ` [igt-dev] [PATCH i-g-t v3 1/2] lib/gpgpu_fill/tgl: Implement gpgpu_fillfunc for TGL Katarzyna Dec
` (4 more replies)
0 siblings, 5 replies; 7+ messages in thread
From: Katarzyna Dec @ 2019-09-18 8:17 UTC (permalink / raw)
To: igt-dev
iPatches add media_fill and gpgpu_fill functions on TGL.
v2: Switched to IS_GEN12 macro.
v3: Minor checkpatch changes
Katarzyna Dec (2):
lib/gpgpu_fill/tgl: Implement gpgpu_fillfunc for TGL
lib/media_fill/tgl: Implement media_fillfunc for TGL
lib/gpgpu_fill.c | 23 +++++++++++++++++
lib/gpgpu_fill.h | 7 ++++++
lib/i915/shaders/README | 2 ++
lib/i915/shaders/gpgpu/gen12_gpgpu_kernel.asm | 12 +++++++++
lib/i915/shaders/media/gen12_media_kernel.asm | 13 ++++++++++
lib/intel_batchbuffer.c | 6 ++++-
lib/media_fill.c | 25 +++++++++++++++++++
lib/media_fill.h | 7 ++++++
8 files changed, 94 insertions(+), 1 deletion(-)
create mode 100644 lib/i915/shaders/gpgpu/gen12_gpgpu_kernel.asm
create mode 100644 lib/i915/shaders/media/gen12_media_kernel.asm
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 7+ messages in thread* [igt-dev] [PATCH i-g-t v3 1/2] lib/gpgpu_fill/tgl: Implement gpgpu_fillfunc for TGL 2019-09-18 8:17 [igt-dev] [PATCH i-g-t v3 0/2] Adding gpgpu_fill and media_fill on TGL Katarzyna Dec @ 2019-09-18 8:17 ` Katarzyna Dec 2019-09-18 8:17 ` [igt-dev] [PATCH i-g-t v3 2/2] lib/media_fill/tgl: Implement media_fillfunc " Katarzyna Dec ` (3 subsequent siblings) 4 siblings, 0 replies; 7+ messages in thread From: Katarzyna Dec @ 2019-09-18 8:17 UTC (permalink / raw) To: igt-dev; +Cc: Lucas De Marchi Adding gen12_gpgpu_fillfunc to have gpgpu_fill running on TGL. Gpgpu shader was generated using IGA (Intel Graphics Assembler) based on Gen11 binary adding necessary SWSB dependencies and changes in SEND instruction. Shader source code and array containing its assembled version have same names now to avoid ambiguity. v2: Switched to using IS_GEN12 v3: Minor checkpatch change Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> Cc: Antonio Argenziano <antonio.argenziano@intel.com> Signed-off-by: Katarzyna Dec <katarzyna.dec@intel.com> Signed-off-by: Lukasz Kalamarz <lukasz.kalamarz@intel.com> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com> --- lib/gpgpu_fill.c | 23 +++++++++++++++++++ lib/gpgpu_fill.h | 7 ++++++ lib/i915/shaders/README | 2 ++ lib/i915/shaders/gpgpu/gen12_gpgpu_kernel.asm | 12 ++++++++++ lib/intel_batchbuffer.c | 2 ++ 5 files changed, 46 insertions(+) create mode 100644 lib/i915/shaders/gpgpu/gen12_gpgpu_kernel.asm diff --git a/lib/gpgpu_fill.c b/lib/gpgpu_fill.c index 003f4616..5660d4c0 100644 --- a/lib/gpgpu_fill.c +++ b/lib/gpgpu_fill.c @@ -87,6 +87,19 @@ static const uint32_t gen11_gpgpu_kernel[][4] = { { 0x07800031, 0x20000a40, 0x06000e00, 0x82000010 }, }; +static const uint32_t gen12_gpgpu_kernel[][4] = { + { 0x00020061, 0x01050000, 0x00000104, 0x00000000 }, + { 0x00000069, 0x02058220, 0x02000024, 0x00000004 }, + { 0x00000061, 0x02250220, 0x000000c4, 0x00000000 }, + { 0x00030061, 0x04050220, 0x00460005, 0x00000000 }, + { 0x00010261, 0x04050220, 0x00220205, 0x00000000 }, + { 0x00000061, 0x04454220, 0x00000000, 0x0000000f }, + { 0x00040661, 0x05050220, 0x00000104, 0x00000000 }, + { 0x00049031, 0x00000000, 0xc0000414, 0x02a00000 }, + { 0x00030061, 0x70050220, 0x00460005, 0x00000000 }, + { 0x00040131, 0x00000004, 0x7020700c, 0x10000000 }, +}; + /* * This sets up the gpgpu pipeline, * @@ -282,3 +295,13 @@ void gen11_gpgpu_fillfunc(struct intel_batchbuffer *batch, __gen9_gpgpu_fillfunc(batch, dst, x, y, width, height, color, gen11_gpgpu_kernel, sizeof(gen11_gpgpu_kernel)); } + +void gen12_gpgpu_fillfunc(struct intel_batchbuffer *batch, + const struct igt_buf *dst, + unsigned int x, unsigned int y, + unsigned int width, unsigned int height, + uint8_t color) +{ + __gen9_gpgpu_fillfunc(batch, dst, x, y, width, height, color, + gen12_gpgpu_kernel, sizeof(gen12_gpgpu_kernel)); +} diff --git a/lib/gpgpu_fill.h b/lib/gpgpu_fill.h index e405df3e..da7d646f 100644 --- a/lib/gpgpu_fill.h +++ b/lib/gpgpu_fill.h @@ -57,4 +57,11 @@ gen11_gpgpu_fillfunc(struct intel_batchbuffer *batch, unsigned int width, unsigned int height, uint8_t color); +void +gen12_gpgpu_fillfunc(struct intel_batchbuffer *batch, + const struct igt_buf *dst, + unsigned int x, unsigned int y, + unsigned int width, unsigned int height, + uint8_t color); + #endif /* GPGPU_FILL_H */ diff --git a/lib/i915/shaders/README b/lib/i915/shaders/README index 06b9883c..6f80111b 100644 --- a/lib/i915/shaders/README +++ b/lib/i915/shaders/README @@ -23,3 +23,5 @@ Commands used to generate the shader on gen8 $> m4 media_fill.gxa > media_fill.gxm $> intel-gen4asm -g 8 -o <output> media_fill.gxm +Gen11+ shader is generated using IGA (Intel Graphics Assembler). +Binary can no longer be generated using intel-gen4asm. diff --git a/lib/i915/shaders/gpgpu/gen12_gpgpu_kernel.asm b/lib/i915/shaders/gpgpu/gen12_gpgpu_kernel.asm new file mode 100644 index 00000000..ede87a05 --- /dev/null +++ b/lib/i915/shaders/gpgpu/gen12_gpgpu_kernel.asm @@ -0,0 +1,12 @@ +L0: + mov (4|M0) r1.0<1>:ub r1.0<0;1,0>:ub + shl (1|M0) r2.0<1>:ud r0.1<0;1,0>:ud 0x4:ud + mov (1|M0) r2.1<1>:ud r0.6<0;1,0>:ud + mov (8|M0) r4.0<1>:ud r0.0<8;8,1>:ud + mov (2|M0) r4.0<1>:ud r2.0<2;2,1>:ud {@2} + mov (1|M0) r4.2<1>:ud 0xF:ud + mov (16|M0) r5.0<1>:ud r1.0<0;1,0>:ud {@6} + send.dc1 (16|M0) null r4 null 0x0 0x40A8000 {@1, $0} // wr:2h+0, rd:0, Media Block Write msc:0, to #0 + mov (8|M0) r112.0<1>:ud r0.0<8;8,1>:ud + send.ts (16|M0) null r112 null 0x10000000 0x2000010 {EOT, @1} // wr:1+0, rd:0, fc: 0x10 +L160: diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c index 07de5cbb..269c8982 100644 --- a/lib/intel_batchbuffer.c +++ b/lib/intel_batchbuffer.c @@ -901,6 +901,8 @@ igt_fillfunc_t igt_get_gpgpu_fillfunc(int devid) fill = gen9_gpgpu_fillfunc; else if (IS_GEN11(devid)) fill = gen11_gpgpu_fillfunc; + else if (IS_GEN12(devid)) + fill = gen12_gpgpu_fillfunc; return fill; } -- 2.20.1 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [igt-dev] [PATCH i-g-t v3 2/2] lib/media_fill/tgl: Implement media_fillfunc for TGL 2019-09-18 8:17 [igt-dev] [PATCH i-g-t v3 0/2] Adding gpgpu_fill and media_fill on TGL Katarzyna Dec 2019-09-18 8:17 ` [igt-dev] [PATCH i-g-t v3 1/2] lib/gpgpu_fill/tgl: Implement gpgpu_fillfunc for TGL Katarzyna Dec @ 2019-09-18 8:17 ` Katarzyna Dec 2019-09-18 9:13 ` [igt-dev] ✓ Fi.CI.BAT: success for Adding gpgpu_fill and media_fill on TGL (rev2) Patchwork ` (2 subsequent siblings) 4 siblings, 0 replies; 7+ messages in thread From: Katarzyna Dec @ 2019-09-18 8:17 UTC (permalink / raw) To: igt-dev; +Cc: Lucas De Marchi Adding gen12_media_fillfunc to have media_fill running on TGL. Media shader was generated using IGA (Intel Graphics Assembler) based on binary found in lib/media_fill_gen9.c to match the changes in TGL HW. Main change was made in SEND instructions and adding SWSB dependencies. v2: Switched to GEN_12. Cc: Antonio Argenziano <antonio.argenziano@intel.com> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> Signed-off-by: Katarzyna Dec <katarzyna.dec@intel.com> Signed-off-by: Lukasz Kalamarz <lukasz.kalamarz@intel.com> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com> --- lib/i915/shaders/media/gen12_media_kernel.asm | 13 ++++++++++ lib/intel_batchbuffer.c | 4 ++- lib/media_fill.c | 25 +++++++++++++++++++ lib/media_fill.h | 7 ++++++ 4 files changed, 48 insertions(+), 1 deletion(-) create mode 100644 lib/i915/shaders/media/gen12_media_kernel.asm diff --git a/lib/i915/shaders/media/gen12_media_kernel.asm b/lib/i915/shaders/media/gen12_media_kernel.asm new file mode 100644 index 00000000..5be229b2 --- /dev/null +++ b/lib/i915/shaders/media/gen12_media_kernel.asm @@ -0,0 +1,13 @@ +L0: + mov (4|M0) r1.0<1>:ub r1.0<0;1,0>:ub + mov (8|M0) r4.0<1>:ud r0.0<8;8,1>:ud + mov (8|M0) r4.0<1>:ud r2.0<2;2,1>:ud + mov (1|M0) r4.2<1>:ud 0xF000F:ud + mov (16|M0) r5.0<1>:ud r1.0<0;1,0>:ud {@4} + mov (16|M0) r7.0<1>:ud r1.0<0;1,0>:ud {@5} + mov (16|M0) r9.0<1>:ud r1.0<0;1,0>:ud {@6} + mov (16|M0) r11.0<1>:ud r1.0<0;1,0>:ud {@7} + send.dc1 (16|M0) null r4 null 0x10000000 0x120A8000 {@1, $0} // wr:9h+0, rd:0, Media Block Write msc:0, to #0 + mov (8|M0) r112.0<1>:ud r0.0<8;8,1>:ud + send.ts (16|M0) null r112 null 0x10000000 0x2000010 {EOT, @1} // wr:1+0, rd:0, fc: 0x10 +L176: diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c index 269c8982..9292236b 100644 --- a/lib/intel_batchbuffer.c +++ b/lib/intel_batchbuffer.c @@ -861,7 +861,9 @@ igt_fillfunc_t igt_get_media_fillfunc(int devid) { igt_fillfunc_t fill = NULL; - if (IS_GEN9(devid) || IS_GEN10(devid) || IS_GEN11(devid)) + if (IS_GEN12(devid)) + fill = gen12_media_fillfunc; + else if (IS_GEN9(devid) || IS_GEN10(devid) || IS_GEN11(devid)) fill = gen9_media_fillfunc; else if (IS_GEN8(devid)) fill = gen8_media_fillfunc; diff --git a/lib/media_fill.c b/lib/media_fill.c index 03b5e71e..b7d7f68c 100644 --- a/lib/media_fill.c +++ b/lib/media_fill.c @@ -101,6 +101,20 @@ static const uint32_t gen11_media_vme_kernel[][4] = { { 0x00000000, 0x00000000, 0x00000000, 0x00000000 }, }; +static const uint32_t gen12_media_kernel[][4] = { + { 0x00020061, 0x01050000, 0x00000104, 0x00000000 }, + { 0x00030061, 0x04050220, 0x00460005, 0x00000000 }, + { 0x00030061, 0x04050220, 0x00220205, 0x00000000 }, + { 0x00000061, 0x04454220, 0x00000000, 0x000f000f }, + { 0x00040461, 0x05050220, 0x00000104, 0x00000000 }, + { 0x00040561, 0x07050220, 0x00000104, 0x00000000 }, + { 0x00040661, 0x09050220, 0x00000104, 0x00000000 }, + { 0x00040761, 0x0b050220, 0x00000104, 0x00000000 }, + { 0x00049031, 0x00000000, 0xc000044c, 0x12a00000 }, + { 0x00030061, 0x70050220, 0x00460005, 0x00000000 }, + { 0x00040131, 0x00000004, 0x7020700c, 0x10000000 }, +}; + /* * This sets up the media pipeline, * @@ -355,3 +369,14 @@ gen11_media_vme_func(struct intel_batchbuffer *batch, gen11_media_vme_kernel, sizeof(gen11_media_vme_kernel)); } + +void +gen12_media_fillfunc(struct intel_batchbuffer *batch, + const struct igt_buf *dst, + unsigned int x, unsigned int y, + unsigned int width, unsigned int height, + uint8_t color) +{ + __gen9_media_fillfunc(batch, dst, x, y, width, height, color, + gen12_media_kernel, sizeof(gen12_media_kernel)); +} diff --git a/lib/media_fill.h b/lib/media_fill.h index 1d5c5fa8..a001482e 100644 --- a/lib/media_fill.h +++ b/lib/media_fill.h @@ -55,4 +55,11 @@ gen11_media_vme_func(struct intel_batchbuffer *batch, unsigned int width, unsigned int height, const struct igt_buf *dst); +void +gen12_media_fillfunc(struct intel_batchbuffer *batch, + const struct igt_buf *dst, + unsigned int x, unsigned int y, + unsigned int width, unsigned int height, + uint8_t color); + #endif /* RENDE_MEDIA_FILL_H */ -- 2.20.1 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for Adding gpgpu_fill and media_fill on TGL (rev2) 2019-09-18 8:17 [igt-dev] [PATCH i-g-t v3 0/2] Adding gpgpu_fill and media_fill on TGL Katarzyna Dec 2019-09-18 8:17 ` [igt-dev] [PATCH i-g-t v3 1/2] lib/gpgpu_fill/tgl: Implement gpgpu_fillfunc for TGL Katarzyna Dec 2019-09-18 8:17 ` [igt-dev] [PATCH i-g-t v3 2/2] lib/media_fill/tgl: Implement media_fillfunc " Katarzyna Dec @ 2019-09-18 9:13 ` Patchwork 2019-09-18 14:14 ` [igt-dev] [PATCH i-g-t v3 0/2] Adding gpgpu_fill and media_fill on TGL Arkadiusz Hiler 2019-09-18 17:52 ` [igt-dev] ✓ Fi.CI.IGT: success for Adding gpgpu_fill and media_fill on TGL (rev2) Patchwork 4 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2019-09-18 9:13 UTC (permalink / raw) To: Katarzyna Dec; +Cc: igt-dev == Series Details == Series: Adding gpgpu_fill and media_fill on TGL (rev2) URL : https://patchwork.freedesktop.org/series/66804/ State : success == Summary == CI Bug Log - changes from IGT_5190 -> IGTPW_3472 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://patchwork.freedesktop.org/api/1.0/series/66804/revisions/2/mbox/ Known issues ------------ Here are the changes found in IGTPW_3472 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_mmap_gtt@basic-write-no-prefault: - fi-icl-u3: [PASS][1] -> [DMESG-WARN][2] ([fdo#107724]) +1 similar issue [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5190/fi-icl-u3/igt@gem_mmap_gtt@basic-write-no-prefault.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/fi-icl-u3/igt@gem_mmap_gtt@basic-write-no-prefault.html * igt@i915_selftest@live_execlists: - fi-skl-gvtdvm: [PASS][3] -> [DMESG-FAIL][4] ([fdo#111108]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5190/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html * igt@i915_selftest@live_hangcheck: - fi-icl-u3: [PASS][5] -> [DMESG-FAIL][6] ([fdo#111144] / [fdo#111678]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5190/fi-icl-u3/igt@i915_selftest@live_hangcheck.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/fi-icl-u3/igt@i915_selftest@live_hangcheck.html * igt@kms_pipe_crc_basic@read-crc-pipe-a: - fi-ilk-650: [PASS][7] -> [DMESG-WARN][8] ([fdo#106387]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5190/fi-ilk-650/igt@kms_pipe_crc_basic@read-crc-pipe-a.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/fi-ilk-650/igt@kms_pipe_crc_basic@read-crc-pipe-a.html #### Possible fixes #### * igt@debugfs_test@read_all_entries: - {fi-tgl-u2}: [DMESG-WARN][9] ([fdo#111600]) -> [PASS][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5190/fi-tgl-u2/igt@debugfs_test@read_all_entries.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/fi-tgl-u2/igt@debugfs_test@read_all_entries.html * igt@gem_ctx_create@basic-files: - {fi-icl-dsi}: [INCOMPLETE][11] ([fdo#107713] / [fdo#109100]) -> [PASS][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5190/fi-icl-dsi/igt@gem_ctx_create@basic-files.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/fi-icl-dsi/igt@gem_ctx_create@basic-files.html * igt@gem_ctx_switch@rcs0: - {fi-icl-guc}: [INCOMPLETE][13] ([fdo#107713]) -> [PASS][14] [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5190/fi-icl-guc/igt@gem_ctx_switch@rcs0.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/fi-icl-guc/igt@gem_ctx_switch@rcs0.html * igt@kms_frontbuffer_tracking@basic: - fi-hsw-peppy: [DMESG-WARN][15] ([fdo#102614]) -> [PASS][16] [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5190/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html * igt@prime_vgem@basic-read: - fi-icl-u3: [DMESG-WARN][17] ([fdo#107724]) -> [PASS][18] +1 similar issue [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5190/fi-icl-u3/igt@prime_vgem@basic-read.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/fi-icl-u3/igt@prime_vgem@basic-read.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614 [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602 [fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107 [fdo#106350]: https://bugs.freedesktop.org/show_bug.cgi?id=106350 [fdo#106387]: https://bugs.freedesktop.org/show_bug.cgi?id=106387 [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713 [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724 [fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100 [fdo#111108]: https://bugs.freedesktop.org/show_bug.cgi?id=111108 [fdo#111144]: https://bugs.freedesktop.org/show_bug.cgi?id=111144 [fdo#111562]: https://bugs.freedesktop.org/show_bug.cgi?id=111562 [fdo#111597]: https://bugs.freedesktop.org/show_bug.cgi?id=111597 [fdo#111600]: https://bugs.freedesktop.org/show_bug.cgi?id=111600 [fdo#111678]: https://bugs.freedesktop.org/show_bug.cgi?id=111678 Participating hosts (54 -> 46) ------------------------------ Additional (1): fi-pnv-d510 Missing (9): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-skl-guc fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_5190 -> IGTPW_3472 CI-20190529: 20190529 CI_DRM_6911: 2e04def5afc3b2bd724dc6f3f6525c5ebf1f87d2 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_3472: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/ IGT_5190: 0e9510b83502af3e230870df2d66d4f68918d3a4 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/ _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v3 0/2] Adding gpgpu_fill and media_fill on TGL 2019-09-18 8:17 [igt-dev] [PATCH i-g-t v3 0/2] Adding gpgpu_fill and media_fill on TGL Katarzyna Dec ` (2 preceding siblings ...) 2019-09-18 9:13 ` [igt-dev] ✓ Fi.CI.BAT: success for Adding gpgpu_fill and media_fill on TGL (rev2) Patchwork @ 2019-09-18 14:14 ` Arkadiusz Hiler 2019-09-19 7:31 ` Katarzyna Dec 2019-09-18 17:52 ` [igt-dev] ✓ Fi.CI.IGT: success for Adding gpgpu_fill and media_fill on TGL (rev2) Patchwork 4 siblings, 1 reply; 7+ messages in thread From: Arkadiusz Hiler @ 2019-09-18 14:14 UTC (permalink / raw) To: Katarzyna Dec; +Cc: igt-dev On Wed, Sep 18, 2019 at 10:17:43AM +0200, Katarzyna Dec wrote: > iPatches add media_fill and gpgpu_fill functions on TGL. > > v2: Switched to IS_GEN12 macro. > v3: Minor checkpatch changes > > Katarzyna Dec (2): > lib/gpgpu_fill/tgl: Implement gpgpu_fillfunc for TGL > lib/media_fill/tgl: Implement media_fillfunc for TGL > > lib/gpgpu_fill.c | 23 +++++++++++++++++ > lib/gpgpu_fill.h | 7 ++++++ > lib/i915/shaders/README | 2 ++ > lib/i915/shaders/gpgpu/gen12_gpgpu_kernel.asm | 12 +++++++++ > lib/i915/shaders/media/gen12_media_kernel.asm | 13 ++++++++++ > lib/intel_batchbuffer.c | 6 ++++- > lib/media_fill.c | 25 +++++++++++++++++++ > lib/media_fill.h | 7 ++++++ > 8 files changed, 94 insertions(+), 1 deletion(-) > create mode 100644 lib/i915/shaders/gpgpu/gen12_gpgpu_kernel.asm > create mode 100644 lib/i915/shaders/media/gen12_media_kernel.asm Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com> for the whole series _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v3 0/2] Adding gpgpu_fill and media_fill on TGL 2019-09-18 14:14 ` [igt-dev] [PATCH i-g-t v3 0/2] Adding gpgpu_fill and media_fill on TGL Arkadiusz Hiler @ 2019-09-19 7:31 ` Katarzyna Dec 0 siblings, 0 replies; 7+ messages in thread From: Katarzyna Dec @ 2019-09-19 7:31 UTC (permalink / raw) To: Arkadiusz Hiler, igt-dev On Wed, Sep 18, 2019 at 05:14:00PM +0300, Arkadiusz Hiler wrote: > On Wed, Sep 18, 2019 at 10:17:43AM +0200, Katarzyna Dec wrote: > > iPatches add media_fill and gpgpu_fill functions on TGL. > > > > v2: Switched to IS_GEN12 macro. > > v3: Minor checkpatch changes > > > > Katarzyna Dec (2): > > lib/gpgpu_fill/tgl: Implement gpgpu_fillfunc for TGL > > lib/media_fill/tgl: Implement media_fillfunc for TGL > > > > lib/gpgpu_fill.c | 23 +++++++++++++++++ > > lib/gpgpu_fill.h | 7 ++++++ > > lib/i915/shaders/README | 2 ++ > > lib/i915/shaders/gpgpu/gen12_gpgpu_kernel.asm | 12 +++++++++ > > lib/i915/shaders/media/gen12_media_kernel.asm | 13 ++++++++++ > > lib/intel_batchbuffer.c | 6 ++++- > > lib/media_fill.c | 25 +++++++++++++++++++ > > lib/media_fill.h | 7 ++++++ > > 8 files changed, 94 insertions(+), 1 deletion(-) > > create mode 100644 lib/i915/shaders/gpgpu/gen12_gpgpu_kernel.asm > > create mode 100644 lib/i915/shaders/media/gen12_media_kernel.asm > > Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com> > > for the whole series Pushed! Thanks :) Kasia _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 7+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for Adding gpgpu_fill and media_fill on TGL (rev2) 2019-09-18 8:17 [igt-dev] [PATCH i-g-t v3 0/2] Adding gpgpu_fill and media_fill on TGL Katarzyna Dec ` (3 preceding siblings ...) 2019-09-18 14:14 ` [igt-dev] [PATCH i-g-t v3 0/2] Adding gpgpu_fill and media_fill on TGL Arkadiusz Hiler @ 2019-09-18 17:52 ` Patchwork 4 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2019-09-18 17:52 UTC (permalink / raw) To: Katarzyna Dec; +Cc: igt-dev == Series Details == Series: Adding gpgpu_fill and media_fill on TGL (rev2) URL : https://patchwork.freedesktop.org/series/66804/ State : success == Summary == CI Bug Log - changes from IGT_5190_full -> IGTPW_3472_full ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://patchwork.freedesktop.org/api/1.0/series/66804/revisions/2/mbox/ Known issues ------------ Here are the changes found in IGTPW_3472_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_schedule@promotion-bsd: - shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#111325]) +2 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5190/shard-iclb3/igt@gem_exec_schedule@promotion-bsd.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/shard-iclb1/igt@gem_exec_schedule@promotion-bsd.html * igt@gem_exec_schedule@reorder-wide-bsd1: - shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276]) +15 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5190/shard-iclb4/igt@gem_exec_schedule@reorder-wide-bsd1.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/shard-iclb8/igt@gem_exec_schedule@reorder-wide-bsd1.html * igt@i915_suspend@fence-restore-untiled: - shard-apl: [PASS][5] -> [DMESG-WARN][6] ([fdo#108566]) +4 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5190/shard-apl4/igt@i915_suspend@fence-restore-untiled.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/shard-apl7/igt@i915_suspend@fence-restore-untiled.html * igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding: - shard-kbl: [PASS][7] -> [FAIL][8] ([fdo#103232]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5190/shard-kbl1/igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/shard-kbl3/igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding.html - shard-apl: [PASS][9] -> [FAIL][10] ([fdo#103232]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5190/shard-apl2/igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/shard-apl8/igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding.html * igt@kms_flip@2x-flip-vs-expired-vblank: - shard-glk: [PASS][11] -> [FAIL][12] ([fdo#105363]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5190/shard-glk4/igt@kms_flip@2x-flip-vs-expired-vblank.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/shard-glk5/igt@kms_flip@2x-flip-vs-expired-vblank.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-blt: - shard-iclb: [PASS][13] -> [FAIL][14] ([fdo#103167]) +4 similar issues [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5190/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-blt.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-blt.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-rte: - shard-iclb: [PASS][15] -> [FAIL][16] ([fdo#103167] / [fdo#110378]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5190/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-rte.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-rte.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a: - shard-hsw: [PASS][17] -> [INCOMPLETE][18] ([fdo#103540]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5190/shard-hsw2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/shard-hsw1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html * igt@kms_psr@psr2_primary_render: - shard-iclb: [PASS][19] -> [SKIP][20] ([fdo#109441]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5190/shard-iclb2/igt@kms_psr@psr2_primary_render.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/shard-iclb7/igt@kms_psr@psr2_primary_render.html * igt@kms_setmode@basic: - shard-kbl: [PASS][21] -> [FAIL][22] ([fdo#99912]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5190/shard-kbl7/igt@kms_setmode@basic.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/shard-kbl4/igt@kms_setmode@basic.html #### Possible fixes #### * igt@gem_exec_schedule@independent-bsd1: - shard-iclb: [SKIP][23] ([fdo#109276]) -> [PASS][24] +14 similar issues [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5190/shard-iclb6/igt@gem_exec_schedule@independent-bsd1.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/shard-iclb2/igt@gem_exec_schedule@independent-bsd1.html * igt@gem_exec_schedule@preemptive-hang-bsd: - shard-iclb: [SKIP][25] ([fdo#111325]) -> [PASS][26] +3 similar issues [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5190/shard-iclb2/igt@gem_exec_schedule@preemptive-hang-bsd.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/shard-iclb7/igt@gem_exec_schedule@preemptive-hang-bsd.html * igt@gem_mmap_gtt@hang: - shard-iclb: [FAIL][27] ([fdo#109677]) -> [PASS][28] [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5190/shard-iclb4/igt@gem_mmap_gtt@hang.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/shard-iclb6/igt@gem_mmap_gtt@hang.html * igt@i915_pm_rc6_residency@rc6-accuracy: - shard-kbl: [SKIP][29] ([fdo#109271]) -> [PASS][30] [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5190/shard-kbl1/igt@i915_pm_rc6_residency@rc6-accuracy.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/shard-kbl6/igt@i915_pm_rc6_residency@rc6-accuracy.html * igt@i915_pm_rpm@system-suspend-execbuf: - shard-kbl: [INCOMPLETE][31] ([fdo#103665] / [fdo#107807]) -> [PASS][32] [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5190/shard-kbl3/igt@i915_pm_rpm@system-suspend-execbuf.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/shard-kbl2/igt@i915_pm_rpm@system-suspend-execbuf.html * igt@i915_suspend@fence-restore-tiled2untiled: - shard-apl: [DMESG-WARN][33] ([fdo#108566]) -> [PASS][34] +6 similar issues [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5190/shard-apl6/igt@i915_suspend@fence-restore-tiled2untiled.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/shard-apl7/igt@i915_suspend@fence-restore-tiled2untiled.html * igt@kms_color@pipe-c-ctm-green-to-red: - shard-kbl: [FAIL][35] ([fdo#107201]) -> [PASS][36] [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5190/shard-kbl6/igt@kms_color@pipe-c-ctm-green-to-red.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/shard-kbl2/igt@kms_color@pipe-c-ctm-green-to-red.html - shard-apl: [FAIL][37] ([fdo#107201]) -> [PASS][38] [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5190/shard-apl3/igt@kms_color@pipe-c-ctm-green-to-red.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/shard-apl6/igt@kms_color@pipe-c-ctm-green-to-red.html * igt@kms_cursor_legacy@cursor-vs-flip-toggle: - shard-hsw: [FAIL][39] ([fdo#103355]) -> [PASS][40] [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5190/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/shard-hsw7/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible: - shard-glk: [FAIL][41] ([fdo#105363]) -> [PASS][42] [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5190/shard-glk3/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/shard-glk6/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html * igt@kms_flip@flip-vs-suspend-interruptible: - shard-hsw: [INCOMPLETE][43] ([fdo#103540]) -> [PASS][44] [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5190/shard-hsw5/igt@kms_flip@flip-vs-suspend-interruptible.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/shard-hsw5/igt@kms_flip@flip-vs-suspend-interruptible.html * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-blt: - shard-iclb: [FAIL][45] ([fdo#103167]) -> [PASS][46] [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5190/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-blt.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-blt.html * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-pwrite: - shard-glk: [FAIL][47] ([fdo#103167]) -> [PASS][48] [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5190/shard-glk9/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-pwrite.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/shard-glk2/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-pwrite.html * igt@kms_psr@psr2_basic: - shard-iclb: [SKIP][49] ([fdo#109441]) -> [PASS][50] +1 similar issue [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5190/shard-iclb3/igt@kms_psr@psr2_basic.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/shard-iclb2/igt@kms_psr@psr2_basic.html #### Warnings #### * igt@gem_mocs_settings@mocs-rc6-bsd2: - shard-iclb: [FAIL][51] ([fdo#111330]) -> [SKIP][52] ([fdo#109276]) [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5190/shard-iclb1/igt@gem_mocs_settings@mocs-rc6-bsd2.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/shard-iclb5/igt@gem_mocs_settings@mocs-rc6-bsd2.html * igt@gem_mocs_settings@mocs-settings-bsd2: - shard-iclb: [SKIP][53] ([fdo#109276]) -> [FAIL][54] ([fdo#111330]) [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5190/shard-iclb3/igt@gem_mocs_settings@mocs-settings-bsd2.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/shard-iclb2/igt@gem_mocs_settings@mocs-settings-bsd2.html [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232 [fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355 [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540 [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665 [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363 [fdo#107201]: https://bugs.freedesktop.org/show_bug.cgi?id=107201 [fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807 [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109677]: https://bugs.freedesktop.org/show_bug.cgi?id=109677 [fdo#110378]: https://bugs.freedesktop.org/show_bug.cgi?id=110378 [fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325 [fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330 [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912 Participating hosts (7 -> 6) ------------------------------ Missing (1): shard-skl Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_5190 -> IGTPW_3472 CI-20190529: 20190529 CI_DRM_6911: 2e04def5afc3b2bd724dc6f3f6525c5ebf1f87d2 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_3472: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/ IGT_5190: 0e9510b83502af3e230870df2d66d4f68918d3a4 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3472/ _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-09-19 7:31 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-09-18 8:17 [igt-dev] [PATCH i-g-t v3 0/2] Adding gpgpu_fill and media_fill on TGL Katarzyna Dec 2019-09-18 8:17 ` [igt-dev] [PATCH i-g-t v3 1/2] lib/gpgpu_fill/tgl: Implement gpgpu_fillfunc for TGL Katarzyna Dec 2019-09-18 8:17 ` [igt-dev] [PATCH i-g-t v3 2/2] lib/media_fill/tgl: Implement media_fillfunc " Katarzyna Dec 2019-09-18 9:13 ` [igt-dev] ✓ Fi.CI.BAT: success for Adding gpgpu_fill and media_fill on TGL (rev2) Patchwork 2019-09-18 14:14 ` [igt-dev] [PATCH i-g-t v3 0/2] Adding gpgpu_fill and media_fill on TGL Arkadiusz Hiler 2019-09-19 7:31 ` Katarzyna Dec 2019-09-18 17:52 ` [igt-dev] ✓ Fi.CI.IGT: success for Adding gpgpu_fill and media_fill on TGL (rev2) Patchwork
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox