From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Add over 32k HW stride tests
Date: Mon, 23 Sep 2019 15:43:37 +0300 [thread overview]
Message-ID: <20190923124337.GH1208@intel.com> (raw)
In-Reply-To: <1569235233-15674-2-git-send-email-juhapekka.heikkila@gmail.com>
On Mon, Sep 23, 2019 at 01:40:33PM +0300, Juha-Pekka Heikkila wrote:
> On ICL when using 64bpp formats strides can reach up to
> 64k. These test try exact maximum HW strides so gtt
> remapping will not come in play.
>
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
> tests/kms_big_fb.c | 103 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 103 insertions(+)
I believe all you should need is something like:
--- a/tests/kms_big_fb.c
+++ b/tests/kms_big_fb.c
@@ -161,9 +161,6 @@ static void max_fb_size(data_t *data, int *width, int *height,
uint64_t size;
int i = 0;
- *width = data->max_fb_width;
- *height = data->max_fb_height;
-
/* max fence stride is only 8k bytes on gen3 */
if (intel_gen(data->devid) < 4 &&
format == DRM_FORMAT_XRGB8888)
@@ -415,8 +412,16 @@ static bool test_pipe(data_t *data)
return ret;
}
-static void test_scanout(data_t *data)
+static void test_scanout(data_t *data, bool test_max_hw_stride)
{
+ if (test_max_hw_stride) {
+ data->big_fb_width = BIG;
+ data->big_fb_height = BIG;
+ } else {
+ data->big_fb_width = data->max_fb_width;
+ data->big_fb_height = data->max_fb_height;
+ }
+
max_fb_size(data, &data->big_fb_width, &data->big_fb_height,
data->format, data->modifier);
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-09-23 12:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 10:40 [igt-dev] [PATCH i-g-t] test longer than 32k strides Juha-Pekka Heikkila
2019-09-23 10:40 ` [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Add over 32k HW stride tests Juha-Pekka Heikkila
2019-09-23 12:43 ` Ville Syrjälä [this message]
2019-09-27 13:43 ` Juha-Pekka Heikkila
2019-09-27 13:50 ` Ville Syrjälä
[not found] ` <1571904804-2248-1-git-send-email-juhapekka.heikkila@gmail.com>
2019-10-24 13:55 ` [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Add max HW stride length tests Ville Syrjälä
2019-09-23 11:41 ` [igt-dev] ✗ GitLab.Pipeline: warning for tests/kms_big_fb: Add over 32k HW stride tests Patchwork
2019-09-23 11:45 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2019-09-23 13:01 ` [igt-dev] ✗ GitLab.Pipeline: warning for tests/kms_big_fb: Add over 32k HW stride tests (rev2) Patchwork
2019-09-23 17:18 ` [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_big_fb: Add over 32k HW stride tests Patchwork
2019-10-24 9:19 ` [igt-dev] ✗ GitLab.Pipeline: warning for tests/kms_big_fb: Add over 32k HW stride tests (rev3) Patchwork
2019-10-24 9:35 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2019-10-25 10:46 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190923124337.GH1208@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=juhapekka.heikkila@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox