public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Petri Latvala <petri.latvala@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Petri Latvala <petri.latvala@intel.com>
Subject: [igt-dev] [PATCH i-g-t v2 4/4] runner: Don't add timestamps when cannot exec a test
Date: Wed, 16 Oct 2019 15:02:47 +0300	[thread overview]
Message-ID: <20191016120247.5804-1-petri.latvala@intel.com> (raw)
In-Reply-To: <20191016111352.5212-4-petri.latvala@intel.com>

Don't add timestamps when printing that we cannot execute a binary
from a child (post fork-failed-execv). Timestamps were meant for
runner's direct output only, and this was accidentally converted.

v2: Rephrase commit message (Arek)

Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
 runner/executor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/runner/executor.c b/runner/executor.c
index 2bb82827..ba58fb17 100644
--- a/runner/executor.c
+++ b/runner/executor.c
@@ -1032,7 +1032,7 @@ execute_test_process(int outfd, int errfd,
 	}
 
 	execv(argv[0], argv);
-	errf("Cannot execute %s\n", argv[0]);
+	fprintf(stderr, "Cannot execute %s\n", argv[0]);
 	exit(IGT_EXIT_INVALID);
 }
 
-- 
2.19.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2019-10-16 12:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-16 11:13 [igt-dev] [PATCH i-g-t 1/4] runner: Produce skip instead of notrun for nonexisting tests Petri Latvala
2019-10-16 11:13 ` [igt-dev] [PATCH i-g-t 2/4] runner/resultgen: Refactor output parsing Petri Latvala
2019-10-16 11:13 ` [igt-dev] [PATCH i-g-t 3/4] runner/json_tests: Adapt to better " Petri Latvala
2019-10-16 11:27   ` Arkadiusz Hiler
2019-10-16 11:13 ` [igt-dev] [PATCH i-g-t 4/4] runner: Don't add timestamps when cannot exec a test Petri Latvala
2019-10-16 12:02   ` Petri Latvala [this message]
2019-10-16 12:08     ` [igt-dev] [PATCH i-g-t v2 " Arkadiusz Hiler
2019-10-16 11:31 ` [igt-dev] [PATCH i-g-t 1/4] runner: Produce skip instead of notrun for nonexisting tests Martin Peres
2019-10-16 12:07 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/4] " Patchwork
2019-10-16 12:47 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/4] runner: Produce skip instead of notrun for nonexisting tests (rev2) Patchwork
2019-10-16 13:19 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2019-10-16 22:10 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/4] runner: Produce skip instead of notrun for nonexisting tests Patchwork
2019-10-16 23:06 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/4] runner: Produce skip instead of notrun for nonexisting tests (rev2) Patchwork
2019-10-21 11:25 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191016120247.5804-1-petri.latvala@intel.com \
    --to=petri.latvala@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox