From: Martin Peres <martin.peres@linux.intel.com>
To: Petri Latvala <petri.latvala@intel.com>, igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 1/4] runner: Produce skip instead of notrun for nonexisting tests
Date: Wed, 16 Oct 2019 14:31:41 +0300 [thread overview]
Message-ID: <ccc8496d-68de-0392-3617-222d03d963b6@linux.intel.com> (raw)
In-Reply-To: <20191016111352.5212-1-petri.latvala@intel.com>
On 16/10/2019 14:13, Petri Latvala wrote:
> If a test was attempted but didn't actually exist, make it result in a
> skip instead of a notrun. This is to differentiate them from the tests
> that we didn't even attempt, like tests after getting a machine
> hang. This will improve handling of subtests for GEM engines that
> don't exist.
>
> Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Acked-by: Martin Peres <martin.peres@linux.intel.com>
> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Cc: Martin Peres <martin.peres@linux.intel.com>
> ---
> runner/resultgen.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/runner/resultgen.c b/runner/resultgen.c
> index 46c9d8d5..5faa8555 100644
> --- a/runner/resultgen.c
> +++ b/runner/resultgen.c
> @@ -732,7 +732,7 @@ static const char *result_from_exitcode(int exitcode)
> case IGT_EXIT_SUCCESS:
> return "pass";
> case IGT_EXIT_INVALID:
> - return "notrun";
> + return "skip";
> case INCOMPLETE_EXITCODE:
> return "incomplete";
> default:
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-10-16 11:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 11:13 [igt-dev] [PATCH i-g-t 1/4] runner: Produce skip instead of notrun for nonexisting tests Petri Latvala
2019-10-16 11:13 ` [igt-dev] [PATCH i-g-t 2/4] runner/resultgen: Refactor output parsing Petri Latvala
2019-10-16 11:13 ` [igt-dev] [PATCH i-g-t 3/4] runner/json_tests: Adapt to better " Petri Latvala
2019-10-16 11:27 ` Arkadiusz Hiler
2019-10-16 11:13 ` [igt-dev] [PATCH i-g-t 4/4] runner: Don't add timestamps when cannot exec a test Petri Latvala
2019-10-16 12:02 ` [igt-dev] [PATCH i-g-t v2 " Petri Latvala
2019-10-16 12:08 ` Arkadiusz Hiler
2019-10-16 11:31 ` Martin Peres [this message]
2019-10-16 12:07 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/4] runner: Produce skip instead of notrun for nonexisting tests Patchwork
2019-10-16 12:47 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/4] runner: Produce skip instead of notrun for nonexisting tests (rev2) Patchwork
2019-10-16 13:19 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2019-10-16 22:10 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/4] runner: Produce skip instead of notrun for nonexisting tests Patchwork
2019-10-16 23:06 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/4] runner: Produce skip instead of notrun for nonexisting tests (rev2) Patchwork
2019-10-21 11:25 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccc8496d-68de-0392-3617-222d03d963b6@linux.intel.com \
--to=martin.peres@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox