From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 2/3] lib/igt_draw: Fix blt tiled stride for gen2/3
Date: Fri, 29 Nov 2019 16:30:47 +0200 [thread overview]
Message-ID: <20191129143048.1936-2-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20191129143048.1936-1-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Gen2/3 blitter doesn't want us to do the /4 adjustment
to the tiled stride.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
lib/igt_draw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/igt_draw.c b/lib/igt_draw.c
index 11bbfd0a1353..7e0edec198d2 100644
--- a/lib/igt_draw.c
+++ b/lib/igt_draw.c
@@ -551,7 +551,7 @@ static void draw_rect_blt(int fd, struct cmd_data *cmd_data,
blt_cmd_len = (gen >= 8) ? 0x5 : 0x4;
blt_cmd_tiling = (tiling) ? XY_COLOR_BLT_TILED : 0;
- pitch = (tiling) ? buf->stride / 4 : buf->stride;
+ pitch = (gen >= 4 && tiling) ? buf->stride / 4 : buf->stride;
switch_blt_tiling(batch, tiling, true);
--
2.23.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-11-29 14:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-29 14:30 [igt-dev] [PATCH i-g-t 1/3] lib/igt_draw: BCS_SWCTRL is gen6+ Ville Syrjala
2019-11-29 14:30 ` Ville Syrjala [this message]
2019-11-29 15:08 ` [igt-dev] [PATCH i-g-t 2/3] lib/igt_draw: Fix blt tiled stride for gen2/3 Chris Wilson
2019-11-29 14:30 ` [igt-dev] [PATCH i-g-t 3/3] tests/kms_rmfb: Use COMMIT_UNIVERSAL for overlay/cursor planes Ville Syrjala
2019-11-29 15:04 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] lib/igt_draw: BCS_SWCTRL is gen6+ Patchwork
2019-11-29 15:07 ` [igt-dev] [PATCH i-g-t 1/3] " Chris Wilson
2019-11-30 10:39 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/3] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191129143048.1936-2-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox