* [igt-dev] [RESEND PATCH i-g-t] tests/prime_vgem: Give meaningful messages on SKIP
@ 2020-01-16 10:13 Janusz Krzysztofik
2020-01-16 10:21 ` [igt-dev] [Intel-gfx] " Petri Latvala
2020-01-16 10:51 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/prime_vgem: Give meaningful messages on SKIP (rev2) Patchwork
0 siblings, 2 replies; 3+ messages in thread
From: Janusz Krzysztofik @ 2020-01-16 10:13 UTC (permalink / raw)
To: igt-dev; +Cc: intel-gfx
Messages displayed on SKIPs introduced by commit 92caadb4e551
("tests/prime_vgem: Skip basic-read/write subtests if not supported")
don't inform clearly enough that those SKIPs are expected behavior.
Fix it.
Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Reviewed-by: Ewelina Musial <ewelina.musial@intel.com>
---
Assuming the R-b: from Ewelina is sufficient, can someone push this,
please? I can't do that myself as I have no push permissions.
Thanks,
Janusz
tests/prime_vgem.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/tests/prime_vgem.c b/tests/prime_vgem.c
index 6595818c..3bdb2300 100644
--- a/tests/prime_vgem.c
+++ b/tests/prime_vgem.c
@@ -46,7 +46,8 @@ static void test_read(int vgem, int i915)
handle = prime_fd_to_handle(i915, dmabuf);
close(dmabuf);
- igt_skip_on(__gem_read(i915, handle, 0, &i, sizeof(i)));
+ igt_skip_on_f(__gem_read(i915, handle, 0, &i, sizeof(i)),
+ "PREAD from dma-buf not supported on this hardware\n");
ptr = vgem_mmap(vgem, &scratch, PROT_WRITE);
for (i = 0; i < 1024; i++)
@@ -83,7 +84,8 @@ static void test_fence_read(int i915, int vgem)
handle = prime_fd_to_handle(i915, dmabuf);
close(dmabuf);
- igt_skip_on(__gem_read(i915, handle, 0, &i, sizeof(i)));
+ igt_skip_on_f(__gem_read(i915, handle, 0, &i, sizeof(i)),
+ "PREAD from dma-buf not supported on this hardware\n");
igt_fork(child, 1) {
close(master[0]);
@@ -195,7 +197,8 @@ static void test_write(int vgem, int i915)
handle = prime_fd_to_handle(i915, dmabuf);
close(dmabuf);
- igt_skip_on(__gem_write(i915, handle, 0, &i, sizeof(i)));
+ igt_skip_on_f(__gem_write(i915, handle, 0, &i, sizeof(i)),
+ "PWRITE to dma-buf not supported on this hardware\n");
ptr = vgem_mmap(vgem, &scratch, PROT_READ);
gem_close(vgem, scratch.handle);
--
2.21.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-16 10:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-16 10:13 [igt-dev] [RESEND PATCH i-g-t] tests/prime_vgem: Give meaningful messages on SKIP Janusz Krzysztofik
2020-01-16 10:21 ` [igt-dev] [Intel-gfx] " Petri Latvala
2020-01-16 10:51 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/prime_vgem: Give meaningful messages on SKIP (rev2) Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox