From: Petri Latvala <petri.latvala@intel.com>
To: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 4/4] runner_tests: Test that dynamic subtest failure is handled correctly
Date: Thu, 16 Jan 2020 13:47:19 +0200 [thread overview]
Message-ID: <20200116114719.GR25209@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20200115130915.afkcbio4qu3muoxl@ahiler-desk1.fi.intel.com>
On Wed, Jan 15, 2020 at 03:09:15PM +0200, Arkadiusz Hiler wrote:
> On Tue, Jan 14, 2020 at 11:17:45AM +0200, Petri Latvala wrote:
> > See also: commit 0e6457f1bfe2 ("lib: Don't dump log buffer when
> > dynamic subtest failure is inherited")
> >
> > This is quite an explicit top-to-bottom test that we don't get an
> > incorrect warn result for an innocent dynamic subtest. It is tested
> > here in runner_test instead of testing in lib/tests that the extra
> > lines are not printed, because not printing the extra lines is an
> > implementation detail that might change later. The issue is after all
> > about test results parsed by igt_runner.
> >
> > Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> > Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
>
> The whole series is
>
> Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
>
> although I would squash patch 3 and 4 together
Squashed and merged, with Arek's IRC ack on the end result.
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-01-16 11:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 9:17 [igt-dev] [PATCH i-g-t 1/4] lib: Don't dump log buffer when dynamic subtest failure is inherited Petri Latvala
2020-01-14 9:17 ` [igt-dev] [PATCH i-g-t 2/4] runner_tests: Replace magic numbers with named constants Petri Latvala
2020-01-14 9:17 ` [igt-dev] [PATCH i-g-t 3/4] runner_tests: Add new mockup test binary Petri Latvala
2020-01-14 9:17 ` [igt-dev] [PATCH i-g-t 4/4] runner_tests: Test that dynamic subtest failure is handled correctly Petri Latvala
2020-01-15 13:09 ` Arkadiusz Hiler
2020-01-16 11:47 ` Petri Latvala [this message]
2020-01-14 9:38 ` [igt-dev] ✗ GitLab.Pipeline: warning for series starting with [i-g-t,1/4] lib: Don't dump log buffer when dynamic subtest failure is inherited Patchwork
2020-01-14 10:12 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2020-01-16 10:36 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200116114719.GR25209@platvala-desk.ger.corp.intel.com \
--to=petri.latvala@intel.com \
--cc=arkadiusz.hiler@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox