public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] runner: Don't check for taints when not configured for it
@ 2020-01-23 11:15 Petri Latvala
  2020-01-23 11:23 ` Chris Wilson
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Petri Latvala @ 2020-01-23 11:15 UTC (permalink / raw)
  To: igt-dev; +Cc: Petri Latvala

If someone wants to execute tests without aborting when tainted, they
get all their tests just straight up killed on the first taint without
actually aborting execution. Obey their wishes and keep running.

Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 runner/executor.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/runner/executor.c b/runner/executor.c
index 71483b74..0927d1fd 100644
--- a/runner/executor.c
+++ b/runner/executor.c
@@ -759,7 +759,7 @@ static int monitor_output(pid_t child,
 			return -1;
 		}
 
-		if (tainted(&taints)) /* cancel children after a kernel OOPS */
+		if (settings->abort_mask & ABORT_TAINT && tainted(&taints)) /* cancel children after a kernel OOPS */
 			n = 0, intervals_left = 1;
 
 		if (n == 0) {
@@ -768,6 +768,7 @@ static int monitor_output(pid_t child,
 
 			switch (killed) {
 			case 0:
+				/* If abort_mask doesn't have taint set, taints is still 0 here */
 				if (!is_tainted(taints)) {
 					show_kernel_task_state();
 					if (settings->log_level >= LOG_LEVEL_NORMAL) {
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-01-24 14:47 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-23 11:15 [igt-dev] [PATCH i-g-t] runner: Don't check for taints when not configured for it Petri Latvala
2020-01-23 11:23 ` Chris Wilson
2020-01-23 12:30 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-01-24  6:45 ` [igt-dev] ✗ GitLab.Pipeline: warning " Patchwork
2020-01-24 14:47 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox