From: Imre Deak <imre.deak@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH v2 5/7] lib/igt_fb: Fall back from gtt map to coherent map on platforms w/o aperture
Date: Thu, 30 Jan 2020 20:30:59 +0200 [thread overview]
Message-ID: <20200130183101.20930-5-imre.deak@intel.com> (raw)
In-Reply-To: <20200130183101.20930-1-imre.deak@intel.com>
Use a device coherent map instead of GGTT map on platforms w/o an
aperture.
Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
lib/igt_fb.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index f8ed8622..613a9706 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -2379,18 +2379,23 @@ static void destroy_cairo_surface__gtt(void *arg)
static void *map_bo(int fd, struct igt_fb *fb)
{
+ bool is_i915 = is_i915_device(fd);
void *ptr;
- if (is_i915_device(fd))
+ if (is_i915)
gem_set_domain(fd, fb->gem_handle,
I915_GEM_DOMAIN_GTT, I915_GEM_DOMAIN_GTT);
if (fb->is_dumb)
ptr = kmstest_dumb_map_buffer(fd, fb->gem_handle, fb->size,
PROT_READ | PROT_WRITE);
- else if (is_i915_device(fd))
+ else if (is_i915 && gem_has_mappable_ggtt(fd))
ptr = gem_mmap__gtt(fd, fb->gem_handle, fb->size,
PROT_READ | PROT_WRITE);
+ else if (is_i915)
+ ptr = gem_mmap__device_coherent(fd, fb->gem_handle, 0,
+ fb->size,
+ PROT_READ | PROT_WRITE);
else if (is_vc4_device(fd))
ptr = igt_vc4_mmap_bo(fd, fb->gem_handle, fb->size,
PROT_READ | PROT_WRITE);
--
2.23.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-01-30 18:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 18:30 [igt-dev] [PATCH v2 1/7] lib/igt_fb: Fix creating FBs on platforms w/o HW detiling Imre Deak
2020-01-30 18:30 ` [igt-dev] [PATCH v2 2/7] lib/intel_batchbuffer: Add blitter copy using XY_SRC_COPY_BLT Imre Deak
2020-01-30 18:30 ` [igt-dev] [PATCH v2 3/7] lib/igt_fb: Switch from XY_FAST_COPY_BLT to XY_SRC_COPY_BLT Imre Deak
2020-01-30 18:30 ` [igt-dev] [PATCH v2 4/7] lib/igt_fb: Add 64bpp support to the XY_SRC blit command Imre Deak
2020-01-30 18:30 ` Imre Deak [this message]
2020-01-30 18:31 ` [igt-dev] [PATCH v2 6/7] lib/igt_fb: Use render copy/blit on platforms w/o HW detiling Imre Deak
2020-01-30 18:31 ` [igt-dev] [PATCH v2 7/7] lib/igt_fb: Speed up format conversion for local memory Imre Deak
2020-01-30 19:04 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [v2,1/7] lib/igt_fb: Fix creating FBs on platforms w/o HW detiling Patchwork
2020-01-31 6:54 ` [igt-dev] [PATCH v2 1/7] " Dixit, Ashutosh
2020-02-02 8:45 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [v2,1/7] " Patchwork
2020-02-03 12:08 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200130183101.20930-5-imre.deak@intel.com \
--to=imre.deak@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox