From: Imre Deak <imre.deak@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH v2 7/7] lib/igt_fb: Speed up format conversion for local memory
Date: Thu, 30 Jan 2020 20:31:01 +0200 [thread overview]
Message-ID: <20200130183101.20930-7-imre.deak@intel.com> (raw)
In-Reply-To: <20200130183101.20930-1-imre.deak@intel.com>
To speed up the conversion that needs to read from a dGFX local memory
use the same trick as what's used for GTT apertures and make a copy
first into system memory.
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
lib/igt_fb.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index 2be03380..af3291a2 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -3430,6 +3430,10 @@ static void create_cairo_surface__convert(int fd, struct igt_fb *fb)
if (use_enginecopy(fb) || use_blitter(fb) ||
igt_vc4_is_tiled(fb->modifier)) {
setup_linear_mapping(&blit->base);
+
+ /* speed things up by working from a copy in system memory */
+ cvt.src.slow_reads =
+ is_i915_device(fd) && !gem_has_mappable_ggtt(fd);
} else {
blit->base.linear.fb = *fb;
blit->base.linear.fb.gem_handle = 0;
--
2.23.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-01-30 18:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 18:30 [igt-dev] [PATCH v2 1/7] lib/igt_fb: Fix creating FBs on platforms w/o HW detiling Imre Deak
2020-01-30 18:30 ` [igt-dev] [PATCH v2 2/7] lib/intel_batchbuffer: Add blitter copy using XY_SRC_COPY_BLT Imre Deak
2020-01-30 18:30 ` [igt-dev] [PATCH v2 3/7] lib/igt_fb: Switch from XY_FAST_COPY_BLT to XY_SRC_COPY_BLT Imre Deak
2020-01-30 18:30 ` [igt-dev] [PATCH v2 4/7] lib/igt_fb: Add 64bpp support to the XY_SRC blit command Imre Deak
2020-01-30 18:30 ` [igt-dev] [PATCH v2 5/7] lib/igt_fb: Fall back from gtt map to coherent map on platforms w/o aperture Imre Deak
2020-01-30 18:31 ` [igt-dev] [PATCH v2 6/7] lib/igt_fb: Use render copy/blit on platforms w/o HW detiling Imre Deak
2020-01-30 18:31 ` Imre Deak [this message]
2020-01-30 19:04 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [v2,1/7] lib/igt_fb: Fix creating FBs " Patchwork
2020-01-31 6:54 ` [igt-dev] [PATCH v2 1/7] " Dixit, Ashutosh
2020-02-02 8:45 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [v2,1/7] " Patchwork
2020-02-03 12:08 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200130183101.20930-7-imre.deak@intel.com \
--to=imre.deak@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox