public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Petri Latvala <petri.latvala@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>,
	Petri Latvala <petri.latvala@intel.com>
Subject: [igt-dev] [PATCH i-g-t] runner: Print an error message if resume fails to load data
Date: Mon, 10 Feb 2020 12:56:53 +0200	[thread overview]
Message-ID: <20200210105653.20323-1-petri.latvala@intel.com> (raw)

If metadata.txt or other vital data files are missing from a
results-directory, igt_resume silently exited. Print an error message
to the user so it's somewhat clear why we didn't resume the
execution.

Closes: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/69
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
 runner/resume.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/runner/resume.c b/runner/resume.c
index d5a20e80..08129ffb 100644
--- a/runner/resume.c
+++ b/runner/resume.c
@@ -32,10 +32,12 @@ int main(int argc, char **argv)
 	}
 
 	if (!initialize_execute_state_from_resume(dirfd, &state, &settings, &job_list)) {
+		fprintf(stderr, "Failure reading data from %s\n", argv[1]);
 		return 1;
 	}
 
 	if (!execute(&state, &settings, &job_list)) {
+		fprintf(stderr, "Executing tests failed, stopping.\n");
 		exitcode = 1;
 	}
 
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2020-02-10 10:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-10 10:56 Petri Latvala [this message]
2020-02-10 13:18 ` [igt-dev] ✗ GitLab.Pipeline: warning for runner: Print an error message if resume fails to load data Patchwork
2020-02-10 13:23   ` Petri Latvala
2020-02-10 13:34     ` Arkadiusz Hiler
2020-02-10 14:10 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2020-02-10 15:27 ` [igt-dev] [PATCH i-g-t] " Arkadiusz Hiler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200210105653.20323-1-petri.latvala@intel.com \
    --to=petri.latvala@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=tomi.p.sarvela@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox