public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] runner: Print an error message if resume fails to load data
@ 2020-02-10 10:56 Petri Latvala
  2020-02-10 13:18 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Petri Latvala @ 2020-02-10 10:56 UTC (permalink / raw)
  To: igt-dev; +Cc: Tomi Sarvela, Petri Latvala

If metadata.txt or other vital data files are missing from a
results-directory, igt_resume silently exited. Print an error message
to the user so it's somewhat clear why we didn't resume the
execution.

Closes: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/69
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
 runner/resume.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/runner/resume.c b/runner/resume.c
index d5a20e80..08129ffb 100644
--- a/runner/resume.c
+++ b/runner/resume.c
@@ -32,10 +32,12 @@ int main(int argc, char **argv)
 	}
 
 	if (!initialize_execute_state_from_resume(dirfd, &state, &settings, &job_list)) {
+		fprintf(stderr, "Failure reading data from %s\n", argv[1]);
 		return 1;
 	}
 
 	if (!execute(&state, &settings, &job_list)) {
+		fprintf(stderr, "Executing tests failed, stopping.\n");
 		exitcode = 1;
 	}
 
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-02-10 15:27 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-10 10:56 [igt-dev] [PATCH i-g-t] runner: Print an error message if resume fails to load data Petri Latvala
2020-02-10 13:18 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork
2020-02-10 13:23   ` Petri Latvala
2020-02-10 13:34     ` Arkadiusz Hiler
2020-02-10 14:10 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2020-02-10 15:27 ` [igt-dev] [PATCH i-g-t] " Arkadiusz Hiler

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox