Re: [igt-dev] [PATCH i-g-t 1/1] tools/generate_cb_buffer: Add script to assemble CB kernel

From: Petri Latvala <petri.latvala@intel.com>
To: "Abodunrin, Akeem G" <akeem.g.abodunrin@intel.com>
Cc: "Luck, Tony" <tony.luck@intel.com>,
	"Aran, Omer" <omer.aran@intel.com>,
	"Nikula, Jani" <jani.nikula@intel.com>,
	"Wilson, Chris P" <chris.p.wilson@intel.com>,
	"Stewart, David C" <david.c.stewart@intel.com>,
	"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
	"Pathi, Pragyansri" <pragyansri.pathi@intel.com>,
	"Bloomfield, Jon" <jon.bloomfield@intel.com>,
	"Vetter, Daniel" <daniel.vetter@intel.com>,
	"Kuoppala, Mika" <mika.kuoppala@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t 1/1] tools/generate_cb_buffer: Add script to assemble CB kernel
Date: Fri, 21 Feb 2020 11:58:16 +0200	[thread overview]
Message-ID: <20200221095816.GZ25209@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <CFEEE81102D91947B9CC368106979EBAC8A160B0@ORSMSX102.amr.corp.intel.com>

On Thu, Feb 20, 2020 at 10:22:48PM +0200, Abodunrin, Akeem G wrote:
> > On Thu, Feb 20, 2020 at 03:06:09AM +0200, Abodunrin, Akeem G wrote:
> > > > > +export ASSEMBLY_SOURCE=./tools/assembly_source
> > > > > +
> > > > > +function get_help {
> > > > > +        echo "Usage:    asm_eu_kernel.sh [options]"
> > > > > +        echo "Remember to run this as root"
> > > >
> > > > I can't spot why this would need root.
> > > Since we are generating new file, and writing to it - the script
> > > definitely needs root access... otherwise commands like this "
> > > prefix_header $i915_filename "Media CB Kernel for gen7.5 devices""
> > > fails
> > 
> > That's no reason to need root. That's just a reason to need write access to the
> > directory where you're creating the files.
> > 
> > As you require the script to be run in IGT source root and writing to $cwd, you
> > need write access to IGT source root. Which shouldn't be root-owned.
> 
> I got you - but I don't think this is a big deal - I will remove it in the next spin... but not sure it adds any value at this point.
> > 
> > 
> > > >
> > > >
> > > > > +        echo " "
> > > > > +        echo "Please make sure your MESA tool is compiled, and
> > > > > + run this script
> > > > from igt home directory"
> > > >
> > > > Mesa written as "Mesa" and IGT written as "IGT". And it's "source
> > > > root directory", not "home directory".
> > > >
> > > > Does the assembler require specific build options for Mesa? Note them here.
> > >
> > > Yes, it does - but the options are hardcoded in this script - so, mentioning them
> > in the help function is irrelevant...
> > 
> > I'm asking about the Mesa _build_ options. This script doesn't build Mesa, it just
> > uses it.
> > 
> > From a quick check that would be -Dtools=intel that is required.
> I don't think Mesa requires Kernel build options to work, AFAIK - it is a standalone tool that could be installed in different ways as mentioned here "https://www.mesa3d.org/install.html" - So, no need for that information.


Kernel build options? When I said Mesa, I meant Mesa. The line that
states "make sure your Mesa tool is compiled" needs to add " with
-Dtools=intel " because the assembler won't be there otherwise!


-- 
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev