* [igt-dev] [PATCH i-g-t 1/3] lib/igt_debugfs: Add igt_crc_get_for_frame()
@ 2020-02-21 20:50 Ville Syrjala
2020-02-21 20:50 ` [igt-dev] [PATCH i-g-t 2/3] tests/kms_plane: Pipeline crc capture and flips Ville Syrjala
` (6 more replies)
0 siblings, 7 replies; 10+ messages in thread
From: Ville Syrjala @ 2020-02-21 20:50 UTC (permalink / raw)
To: igt-dev
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Add a new helper to return the crc for a specific frame.
Useful when we pipeline flips and crc captures more deeply
to eliminate dead time between the flips.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
lib/igt_debugfs.c | 31 ++++++++++++++++++++++++-------
lib/igt_debugfs.h | 2 ++
2 files changed, 26 insertions(+), 7 deletions(-)
diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c
index 8cac9d1e148e..bf6be552057a 100644
--- a/lib/igt_debugfs.c
+++ b/lib/igt_debugfs.c
@@ -945,17 +945,16 @@ void igt_pipe_crc_get_single(igt_pipe_crc_t *pipe_crc, igt_crc_t *crc)
* igt_pipe_crc_get_current:
* @drm_fd: Pointer to drm fd for vblank counter
* @pipe_crc: pipe CRC object
+ * @vblank: frame counter value we're looking for
* @crc: buffer pointer for the captured CRC value
*
- * Same as igt_pipe_crc_get_single(), but will wait until a new CRC can be captured.
- * This is useful for retrieving the current CRC in a more race free way than
- * igt_pipe_crc_drain() + igt_pipe_crc_get_single().
+ * Same as igt_pipe_crc_get_single(), but will wait until a CRC has been captured
+ * for frame @vblank.
*/
void
-igt_pipe_crc_get_current(int drm_fd, igt_pipe_crc_t *pipe_crc, igt_crc_t *crc)
+igt_pipe_crc_get_for_frame(int drm_fd, igt_pipe_crc_t *pipe_crc,
+ unsigned int vblank, igt_crc_t *crc)
{
- unsigned vblank = kmstest_get_vblank(drm_fd, pipe_crc->pipe, 0);
-
do {
read_one_crc(pipe_crc, crc);
@@ -965,11 +964,29 @@ igt_pipe_crc_get_current(int drm_fd, igt_pipe_crc_t *pipe_crc, igt_crc_t *crc)
igt_pipe_crc_get_single(pipe_crc, crc);
return;
}
- } while (igt_vblank_before_eq(crc->frame, vblank));
+ } while (igt_vblank_before(crc->frame, vblank));
crc_sanity_checks(pipe_crc, crc);
}
+/**
+ * igt_pipe_crc_get_current:
+ * @drm_fd: Pointer to drm fd for vblank counter
+ * @pipe_crc: pipe CRC object
+ * @crc: buffer pointer for the captured CRC value
+ *
+ * Same as igt_pipe_crc_get_single(), but will wait until a new CRC can be captured.
+ * This is useful for retrieving the current CRC in a more race free way than
+ * igt_pipe_crc_drain() + igt_pipe_crc_get_single().
+ */
+void
+igt_pipe_crc_get_current(int drm_fd, igt_pipe_crc_t *pipe_crc, igt_crc_t *crc)
+{
+ unsigned vblank = kmstest_get_vblank(drm_fd, pipe_crc->pipe, 0) + 1;
+
+ return igt_pipe_crc_get_for_frame(drm_fd, pipe_crc, vblank, crc);
+}
+
/**
* igt_pipe_crc_collect_crc:
* @pipe_crc: pipe CRC object
diff --git a/lib/igt_debugfs.h b/lib/igt_debugfs.h
index 1e0cc108d6fb..7d1a6175ed64 100644
--- a/lib/igt_debugfs.h
+++ b/lib/igt_debugfs.h
@@ -104,6 +104,8 @@ int igt_pipe_crc_get_crcs(igt_pipe_crc_t *pipe_crc, int n_crcs,
void igt_pipe_crc_drain(igt_pipe_crc_t *pipe_crc);
void igt_pipe_crc_get_single(igt_pipe_crc_t *pipe_crc, igt_crc_t *out_crc);
void igt_pipe_crc_get_current(int drm_fd, igt_pipe_crc_t *pipe_crc, igt_crc_t *crc);
+void igt_pipe_crc_get_for_frame(int drm_fd, igt_pipe_crc_t *pipe_crc,
+ unsigned int vblank, igt_crc_t *crc);
void igt_pipe_crc_collect_crc(igt_pipe_crc_t *pipe_crc, igt_crc_t *out_crc);
--
2.24.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 10+ messages in thread* [igt-dev] [PATCH i-g-t 2/3] tests/kms_plane: Pipeline crc capture and flips 2020-02-21 20:50 [igt-dev] [PATCH i-g-t 1/3] lib/igt_debugfs: Add igt_crc_get_for_frame() Ville Syrjala @ 2020-02-21 20:50 ` Ville Syrjala 2020-02-26 20:51 ` [igt-dev] [PATCH i-g-t v2 " Ville Syrjala 2020-02-21 20:50 ` [igt-dev] [PATCH i-g-t 3/3] tests/kms_plane: Use non-blocking commits for pixel format tests Ville Syrjala ` (5 subsequent siblings) 6 siblings, 1 reply; 10+ messages in thread From: Ville Syrjala @ 2020-02-21 20:50 UTC (permalink / raw) To: igt-dev From: Ville Syrjälä <ville.syrjala@linux.intel.com> Eliminate some dead time used to wait for crcs by pipelining the flips and crc capture. On KBL: time kms_plane --r pixel-format-pipe-A-planes - real 0m22,592s + real 0m14,527s time kms_plane --r pixel-format-pipe-A-planes --extended - real 1m8,090s + real 0m38,738s To keep the code somewhat sane we only pipeline while capturing the colors for a single pixel format. That does still leave a few non-pipelined frames when switching from one pixel format to another. Which explains why the extended test gets closer to the -50% mark as it tests more colors and thus has a larger proportion of optimally pipelined flips. Not sure how horrible the code would become if we tried to maintain the pipelining throughout the test. For now let's just accept the small victory and move on. v2: Use igt_pipe_crc_get_for_frame() to make sure we get the right crc even if the next fb preparation takes longer than one frame Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> --- tests/kms_plane.c | 107 +++++++++++++++++++++++++++++++--------------- 1 file changed, 73 insertions(+), 34 deletions(-) diff --git a/tests/kms_plane.c b/tests/kms_plane.c index 9ef3a7f3c1b0..550b6ad3d81d 100644 --- a/tests/kms_plane.c +++ b/tests/kms_plane.c @@ -440,15 +440,14 @@ static bool set_c8_legacy_lut(data_t *data, enum pipe pipe, return true; } -static void test_format_plane_color(data_t *data, enum pipe pipe, - igt_plane_t *plane, - uint32_t format, uint64_t modifier, - int width, int height, - enum igt_color_encoding color_encoding, - enum igt_color_range color_range, - const color_t *c, igt_crc_t *crc, struct igt_fb *fb) +static void prepare_format_color(data_t *data, enum pipe pipe, + igt_plane_t *plane, + uint32_t format, uint64_t modifier, + int width, int height, + enum igt_color_encoding color_encoding, + enum igt_color_range color_range, + const color_t *c, struct igt_fb *fb) { - struct igt_fb old_fb = *fb; cairo_t *cr; if (data->crop == 0 || format == DRM_FORMAT_XRGB8888) { @@ -499,11 +498,6 @@ static void test_format_plane_color(data_t *data, enum pipe pipe, igt_fb_set_size(fb, plane, width, height); igt_plane_set_size(plane, width, height); } - - igt_display_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_UNIVERSAL); - igt_pipe_crc_get_current(data->display.drm_fd, data->pipe_crc, crc); - - igt_remove_fb(data->drm_fd, &old_fb); } static int num_unique_crcs(const igt_crc_t crc[], int num_crc) @@ -525,6 +519,62 @@ static int num_unique_crcs(const igt_crc_t crc[], int num_crc) return num_unique_crc; } +static void capture_format_crcs(data_t *data, enum pipe pipe, + igt_plane_t *plane, + uint32_t format, uint64_t modifier, + int width, int height, + enum igt_color_encoding encoding, + enum igt_color_range range, + igt_crc_t crc[], struct igt_fb *fb) +{ + unsigned int vblank[ARRAY_SIZE(colors_extended)]; + int i; + + for (i = 0; i < data->num_colors; i++) { + const color_t *c = &data->colors[i]; + struct igt_fb old_fb = *fb; + + prepare_format_color(data, pipe, plane, format, modifier, + width, height, encoding, range, c, fb); + + /* + * The flip issued during frame N will latch + * at the start of frame N+1, and its CRC will + * be ready at the start of frame N+2. So the + * CRC captured here before the flip is issued + * is for frame N-2. + */ + if (i >= 2) + igt_pipe_crc_get_for_frame(data->drm_fd, data->pipe_crc, + vblank[i - 2], &crc[i - 2]); + + igt_display_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_UNIVERSAL); + /* + * TODO: Use flip events to get this. Would also allow + * switching to non-blocking commits so that the next + * fb can be prepared in parallel to waiting for the + * flip to complete. + * + * crc is available one frame after the flip latches + */ + vblank[i] = kmstest_get_vblank(data->drm_fd, pipe, 0) + 1; + + igt_remove_fb(data->drm_fd, &old_fb); + } + + /* + * Get the remaining two crcs + * + * TODO: avoid the extra wait by maintaining the pipeline + * between different pixel formats as well? Could get messy. + */ + igt_pipe_crc_get_for_frame(data->drm_fd, data->pipe_crc, + vblank[i - 2], &crc[i - 2]); + i++; + igt_pipe_crc_get_for_frame(data->drm_fd, data->pipe_crc, + vblank[i - 2], &crc[i - 2]); +} + static bool test_format_plane_colors(data_t *data, enum pipe pipe, igt_plane_t *plane, uint32_t format, uint64_t modifier, @@ -534,21 +584,17 @@ static bool test_format_plane_colors(data_t *data, enum pipe pipe, igt_crc_t ref_crc[], struct igt_fb *fb) { - int crc_mismatch_count = 0; + igt_crc_t crc[ARRAY_SIZE(colors_extended)]; unsigned int crc_mismatch_mask = 0; + int crc_mismatch_count = 0; bool result = true; + int i; - for (int i = 0; i < data->num_colors; i++) { - const color_t *c = &data->colors[i]; - igt_crc_t crc; - - test_format_plane_color(data, pipe, plane, - format, modifier, - width, height, - encoding, range, - c, &crc, fb); + capture_format_crcs(data, pipe, plane, format, modifier, + width, height, encoding, range, crc, fb); - if (!igt_check_crc_equal(&crc, &ref_crc[i])) { + for (i = 0; i < data->num_colors; i++) { + if (!igt_check_crc_equal(&crc[i], &ref_crc[i])) { crc_mismatch_count++; crc_mismatch_mask |= (1 << i); result = false; @@ -700,16 +746,9 @@ static bool test_format_plane(data_t *data, enum pipe pipe, igt_remove_fb(data->drm_fd, &test_fb); } - for (int i = 0; i < data->num_colors; i++) { - const color_t *c = &data->colors[i]; - - test_format_plane_color(data, pipe, plane, - format, modifier, - width, height, - IGT_COLOR_YCBCR_BT709, - IGT_COLOR_YCBCR_LIMITED_RANGE, - c, &ref_crc[i], &fb); - } + capture_format_crcs(data, pipe, plane, format, modifier, + width, height, IGT_COLOR_YCBCR_BT709, + IGT_COLOR_YCBCR_LIMITED_RANGE, ref_crc, &fb); /* * Make sure we have some difference between the colors. This -- 2.24.1 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [igt-dev] [PATCH i-g-t v2 2/3] tests/kms_plane: Pipeline crc capture and flips 2020-02-21 20:50 ` [igt-dev] [PATCH i-g-t 2/3] tests/kms_plane: Pipeline crc capture and flips Ville Syrjala @ 2020-02-26 20:51 ` Ville Syrjala 0 siblings, 0 replies; 10+ messages in thread From: Ville Syrjala @ 2020-02-26 20:51 UTC (permalink / raw) To: igt-dev From: Ville Syrjälä <ville.syrjala@linux.intel.com> Eliminate some dead time used to wait for crcs by pipelining the flips and crc capture. On KBL: time kms_plane --r pixel-format-pipe-A-planes - real 0m22,592s + real 0m14,527s time kms_plane --r pixel-format-pipe-A-planes --extended - real 1m8,090s + real 0m38,738s To keep the code somewhat sane we only pipeline while capturing the colors for a single pixel format. That does still leave a few non-pipelined frames when switching from one pixel format to another. Which explains why the extended test gets closer to the -50% mark as it tests more colors and thus has a larger proportion of optimally pipelined flips. Not sure how horrible the code would become if we tried to maintain the pipelining throughout the test. For now let's just accept the small victory and move on. v2: Use igt_pipe_crc_get_for_frame() to make sure we get the right crc even if the next fb preparation takes longer than one frame v3: Don't assume more than one color Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> --- tests/kms_plane.c | 107 +++++++++++++++++++++++++++++++--------------- 1 file changed, 73 insertions(+), 34 deletions(-) diff --git a/tests/kms_plane.c b/tests/kms_plane.c index 9ef3a7f3c1b0..8a5b89b2ae95 100644 --- a/tests/kms_plane.c +++ b/tests/kms_plane.c @@ -440,15 +440,14 @@ static bool set_c8_legacy_lut(data_t *data, enum pipe pipe, return true; } -static void test_format_plane_color(data_t *data, enum pipe pipe, - igt_plane_t *plane, - uint32_t format, uint64_t modifier, - int width, int height, - enum igt_color_encoding color_encoding, - enum igt_color_range color_range, - const color_t *c, igt_crc_t *crc, struct igt_fb *fb) +static void prepare_format_color(data_t *data, enum pipe pipe, + igt_plane_t *plane, + uint32_t format, uint64_t modifier, + int width, int height, + enum igt_color_encoding color_encoding, + enum igt_color_range color_range, + const color_t *c, struct igt_fb *fb) { - struct igt_fb old_fb = *fb; cairo_t *cr; if (data->crop == 0 || format == DRM_FORMAT_XRGB8888) { @@ -499,11 +498,6 @@ static void test_format_plane_color(data_t *data, enum pipe pipe, igt_fb_set_size(fb, plane, width, height); igt_plane_set_size(plane, width, height); } - - igt_display_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_UNIVERSAL); - igt_pipe_crc_get_current(data->display.drm_fd, data->pipe_crc, crc); - - igt_remove_fb(data->drm_fd, &old_fb); } static int num_unique_crcs(const igt_crc_t crc[], int num_crc) @@ -525,6 +519,62 @@ static int num_unique_crcs(const igt_crc_t crc[], int num_crc) return num_unique_crc; } +static void capture_format_crcs(data_t *data, enum pipe pipe, + igt_plane_t *plane, + uint32_t format, uint64_t modifier, + int width, int height, + enum igt_color_encoding encoding, + enum igt_color_range range, + igt_crc_t crc[], struct igt_fb *fb) +{ + unsigned int vblank[ARRAY_SIZE(colors_extended)]; + int i; + + for (i = 0; i < data->num_colors; i++) { + const color_t *c = &data->colors[i]; + struct igt_fb old_fb = *fb; + + prepare_format_color(data, pipe, plane, format, modifier, + width, height, encoding, range, c, fb); + + /* + * The flip issued during frame N will latch + * at the start of frame N+1, and its CRC will + * be ready at the start of frame N+2. So the + * CRC captured here before the flip is issued + * is for frame N-2. + */ + if (i >= 2) + igt_pipe_crc_get_for_frame(data->drm_fd, data->pipe_crc, + vblank[i - 2], &crc[i - 2]); + + igt_display_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_UNIVERSAL); + /* + * TODO: Use flip events to get this. Would also allow + * switching to non-blocking commits so that the next + * fb can be prepared in parallel to waiting for the + * flip to complete. + * + * crc is available one frame after the flip latches + */ + vblank[i] = kmstest_get_vblank(data->drm_fd, pipe, 0) + 1; + + igt_remove_fb(data->drm_fd, &old_fb); + } + + /* + * Get the remaining two crcs + * + * TODO: avoid the extra wait by maintaining the pipeline + * between different pixel formats as well? Could get messy. + */ + if (i >= 2) + igt_pipe_crc_get_for_frame(data->drm_fd, data->pipe_crc, + vblank[i - 2], &crc[i - 2]); + igt_pipe_crc_get_for_frame(data->drm_fd, data->pipe_crc, + vblank[i - 1], &crc[i - 1]); +} + static bool test_format_plane_colors(data_t *data, enum pipe pipe, igt_plane_t *plane, uint32_t format, uint64_t modifier, @@ -534,21 +584,17 @@ static bool test_format_plane_colors(data_t *data, enum pipe pipe, igt_crc_t ref_crc[], struct igt_fb *fb) { - int crc_mismatch_count = 0; + igt_crc_t crc[ARRAY_SIZE(colors_extended)]; unsigned int crc_mismatch_mask = 0; + int crc_mismatch_count = 0; bool result = true; + int i; - for (int i = 0; i < data->num_colors; i++) { - const color_t *c = &data->colors[i]; - igt_crc_t crc; - - test_format_plane_color(data, pipe, plane, - format, modifier, - width, height, - encoding, range, - c, &crc, fb); + capture_format_crcs(data, pipe, plane, format, modifier, + width, height, encoding, range, crc, fb); - if (!igt_check_crc_equal(&crc, &ref_crc[i])) { + for (i = 0; i < data->num_colors; i++) { + if (!igt_check_crc_equal(&crc[i], &ref_crc[i])) { crc_mismatch_count++; crc_mismatch_mask |= (1 << i); result = false; @@ -700,16 +746,9 @@ static bool test_format_plane(data_t *data, enum pipe pipe, igt_remove_fb(data->drm_fd, &test_fb); } - for (int i = 0; i < data->num_colors; i++) { - const color_t *c = &data->colors[i]; - - test_format_plane_color(data, pipe, plane, - format, modifier, - width, height, - IGT_COLOR_YCBCR_BT709, - IGT_COLOR_YCBCR_LIMITED_RANGE, - c, &ref_crc[i], &fb); - } + capture_format_crcs(data, pipe, plane, format, modifier, + width, height, IGT_COLOR_YCBCR_BT709, + IGT_COLOR_YCBCR_LIMITED_RANGE, ref_crc, &fb); /* * Make sure we have some difference between the colors. This -- 2.24.1 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [igt-dev] [PATCH i-g-t 3/3] tests/kms_plane: Use non-blocking commits for pixel format tests 2020-02-21 20:50 [igt-dev] [PATCH i-g-t 1/3] lib/igt_debugfs: Add igt_crc_get_for_frame() Ville Syrjala 2020-02-21 20:50 ` [igt-dev] [PATCH i-g-t 2/3] tests/kms_plane: Pipeline crc capture and flips Ville Syrjala @ 2020-02-21 20:50 ` Ville Syrjala 2020-02-26 20:52 ` [igt-dev] [PATCH i-g-t v2 " Ville Syrjala 2020-02-21 21:21 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] lib/igt_debugfs: Add igt_crc_get_for_frame() Patchwork ` (4 subsequent siblings) 6 siblings, 1 reply; 10+ messages in thread From: Ville Syrjala @ 2020-02-21 20:50 UTC (permalink / raw) To: igt-dev From: Ville Syrjälä <ville.syrjala@linux.intel.com> Use non-blocking commits when testing pixel formats so that we can start preparing the next fb even before the current fb has been latched by the hardware. Eliminates an extra frame for each color in cases where preparing the next fb takes longer than a frame. For non-atomic drivers we can't do this as drmModePageFlip() won't allow us to change pixel formats, or set any of the YUV color encoding/range propeties. Hence we must stick to plain old blocking setplane/setprop there. On KBL w/ 2048x1080 plane size: time kms_plane --r pixel-format-pipe-A-planes --extended - real 2m8,529s + real 1m52,078s time kms_plane --r pixel-format-pipe-A-planes - real 0m44,135s + real 0m40,116s Won't help modern platforms since they always use a 64x64 plane, but older platforms may benefit as they can't reduce the primary plane size. Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> --- tests/kms_plane.c | 43 +++++++++++++++++++++++++++++++++---------- 1 file changed, 33 insertions(+), 10 deletions(-) diff --git a/tests/kms_plane.c b/tests/kms_plane.c index 550b6ad3d81d..083b7ea1c98f 100644 --- a/tests/kms_plane.c +++ b/tests/kms_plane.c @@ -528,6 +528,7 @@ static void capture_format_crcs(data_t *data, enum pipe pipe, igt_crc_t crc[], struct igt_fb *fb) { unsigned int vblank[ARRAY_SIZE(colors_extended)]; + struct drm_event_vblank ev; int i; for (i = 0; i < data->num_colors; i++) { @@ -537,6 +538,12 @@ static void capture_format_crcs(data_t *data, enum pipe pipe, prepare_format_color(data, pipe, plane, format, modifier, width, height, encoding, range, c, fb); + if (data->display.is_atomic && i >= 1) { + igt_assert(read(data->drm_fd, &ev, sizeof(ev)) == sizeof(ev)); + /* crc is available one frame after the flip latches */ + vblank[i - 1] = ev.sequence + 1; + } + /* * The flip issued during frame N will latch * at the start of frame N+1, and its CRC will @@ -548,20 +555,36 @@ static void capture_format_crcs(data_t *data, enum pipe pipe, igt_pipe_crc_get_for_frame(data->drm_fd, data->pipe_crc, vblank[i - 2], &crc[i - 2]); - igt_display_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_UNIVERSAL); - /* - * TODO: Use flip events to get this. Would also allow - * switching to non-blocking commits so that the next - * fb can be prepared in parallel to waiting for the - * flip to complete. - * - * crc is available one frame after the flip latches - */ - vblank[i] = kmstest_get_vblank(data->drm_fd, pipe, 0) + 1; + if (data->display.is_atomic) { + /* + * Use non-blocking commits to allow the next fb + * to be prepared in parallel while the current fb + * awaits to be latched. + */ + igt_display_commit_atomic(&data->display, + DRM_MODE_ATOMIC_NONBLOCK | + DRM_MODE_PAGE_FLIP_EVENT, NULL); + } else { + /* + * Can't use drmModePageFlip() since we need to + * change pixel format and potentially update some + * properties as well. + */ + igt_display_commit2(&data->display, COMMIT_UNIVERSAL); + + /* crc is available one frame after the flip latches */ + vblank[i] = kmstest_get_vblank(data->drm_fd, pipe, 0) + 1; + } igt_remove_fb(data->drm_fd, &old_fb); } + if (data->display.is_atomic) { + igt_assert(read(data->drm_fd, &ev, sizeof(ev)) == sizeof(ev)); + /* crc is available one frame after the flip latches */ + vblank[i - 1] = ev.sequence + 1; + } + /* * Get the remaining two crcs * -- 2.24.1 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [igt-dev] [PATCH i-g-t v2 3/3] tests/kms_plane: Use non-blocking commits for pixel format tests 2020-02-21 20:50 ` [igt-dev] [PATCH i-g-t 3/3] tests/kms_plane: Use non-blocking commits for pixel format tests Ville Syrjala @ 2020-02-26 20:52 ` Ville Syrjala 0 siblings, 0 replies; 10+ messages in thread From: Ville Syrjala @ 2020-02-26 20:52 UTC (permalink / raw) To: igt-dev From: Ville Syrjälä <ville.syrjala@linux.intel.com> Use non-blocking commits when testing pixel formats so that we can start preparing the next fb even before the current fb has been latched by the hardware. Eliminates an extra frame for each color in cases where preparing the next fb takes longer than a frame. For non-atomic drivers we can't do this as drmModePageFlip() won't allow us to change pixel formats, or set any of the YUV color encoding/range propeties. Hence we must stick to plain old blocking setplane/setprop there. On KBL w/ 2048x1080 plane size: time kms_plane --r pixel-format-pipe-A-planes --extended - real 2m8,529s + real 1m52,078s time kms_plane --r pixel-format-pipe-A-planes - real 0m44,135s + real 0m40,116s Won't help modern platforms since they always use a 64x64 plane, but older platforms may benefit as they can't reduce the primary plane size. v2: Assert we get got the crc for the correct frame (Martin) Due to above add a vblank wait for cursor setplane. Make it more robust against the rendering taking a long time by grabbing the crc for the last possible frame rather than the first possible frame. Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> --- tests/kms_plane.c | 88 ++++++++++++++++++++++++++++++++++++++--------- 1 file changed, 72 insertions(+), 16 deletions(-) diff --git a/tests/kms_plane.c b/tests/kms_plane.c index 8a5b89b2ae95..805795cd4ed0 100644 --- a/tests/kms_plane.c +++ b/tests/kms_plane.c @@ -519,6 +519,15 @@ static int num_unique_crcs(const igt_crc_t crc[], int num_crc) return num_unique_crc; } +static void capture_crc(data_t *data, unsigned int vblank, igt_crc_t *crc) +{ + igt_pipe_crc_get_for_frame(data->drm_fd, data->pipe_crc, vblank, crc); + + igt_fail_on_f(crc->has_valid_frame && crc->frame != vblank, + "Got CRC for the wrong frame (got %u, expected %u). CRC buffer overflow?\n", + crc->frame, vblank); +} + static void capture_format_crcs(data_t *data, enum pipe pipe, igt_plane_t *plane, uint32_t format, uint64_t modifier, @@ -528,6 +537,7 @@ static void capture_format_crcs(data_t *data, enum pipe pipe, igt_crc_t crc[], struct igt_fb *fb) { unsigned int vblank[ARRAY_SIZE(colors_extended)]; + struct drm_event_vblank ev; int i; for (i = 0; i < data->num_colors; i++) { @@ -537,6 +547,16 @@ static void capture_format_crcs(data_t *data, enum pipe pipe, prepare_format_color(data, pipe, plane, format, modifier, width, height, encoding, range, c, fb); + if (data->display.is_atomic && i >= 1) { + igt_assert(read(data->drm_fd, &ev, sizeof(ev)) == sizeof(ev)); + /* + * The last time we saw the crc for + * flip N-2 is when the flip N-1 latched. + */ + if (i >= 2) + vblank[i - 2] = ev.sequence; + } + /* * The flip issued during frame N will latch * at the start of frame N+1, and its CRC will @@ -545,23 +565,61 @@ static void capture_format_crcs(data_t *data, enum pipe pipe, * is for frame N-2. */ if (i >= 2) - igt_pipe_crc_get_for_frame(data->drm_fd, data->pipe_crc, - vblank[i - 2], &crc[i - 2]); + capture_crc(data, vblank[i - 2], &crc[i - 2]); - igt_display_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_UNIVERSAL); - /* - * TODO: Use flip events to get this. Would also allow - * switching to non-blocking commits so that the next - * fb can be prepared in parallel to waiting for the - * flip to complete. - * - * crc is available one frame after the flip latches - */ - vblank[i] = kmstest_get_vblank(data->drm_fd, pipe, 0) + 1; + if (data->display.is_atomic) { + /* + * Use non-blocking commits to allow the next fb + * to be prepared in parallel while the current fb + * awaits to be latched. + */ + igt_display_commit_atomic(&data->display, + DRM_MODE_ATOMIC_NONBLOCK | + DRM_MODE_PAGE_FLIP_EVENT, NULL); + } else { + /* + * Last moment to grab the previous crc + * is when the next flip latches. + */ + if (i >= 1) + vblank[i - 1] = kmstest_get_vblank(data->drm_fd, pipe, 0) + 1; + + /* + * Can't use drmModePageFlip() since we need to + * change pixel format and potentially update some + * properties as well. + */ + igt_display_commit2(&data->display, COMMIT_UNIVERSAL); + + /* setplane for the cursor does not block */ + if (plane->type == DRM_PLANE_TYPE_CURSOR) + igt_wait_for_vblank(data->drm_fd, pipe); + } igt_remove_fb(data->drm_fd, &old_fb); } + if (data->display.is_atomic) { + igt_assert(read(data->drm_fd, &ev, sizeof(ev)) == sizeof(ev)); + /* + * The last time we saw the crc for + * flip N-2 is when the flip N-1 latched. + */ + if (i >= 2) + vblank[i - 2] = ev.sequence; + /* + * The last crc is available earliest one + * frame after the last flip latched. + */ + vblank[i - 1] = ev.sequence + 1; + } else { + /* + * The last crc is available earliest one + * frame after the last flip latched. + */ + vblank[i - 1] = kmstest_get_vblank(data->drm_fd, pipe, 0) + 1; + } + /* * Get the remaining two crcs * @@ -569,10 +627,8 @@ static void capture_format_crcs(data_t *data, enum pipe pipe, * between different pixel formats as well? Could get messy. */ if (i >= 2) - igt_pipe_crc_get_for_frame(data->drm_fd, data->pipe_crc, - vblank[i - 2], &crc[i - 2]); - igt_pipe_crc_get_for_frame(data->drm_fd, data->pipe_crc, - vblank[i - 1], &crc[i - 1]); + capture_crc(data, vblank[i - 2], &crc[i - 2]); + capture_crc(data, vblank[i - 1], &crc[i - 1]); } static bool test_format_plane_colors(data_t *data, enum pipe pipe, -- 2.24.1 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] lib/igt_debugfs: Add igt_crc_get_for_frame() 2020-02-21 20:50 [igt-dev] [PATCH i-g-t 1/3] lib/igt_debugfs: Add igt_crc_get_for_frame() Ville Syrjala 2020-02-21 20:50 ` [igt-dev] [PATCH i-g-t 2/3] tests/kms_plane: Pipeline crc capture and flips Ville Syrjala 2020-02-21 20:50 ` [igt-dev] [PATCH i-g-t 3/3] tests/kms_plane: Use non-blocking commits for pixel format tests Ville Syrjala @ 2020-02-21 21:21 ` Patchwork 2020-02-24 12:49 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork ` (3 subsequent siblings) 6 siblings, 0 replies; 10+ messages in thread From: Patchwork @ 2020-02-21 21:21 UTC (permalink / raw) To: Ville Syrjala; +Cc: igt-dev == Series Details == Series: series starting with [i-g-t,1/3] lib/igt_debugfs: Add igt_crc_get_for_frame() URL : https://patchwork.freedesktop.org/series/73793/ State : success == Summary == CI Bug Log - changes from CI_DRM_7983 -> IGTPW_4215 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/index.html Known issues ------------ Here are the changes found in IGTPW_4215 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_selftest@live_gtt: - fi-bdw-5557u: [PASS][1] -> [TIMEOUT][2] ([fdo#112271]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/fi-bdw-5557u/igt@i915_selftest@live_gtt.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/fi-bdw-5557u/igt@i915_selftest@live_gtt.html * igt@i915_selftest@live_sanitycheck: - fi-icl-u3: [PASS][3] -> [DMESG-WARN][4] ([i915#585]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/fi-icl-u3/igt@i915_selftest@live_sanitycheck.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/fi-icl-u3/igt@i915_selftest@live_sanitycheck.html * igt@kms_chamelium@hdmi-hpd-fast: - fi-kbl-7500u: [PASS][5] -> [FAIL][6] ([fdo#111096] / [i915#323]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html * igt@kms_frontbuffer_tracking@basic: - fi-hsw-peppy: [PASS][7] -> [DMESG-WARN][8] ([i915#44]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html * igt@prime_self_import@basic-llseek-size: - fi-tgl-y: [PASS][9] -> [DMESG-WARN][10] ([CI#94] / [i915#402]) +2 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/fi-tgl-y/igt@prime_self_import@basic-llseek-size.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/fi-tgl-y/igt@prime_self_import@basic-llseek-size.html #### Possible fixes #### * igt@gem_exec_suspend@basic-s4-devices: - fi-tgl-y: [FAIL][11] ([CI#94]) -> [PASS][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/fi-tgl-y/igt@gem_exec_suspend@basic-s4-devices.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/fi-tgl-y/igt@gem_exec_suspend@basic-s4-devices.html * igt@gem_mmap_gtt@basic: - fi-tgl-y: [DMESG-WARN][13] ([CI#94] / [i915#402]) -> [PASS][14] +1 similar issue [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/fi-tgl-y/igt@gem_mmap_gtt@basic.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/fi-tgl-y/igt@gem_mmap_gtt@basic.html * igt@i915_selftest@live_gt_lrc: - {fi-tgl-u}: [DMESG-FAIL][15] ([i915#1233]) -> [PASS][16] [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/fi-tgl-u/igt@i915_selftest@live_gt_lrc.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/fi-tgl-u/igt@i915_selftest@live_gt_lrc.html #### Warnings #### * igt@amdgpu/amd_prime@amd-to-i915: - fi-icl-u3: [SKIP][17] ([fdo#109315] / [i915#585]) -> [SKIP][18] ([fdo#109315]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/fi-icl-u3/igt@amdgpu/amd_prime@amd-to-i915.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/fi-icl-u3/igt@amdgpu/amd_prime@amd-to-i915.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [CI#94]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/94 [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315 [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096 [fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271 [i915#1233]: https://gitlab.freedesktop.org/drm/intel/issues/1233 [i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323 [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402 [i915#44]: https://gitlab.freedesktop.org/drm/intel/issues/44 [i915#585]: https://gitlab.freedesktop.org/drm/intel/issues/585 Participating hosts (51 -> 45) ------------------------------ Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-ctg-p8600 fi-byt-clapper fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_5458 -> IGTPW_4215 CI-20190529: 20190529 CI_DRM_7983: 85ccd7de7d75735a667c4133b0927481986a2a1c @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_4215: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/index.html IGT_5458: 5f7e4ae6a91ed2c104593b8abd5b71a6cc96fc10 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/index.html _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 10+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/3] lib/igt_debugfs: Add igt_crc_get_for_frame() 2020-02-21 20:50 [igt-dev] [PATCH i-g-t 1/3] lib/igt_debugfs: Add igt_crc_get_for_frame() Ville Syrjala ` (2 preceding siblings ...) 2020-02-21 21:21 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] lib/igt_debugfs: Add igt_crc_get_for_frame() Patchwork @ 2020-02-24 12:49 ` Patchwork 2020-02-26 21:50 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] lib/igt_debugfs: Add igt_crc_get_for_frame() (rev3) Patchwork ` (2 subsequent siblings) 6 siblings, 0 replies; 10+ messages in thread From: Patchwork @ 2020-02-24 12:49 UTC (permalink / raw) To: Ville Syrjala; +Cc: igt-dev == Series Details == Series: series starting with [i-g-t,1/3] lib/igt_debugfs: Add igt_crc_get_for_frame() URL : https://patchwork.freedesktop.org/series/73793/ State : success == Summary == CI Bug Log - changes from CI_DRM_7983_full -> IGTPW_4215_full ==================================================== Summary ------- **WARNING** Minor unknown changes coming with IGTPW_4215_full need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in IGTPW_4215_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/index.html Possible new issues ------------------- Here are the unknown changes that may have been introduced in IGTPW_4215_full: ### IGT changes ### #### Warnings #### * igt@perf@gen12-mi-rpc: - shard-tglb: [TIMEOUT][1] ([fdo#112271] / [i915#1085]) -> [SKIP][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-tglb5/igt@perf@gen12-mi-rpc.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-tglb3/igt@perf@gen12-mi-rpc.html - shard-iclb: [SKIP][3] ([fdo#109289]) -> [SKIP][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-iclb6/igt@perf@gen12-mi-rpc.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-iclb7/igt@perf@gen12-mi-rpc.html Known issues ------------ Here are the changes found in IGTPW_4215_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_shared@exec-single-timeline-bsd: - shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#110841]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-iclb3/igt@gem_ctx_shared@exec-single-timeline-bsd.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-iclb2/igt@gem_ctx_shared@exec-single-timeline-bsd.html * igt@gem_exec_balancer@smoke: - shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#110854]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-iclb4/igt@gem_exec_balancer@smoke.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-iclb8/igt@gem_exec_balancer@smoke.html * igt@gem_exec_schedule@preempt-other-chain-bsd: - shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#112146]) +5 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-iclb6/igt@gem_exec_schedule@preempt-other-chain-bsd.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-iclb1/igt@gem_exec_schedule@preempt-other-chain-bsd.html * igt@gem_mmap_gtt@cpuset-medium-copy-xy: - shard-snb: [PASS][11] -> [DMESG-WARN][12] ([i915#478]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-snb6/igt@gem_mmap_gtt@cpuset-medium-copy-xy.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-snb5/igt@gem_mmap_gtt@cpuset-medium-copy-xy.html * igt@gem_ppgtt@flink-and-close-vma-leak: - shard-glk: [PASS][13] -> [FAIL][14] ([i915#644]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-glk5/igt@gem_ppgtt@flink-and-close-vma-leak.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-glk4/igt@gem_ppgtt@flink-and-close-vma-leak.html * igt@i915_pm_rps@waitboost: - shard-tglb: [PASS][15] -> [FAIL][16] ([i915#413]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-tglb1/igt@i915_pm_rps@waitboost.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-tglb1/igt@i915_pm_rps@waitboost.html * igt@i915_suspend@debugfs-reader: - shard-kbl: [PASS][17] -> [INCOMPLETE][18] ([fdo#103665]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-kbl3/igt@i915_suspend@debugfs-reader.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-kbl2/igt@i915_suspend@debugfs-reader.html * igt@kms_big_fb@x-tiled-64bpp-rotate-0: - shard-snb: [PASS][19] -> [SKIP][20] ([fdo#109271]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-snb5/igt@kms_big_fb@x-tiled-64bpp-rotate-0.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-snb1/igt@kms_big_fb@x-tiled-64bpp-rotate-0.html * igt@kms_cursor_crc@pipe-b-cursor-suspend: - shard-apl: [PASS][21] -> [DMESG-WARN][22] ([i915#180]) +2 similar issues [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-apl2/igt@kms_cursor_crc@pipe-b-cursor-suspend.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-apl1/igt@kms_cursor_crc@pipe-b-cursor-suspend.html * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-shrfb-plflip-blt: - shard-glk: [PASS][23] -> [FAIL][24] ([i915#49]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-glk3/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-shrfb-plflip-blt.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-glk3/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-shrfb-plflip-blt.html * igt@kms_psr@psr2_sprite_plane_move: - shard-iclb: [PASS][25] -> [SKIP][26] ([fdo#109441]) +1 similar issue [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-iclb7/igt@kms_psr@psr2_sprite_plane_move.html * igt@kms_setmode@basic: - shard-glk: [PASS][27] -> [FAIL][28] ([i915#31]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-glk7/igt@kms_setmode@basic.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-glk3/igt@kms_setmode@basic.html - shard-kbl: [PASS][29] -> [FAIL][30] ([i915#31]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-kbl7/igt@kms_setmode@basic.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-kbl2/igt@kms_setmode@basic.html * igt@kms_vblank@pipe-a-ts-continuation-suspend: - shard-kbl: [PASS][31] -> [DMESG-WARN][32] ([i915#180]) +4 similar issues [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-kbl6/igt@kms_vblank@pipe-a-ts-continuation-suspend.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-kbl3/igt@kms_vblank@pipe-a-ts-continuation-suspend.html * igt@perf@i915-ref-count: - shard-iclb: [PASS][33] -> [SKIP][34] ([i915#276]) +4 similar issues [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-iclb3/igt@perf@i915-ref-count.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-iclb6/igt@perf@i915-ref-count.html * igt@perf@short-reads: - shard-tglb: [PASS][35] -> [SKIP][36] ([fdo#112172]) +4 similar issues [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-tglb6/igt@perf@short-reads.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-tglb5/igt@perf@short-reads.html * igt@perf_pmu@busy-no-semaphores-vcs1: - shard-iclb: [PASS][37] -> [SKIP][38] ([fdo#112080]) +9 similar issues [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-iclb4/igt@perf_pmu@busy-no-semaphores-vcs1.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-iclb7/igt@perf_pmu@busy-no-semaphores-vcs1.html * igt@prime_busy@hang-bsd2: - shard-iclb: [PASS][39] -> [SKIP][40] ([fdo#109276]) +14 similar issues [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-iclb1/igt@prime_busy@hang-bsd2.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-iclb6/igt@prime_busy@hang-bsd2.html * igt@sw_sync@sync_multi_producer_single_consumer: - shard-snb: [PASS][41] -> [TIMEOUT][42] ([fdo#112271]) [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-snb5/igt@sw_sync@sync_multi_producer_single_consumer.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-snb6/igt@sw_sync@sync_multi_producer_single_consumer.html #### Possible fixes #### * igt@gem_ctx_isolation@rcs0-s3: - shard-apl: [DMESG-WARN][43] ([i915#180]) -> [PASS][44] +1 similar issue [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-apl1/igt@gem_ctx_isolation@rcs0-s3.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-apl2/igt@gem_ctx_isolation@rcs0-s3.html * {igt@gem_ctx_persistence@close-replace-race}: - shard-tglb: [INCOMPLETE][45] ([i915#1291]) -> [PASS][46] [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-tglb8/igt@gem_ctx_persistence@close-replace-race.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-tglb1/igt@gem_ctx_persistence@close-replace-race.html - shard-iclb: [INCOMPLETE][47] ([i915#1291]) -> [PASS][48] [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-iclb4/igt@gem_ctx_persistence@close-replace-race.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-iclb5/igt@gem_ctx_persistence@close-replace-race.html * igt@gem_exec_parallel@vcs1-fds: - shard-iclb: [SKIP][49] ([fdo#112080]) -> [PASS][50] +12 similar issues [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-iclb3/igt@gem_exec_parallel@vcs1-fds.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-iclb4/igt@gem_exec_parallel@vcs1-fds.html * {igt@gem_exec_schedule@implicit-both-bsd1}: - shard-iclb: [SKIP][51] ([fdo#109276] / [i915#677]) -> [PASS][52] [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-iclb8/igt@gem_exec_schedule@implicit-both-bsd1.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-iclb4/igt@gem_exec_schedule@implicit-both-bsd1.html * igt@gem_exec_schedule@pi-distinct-iova-bsd: - shard-iclb: [SKIP][53] ([i915#677]) -> [PASS][54] +1 similar issue [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-iclb1/igt@gem_exec_schedule@pi-distinct-iova-bsd.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-iclb8/igt@gem_exec_schedule@pi-distinct-iova-bsd.html * igt@gem_exec_schedule@promotion-bsd1: - shard-iclb: [SKIP][55] ([fdo#109276]) -> [PASS][56] +19 similar issues [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-iclb6/igt@gem_exec_schedule@promotion-bsd1.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-iclb2/igt@gem_exec_schedule@promotion-bsd1.html * igt@gem_exec_schedule@wide-bsd: - shard-iclb: [SKIP][57] ([fdo#112146]) -> [PASS][58] +3 similar issues [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-iclb4/igt@gem_exec_schedule@wide-bsd.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-iclb7/igt@gem_exec_schedule@wide-bsd.html * {igt@gem_exec_whisper@basic-queues-forked}: - shard-apl: [INCOMPLETE][59] ([fdo#103927]) -> [PASS][60] [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-apl6/igt@gem_exec_whisper@basic-queues-forked.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-apl4/igt@gem_exec_whisper@basic-queues-forked.html * igt@gem_userptr_blits@dmabuf-sync: - shard-snb: [DMESG-WARN][61] ([fdo#111870] / [i915#478]) -> [PASS][62] [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-snb5/igt@gem_userptr_blits@dmabuf-sync.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-snb5/igt@gem_userptr_blits@dmabuf-sync.html * igt@i915_pm_dc@dc5-dpms: - shard-iclb: [FAIL][63] ([i915#447]) -> [PASS][64] [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-iclb3/igt@i915_pm_dc@dc5-dpms.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-iclb5/igt@i915_pm_dc@dc5-dpms.html * igt@kms_flip@flip-vs-expired-vblank-interruptible: - shard-glk: [FAIL][65] ([i915#79]) -> [PASS][66] [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-glk7/igt@kms_flip@flip-vs-expired-vblank-interruptible.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-glk6/igt@kms_flip@flip-vs-expired-vblank-interruptible.html * igt@kms_flip@flip-vs-rmfb: - shard-apl: [DMESG-WARN][67] ([i915#1297]) -> [PASS][68] [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-apl3/igt@kms_flip@flip-vs-rmfb.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-apl6/igt@kms_flip@flip-vs-rmfb.html - shard-kbl: [DMESG-WARN][69] ([i915#1297]) -> [PASS][70] [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-kbl1/igt@kms_flip@flip-vs-rmfb.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-kbl3/igt@kms_flip@flip-vs-rmfb.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a: - shard-kbl: [DMESG-WARN][71] ([i915#180]) -> [PASS][72] +5 similar issues [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-kbl6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-kbl6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html * igt@kms_plane_lowres@pipe-a-tiling-y: - shard-glk: [FAIL][73] ([i915#899]) -> [PASS][74] [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-glk9/igt@kms_plane_lowres@pipe-a-tiling-y.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-glk2/igt@kms_plane_lowres@pipe-a-tiling-y.html * igt@kms_psr@psr2_cursor_render: - shard-iclb: [SKIP][75] ([fdo#109441]) -> [PASS][76] +1 similar issue [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-iclb5/igt@kms_psr@psr2_cursor_render.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-iclb2/igt@kms_psr@psr2_cursor_render.html * igt@perf@gen12-unprivileged-single-ctx-counters: - shard-tglb: [SKIP][77] -> [PASS][78] [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-tglb8/igt@perf@gen12-unprivileged-single-ctx-counters.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-tglb7/igt@perf@gen12-unprivileged-single-ctx-counters.html * igt@perf@invalid-open-flags: - shard-tglb: [SKIP][79] ([fdo#112172]) -> [PASS][80] +4 similar issues [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-tglb5/igt@perf@invalid-open-flags.html [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-tglb8/igt@perf@invalid-open-flags.html * igt@perf@missing-sample-flags: - shard-iclb: [SKIP][81] ([i915#276]) -> [PASS][82] +4 similar issues [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-iclb5/igt@perf@missing-sample-flags.html [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-iclb7/igt@perf@missing-sample-flags.html #### Warnings #### * igt@i915_pm_dc@dc6-dpms: - shard-tglb: [FAIL][83] ([i915#454]) -> [SKIP][84] ([i915#468]) [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-tglb8/igt@i915_pm_dc@dc6-dpms.html [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-tglb2/igt@i915_pm_dc@dc6-dpms.html * igt@kms_dp_dsc@basic-dsc-enable-edp: - shard-iclb: [SKIP][85] ([fdo#109349]) -> [DMESG-WARN][86] ([i915#1226]) [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-iclb1/igt@kms_dp_dsc@basic-dsc-enable-edp.html [86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html * igt@perf@gen12-unprivileged-single-ctx-counters: - shard-iclb: [SKIP][87] -> [SKIP][88] ([fdo#109289]) [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-iclb4/igt@perf@gen12-unprivileged-single-ctx-counters.html [88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-iclb1/igt@perf@gen12-unprivileged-single-ctx-counters.html * igt@perf@unprivileged-single-ctx-counters: - shard-iclb: [SKIP][89] ([fdo#109289]) -> [SKIP][90] ([i915#276]) [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-iclb8/igt@perf@unprivileged-single-ctx-counters.html [90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-iclb7/igt@perf@unprivileged-single-ctx-counters.html - shard-tglb: [SKIP][91] ([fdo#109289]) -> [SKIP][92] ([fdo#112172]) [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7983/shard-tglb2/igt@perf@unprivileged-single-ctx-counters.html [92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/shard-tglb3/igt@perf@unprivileged-single-ctx-counters.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665 [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841 [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854 [fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870 [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080 [fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146 [fdo#112172]: https://bugs.freedesktop.org/show_bug.cgi?id=112172 [fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271 [i915#1085]: https://gitlab.freedesktop.org/drm/intel/issues/1085 [i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226 [i915#1291]: https://gitlab.freedesktop.org/drm/intel/issues/1291 [i915#1297]: https://gitlab.freedesktop.org/drm/intel/issues/1297 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#276]: https://gitlab.freedesktop.org/drm/intel/issues/276 [i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31 [i915#413]: https://gitlab.freedesktop.org/drm/intel/issues/413 [i915#447]: https://gitlab.freedesktop.org/drm/intel/issues/447 [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454 [i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468 [i915#478]: https://gitlab.freedesktop.org/drm/intel/issues/478 [i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49 [i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644 [i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 [i915#899]: https://gitlab.freedesktop.org/drm/intel/issues/899 Participating hosts (10 -> 8) ------------------------------ Missing (2): pig-skl-6260u pig-glk-j5005 Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_5458 -> IGTPW_4215 * Piglit: piglit_4509 -> None CI-20190529: 20190529 CI_DRM_7983: 85ccd7de7d75735a667c4133b0927481986a2a1c @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_4215: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/index.html IGT_5458: 5f7e4ae6a91ed2c104593b8abd5b71a6cc96fc10 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4215/index.html _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 10+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] lib/igt_debugfs: Add igt_crc_get_for_frame() (rev3) 2020-02-21 20:50 [igt-dev] [PATCH i-g-t 1/3] lib/igt_debugfs: Add igt_crc_get_for_frame() Ville Syrjala ` (3 preceding siblings ...) 2020-02-24 12:49 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork @ 2020-02-26 21:50 ` Patchwork 2020-02-27 12:01 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 2020-02-27 13:59 ` [igt-dev] [PATCH i-g-t 1/3] lib/igt_debugfs: Add igt_crc_get_for_frame() Juha-Pekka Heikkila 6 siblings, 0 replies; 10+ messages in thread From: Patchwork @ 2020-02-26 21:50 UTC (permalink / raw) To: Ville Syrjala; +Cc: igt-dev == Series Details == Series: series starting with [i-g-t,1/3] lib/igt_debugfs: Add igt_crc_get_for_frame() (rev3) URL : https://patchwork.freedesktop.org/series/73793/ State : success == Summary == CI Bug Log - changes from IGT_5470 -> IGTPW_4230 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/index.html Known issues ------------ Here are the changes found in IGTPW_4230 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_suspend@basic-s4-devices: - fi-tgl-y: [PASS][1] -> [FAIL][2] ([CI#94]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/fi-tgl-y/igt@gem_exec_suspend@basic-s4-devices.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/fi-tgl-y/igt@gem_exec_suspend@basic-s4-devices.html * igt@kms_addfb_basic@addfb25-framebuffer-vs-set-tiling: - fi-tgl-y: [PASS][3] -> [DMESG-WARN][4] ([CI#94] / [i915#402]) +1 similar issue [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/fi-tgl-y/igt@kms_addfb_basic@addfb25-framebuffer-vs-set-tiling.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/fi-tgl-y/igt@kms_addfb_basic@addfb25-framebuffer-vs-set-tiling.html * igt@kms_chamelium@hdmi-hpd-fast: - fi-kbl-7500u: [PASS][5] -> [FAIL][6] ([fdo#111096] / [i915#323]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html #### Possible fixes #### * igt@gem_flink_basic@flink-lifetime: - fi-tgl-y: [DMESG-WARN][7] ([CI#94] / [i915#402]) -> [PASS][8] +1 similar issue [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/fi-tgl-y/igt@gem_flink_basic@flink-lifetime.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/fi-tgl-y/igt@gem_flink_basic@flink-lifetime.html * igt@i915_selftest@live_gem_contexts: - fi-cml-s: [DMESG-FAIL][9] ([i915#877]) -> [PASS][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/fi-cml-s/igt@i915_selftest@live_gem_contexts.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/fi-cml-s/igt@i915_selftest@live_gem_contexts.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [CI#94]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/94 [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096 [i915#1233]: https://gitlab.freedesktop.org/drm/intel/issues/1233 [i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323 [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402 [i915#877]: https://gitlab.freedesktop.org/drm/intel/issues/877 Participating hosts (50 -> 45) ------------------------------ Additional (1): fi-kbl-soraka Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_5470 -> IGTPW_4230 CI-20190529: 20190529 CI_DRM_8008: 13b6e2575f2c05722679bc1c9d0b97c13bde49a1 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_4230: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/index.html IGT_5470: 386b71eb9de6610107bf3cbc523b9a68243c6213 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/index.html _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 10+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/3] lib/igt_debugfs: Add igt_crc_get_for_frame() (rev3) 2020-02-21 20:50 [igt-dev] [PATCH i-g-t 1/3] lib/igt_debugfs: Add igt_crc_get_for_frame() Ville Syrjala ` (4 preceding siblings ...) 2020-02-26 21:50 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] lib/igt_debugfs: Add igt_crc_get_for_frame() (rev3) Patchwork @ 2020-02-27 12:01 ` Patchwork 2020-02-27 13:59 ` [igt-dev] [PATCH i-g-t 1/3] lib/igt_debugfs: Add igt_crc_get_for_frame() Juha-Pekka Heikkila 6 siblings, 0 replies; 10+ messages in thread From: Patchwork @ 2020-02-27 12:01 UTC (permalink / raw) To: Ville Syrjala; +Cc: igt-dev == Series Details == Series: series starting with [i-g-t,1/3] lib/igt_debugfs: Add igt_crc_get_for_frame() (rev3) URL : https://patchwork.freedesktop.org/series/73793/ State : success == Summary == CI Bug Log - changes from IGT_5470_full -> IGTPW_4230_full ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/index.html Known issues ------------ Here are the changes found in IGTPW_4230_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_busy@extended-parallel-vcs1: - shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#112080]) +14 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-iclb4/igt@gem_busy@extended-parallel-vcs1.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-iclb7/igt@gem_busy@extended-parallel-vcs1.html * igt@gem_exec_balancer@smoke: - shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#110854]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-iclb4/igt@gem_exec_balancer@smoke.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-iclb8/igt@gem_exec_balancer@smoke.html * igt@gem_exec_schedule@implicit-both-bsd: - shard-iclb: [PASS][5] -> [SKIP][6] ([i915#677]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-iclb7/igt@gem_exec_schedule@implicit-both-bsd.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-iclb1/igt@gem_exec_schedule@implicit-both-bsd.html * igt@gem_exec_schedule@promotion-bsd1: - shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#109276]) +16 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-iclb2/igt@gem_exec_schedule@promotion-bsd1.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-iclb7/igt@gem_exec_schedule@promotion-bsd1.html * igt@gem_exec_schedule@wide-bsd: - shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#112146]) +5 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-iclb8/igt@gem_exec_schedule@wide-bsd.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-iclb1/igt@gem_exec_schedule@wide-bsd.html * igt@gem_mmap_offset@pf-nonblock: - shard-hsw: [PASS][11] -> [DMESG-WARN][12] ([i915#1330]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-hsw1/igt@gem_mmap_offset@pf-nonblock.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-hsw6/igt@gem_mmap_offset@pf-nonblock.html * igt@gem_partial_pwrite_pread@writes-after-reads-snoop: - shard-hsw: [PASS][13] -> [DMESG-WARN][14] ([fdo#110789] / [i915#478]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-hsw1/igt@gem_partial_pwrite_pread@writes-after-reads-snoop.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-hsw6/igt@gem_partial_pwrite_pread@writes-after-reads-snoop.html * igt@gem_userptr_blits@dmabuf-sync: - shard-snb: [PASS][15] -> [DMESG-WARN][16] ([fdo#111870] / [i915#478]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-snb5/igt@gem_userptr_blits@dmabuf-sync.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-snb2/igt@gem_userptr_blits@dmabuf-sync.html * igt@i915_pm_rpm@gem-evict-pwrite: - shard-tglb: [PASS][17] -> [SKIP][18] ([i915#1316]) +1 similar issue [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-tglb5/igt@i915_pm_rpm@gem-evict-pwrite.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-tglb3/igt@i915_pm_rpm@gem-evict-pwrite.html - shard-glk: [PASS][19] -> [SKIP][20] ([fdo#109271]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-glk9/igt@i915_pm_rpm@gem-evict-pwrite.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-glk8/igt@i915_pm_rpm@gem-evict-pwrite.html * igt@i915_pm_rpm@modeset-lpsp-stress: - shard-iclb: [PASS][21] -> [SKIP][22] ([i915#1316]) +1 similar issue [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-iclb8/igt@i915_pm_rpm@modeset-lpsp-stress.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-iclb3/igt@i915_pm_rpm@modeset-lpsp-stress.html * igt@i915_suspend@fence-restore-tiled2untiled: - shard-apl: [PASS][23] -> [DMESG-WARN][24] ([i915#180]) +2 similar issues [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-apl1/igt@i915_suspend@fence-restore-tiled2untiled.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-apl4/igt@i915_suspend@fence-restore-tiled2untiled.html * igt@kms_cursor_crc@pipe-c-cursor-alpha-opaque: - shard-glk: [PASS][25] -> [FAIL][26] ([i915#54]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-glk5/igt@kms_cursor_crc@pipe-c-cursor-alpha-opaque.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-glk5/igt@kms_cursor_crc@pipe-c-cursor-alpha-opaque.html - shard-apl: [PASS][27] -> [FAIL][28] ([i915#54]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-apl4/igt@kms_cursor_crc@pipe-c-cursor-alpha-opaque.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-apl1/igt@kms_cursor_crc@pipe-c-cursor-alpha-opaque.html - shard-kbl: [PASS][29] -> [FAIL][30] ([i915#54]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-kbl1/igt@kms_cursor_crc@pipe-c-cursor-alpha-opaque.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-kbl4/igt@kms_cursor_crc@pipe-c-cursor-alpha-opaque.html * igt@kms_flip@flip-vs-suspend-interruptible: - shard-kbl: [PASS][31] -> [DMESG-WARN][32] ([i915#180] / [i915#56]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-kbl2/igt@kms_flip@flip-vs-suspend-interruptible.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-kbl7/igt@kms_flip@flip-vs-suspend-interruptible.html * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-pwrite: - shard-glk: [PASS][33] -> [FAIL][34] ([i915#49]) [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-glk1/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-pwrite.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-glk5/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-pwrite.html * igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-cpu: - shard-snb: [PASS][35] -> [DMESG-WARN][36] ([i915#478]) [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-snb4/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-cpu.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-snb6/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-cpu.html * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes: - shard-kbl: [PASS][37] -> [DMESG-WARN][38] ([i915#180]) +2 similar issues [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-kbl2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-kbl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html * igt@kms_plane_lowres@pipe-a-tiling-x: - shard-glk: [PASS][39] -> [FAIL][40] ([i915#899]) [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-glk7/igt@kms_plane_lowres@pipe-a-tiling-x.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-glk8/igt@kms_plane_lowres@pipe-a-tiling-x.html * igt@kms_psr@no_drrs: - shard-iclb: [PASS][41] -> [FAIL][42] ([i915#173]) [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-iclb2/igt@kms_psr@no_drrs.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-iclb1/igt@kms_psr@no_drrs.html * igt@kms_psr@psr2_primary_blt: - shard-iclb: [PASS][43] -> [SKIP][44] ([fdo#109441]) [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-iclb2/igt@kms_psr@psr2_primary_blt.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-iclb7/igt@kms_psr@psr2_primary_blt.html * igt@perf@short-reads: - shard-kbl: [PASS][45] -> [FAIL][46] ([i915#51]) [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-kbl1/igt@perf@short-reads.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-kbl4/igt@perf@short-reads.html * igt@sw_sync@sync_multi_producer_single_consumer: - shard-hsw: [PASS][47] -> [TIMEOUT][48] ([i915#1328]) [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-hsw1/igt@sw_sync@sync_multi_producer_single_consumer.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-hsw7/igt@sw_sync@sync_multi_producer_single_consumer.html - shard-iclb: [PASS][49] -> [TIMEOUT][50] ([i915#1328]) [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-iclb8/igt@sw_sync@sync_multi_producer_single_consumer.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-iclb5/igt@sw_sync@sync_multi_producer_single_consumer.html #### Possible fixes #### * igt@gem_busy@close-race: - shard-hsw: [INCOMPLETE][51] ([CI#80] / [i915#61] / [i915#977]) -> [PASS][52] [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-hsw7/igt@gem_busy@close-race.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-hsw7/igt@gem_busy@close-race.html * igt@gem_ctx_isolation@rcs0-s3: - shard-kbl: [DMESG-WARN][53] ([i915#180]) -> [PASS][54] +5 similar issues [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-kbl6/igt@gem_ctx_isolation@rcs0-s3.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-kbl6/igt@gem_ctx_isolation@rcs0-s3.html * {igt@gem_ctx_ringsize@active@bcs0}: - shard-glk: [INCOMPLETE][55] ([i915#58] / [k.org#198133]) -> [PASS][56] [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-glk9/igt@gem_ctx_ringsize@active@bcs0.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-glk1/igt@gem_ctx_ringsize@active@bcs0.html * {igt@gem_ctx_ringsize@active@vecs0}: - shard-tglb: [INCOMPLETE][57] -> [PASS][58] [57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-tglb1/igt@gem_ctx_ringsize@active@vecs0.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-tglb1/igt@gem_ctx_ringsize@active@vecs0.html * igt@gem_ctx_shared@exec-single-timeline-bsd: - shard-iclb: [SKIP][59] ([fdo#110841]) -> [PASS][60] [59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-iclb1/igt@gem_ctx_shared@exec-single-timeline-bsd.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-iclb7/igt@gem_ctx_shared@exec-single-timeline-bsd.html * igt@gem_exec_parallel@vcs1-fds: - shard-iclb: [SKIP][61] ([fdo#112080]) -> [PASS][62] +11 similar issues [61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-iclb3/igt@gem_exec_parallel@vcs1-fds.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-iclb1/igt@gem_exec_parallel@vcs1-fds.html * igt@gem_exec_schedule@implicit-read-write-bsd: - shard-iclb: [SKIP][63] ([i915#677]) -> [PASS][64] +1 similar issue [63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-iclb2/igt@gem_exec_schedule@implicit-read-write-bsd.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-iclb3/igt@gem_exec_schedule@implicit-read-write-bsd.html * igt@gem_exec_schedule@implicit-read-write-bsd1: - shard-iclb: [SKIP][65] ([fdo#109276] / [i915#677]) -> [PASS][66] [65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-iclb7/igt@gem_exec_schedule@implicit-read-write-bsd1.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-iclb4/igt@gem_exec_schedule@implicit-read-write-bsd1.html * igt@gem_exec_schedule@pi-common-bsd1: - shard-iclb: [SKIP][67] ([fdo#109276]) -> [PASS][68] +14 similar issues [67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-iclb6/igt@gem_exec_schedule@pi-common-bsd1.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-iclb2/igt@gem_exec_schedule@pi-common-bsd1.html * igt@gem_exec_schedule@preempt-queue-bsd: - shard-iclb: [SKIP][69] ([fdo#112146]) -> [PASS][70] +1 similar issue [69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-iclb4/igt@gem_exec_schedule@preempt-queue-bsd.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-iclb5/igt@gem_exec_schedule@preempt-queue-bsd.html * igt@gem_ppgtt@flink-and-close-vma-leak: - shard-glk: [FAIL][71] ([i915#644]) -> [PASS][72] [71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-glk2/igt@gem_ppgtt@flink-and-close-vma-leak.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-glk4/igt@gem_ppgtt@flink-and-close-vma-leak.html * igt@gem_userptr_blits@dmabuf-unsync: - shard-hsw: [DMESG-WARN][73] ([fdo#111870]) -> [PASS][74] [73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-hsw1/igt@gem_userptr_blits@dmabuf-unsync.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-hsw6/igt@gem_userptr_blits@dmabuf-unsync.html - shard-snb: [DMESG-WARN][75] ([fdo#111870] / [i915#478]) -> [PASS][76] [75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-snb5/igt@gem_userptr_blits@dmabuf-unsync.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-snb6/igt@gem_userptr_blits@dmabuf-unsync.html * igt@i915_pm_rpm@gem-execbuf-stress: - shard-glk: [SKIP][77] ([fdo#109271]) -> [PASS][78] [77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-glk3/igt@i915_pm_rpm@gem-execbuf-stress.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-glk7/igt@i915_pm_rpm@gem-execbuf-stress.html - shard-tglb: [SKIP][79] ([i915#1316]) -> [PASS][80] [79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-tglb1/igt@i915_pm_rpm@gem-execbuf-stress.html [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-tglb5/igt@i915_pm_rpm@gem-execbuf-stress.html - shard-hsw: [SKIP][81] ([fdo#109271]) -> [PASS][82] [81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-hsw1/igt@i915_pm_rpm@gem-execbuf-stress.html [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-hsw7/igt@i915_pm_rpm@gem-execbuf-stress.html - shard-iclb: [SKIP][83] ([i915#1316]) -> [PASS][84] [83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-iclb2/igt@i915_pm_rpm@gem-execbuf-stress.html [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-iclb7/igt@i915_pm_rpm@gem-execbuf-stress.html * igt@i915_pm_rps@waitboost: - shard-iclb: [FAIL][85] ([i915#413]) -> [PASS][86] [85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-iclb4/igt@i915_pm_rps@waitboost.html [86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-iclb6/igt@i915_pm_rps@waitboost.html * igt@kms_cursor_crc@pipe-b-cursor-suspend: - shard-iclb: [INCOMPLETE][87] ([i915#1237]) -> [PASS][88] [87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-iclb3/igt@kms_cursor_crc@pipe-b-cursor-suspend.html [88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-iclb2/igt@kms_cursor_crc@pipe-b-cursor-suspend.html * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic: - shard-glk: [FAIL][89] ([i915#72]) -> [PASS][90] [89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-glk1/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html [90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-glk6/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html * igt@kms_flip@2x-flip-vs-expired-vblank: - shard-glk: [INCOMPLETE][91] ([CI#80] / [i915#58] / [k.org#198133]) -> [PASS][92] [91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-glk3/igt@kms_flip@2x-flip-vs-expired-vblank.html [92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-glk3/igt@kms_flip@2x-flip-vs-expired-vblank.html * igt@kms_flip@plain-flip-fb-recreate: - shard-glk: [FAIL][93] ([i915#34]) -> [PASS][94] [93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-glk6/igt@kms_flip@plain-flip-fb-recreate.html [94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-glk3/igt@kms_flip@plain-flip-fb-recreate.html * igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-wc: - shard-snb: [DMESG-WARN][95] ([i915#478]) -> [PASS][96] [95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-snb5/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-wc.html [96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-snb2/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-wc.html * igt@kms_plane_lowres@pipe-a-tiling-y: - shard-glk: [FAIL][97] ([i915#899]) -> [PASS][98] [97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-glk3/igt@kms_plane_lowres@pipe-a-tiling-y.html [98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-glk4/igt@kms_plane_lowres@pipe-a-tiling-y.html * igt@kms_properties@plane-properties-atomic: - shard-snb: [SKIP][99] ([fdo#109271]) -> [PASS][100] +4 similar issues [99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-snb2/igt@kms_properties@plane-properties-atomic.html [100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-snb2/igt@kms_properties@plane-properties-atomic.html * igt@kms_psr@psr2_no_drrs: - shard-iclb: [SKIP][101] ([fdo#109441]) -> [PASS][102] +1 similar issue [101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-iclb3/igt@kms_psr@psr2_no_drrs.html [102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-iclb2/igt@kms_psr@psr2_no_drrs.html * igt@perf@short-reads: - shard-apl: [FAIL][103] ([i915#51]) -> [PASS][104] [103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-apl8/igt@perf@short-reads.html [104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-apl1/igt@perf@short-reads.html #### Warnings #### * igt@gem_userptr_blits@sync-unmap-cycles: - shard-snb: [DMESG-WARN][105] ([fdo#110789] / [fdo#111870] / [i915#478]) -> [DMESG-WARN][106] ([fdo#111870] / [i915#478]) [105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-snb2/igt@gem_userptr_blits@sync-unmap-cycles.html [106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-snb4/igt@gem_userptr_blits@sync-unmap-cycles.html - shard-hsw: [DMESG-WARN][107] ([fdo#110789] / [fdo#111870]) -> [DMESG-WARN][108] ([fdo#111870]) [107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-hsw1/igt@gem_userptr_blits@sync-unmap-cycles.html [108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-hsw5/igt@gem_userptr_blits@sync-unmap-cycles.html * igt@i915_pm_rpm@gem-mmap-type: - shard-snb: [INCOMPLETE][109] ([i915#82]) -> [SKIP][110] ([fdo#109271]) [109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5470/shard-snb6/igt@i915_pm_rpm@gem-mmap-type.html [110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/shard-snb2/igt@i915_pm_rpm@gem-mmap-type.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [CI#80]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/80 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789 [fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841 [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854 [fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870 [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080 [fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146 [i915#1237]: https://gitlab.freedesktop.org/drm/intel/issues/1237 [i915#1316]: https://gitlab.freedesktop.org/drm/intel/issues/1316 [i915#1328]: https://gitlab.freedesktop.org/drm/intel/issues/1328 [i915#1330]: https://gitlab.freedesktop.org/drm/intel/issues/1330 [i915#173]: https://gitlab.freedesktop.org/drm/intel/issues/173 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#34]: https://gitlab.freedesktop.org/drm/intel/issues/34 [i915#413]: https://gitlab.freedesktop.org/drm/intel/issues/413 [i915#478]: https://gitlab.freedesktop.org/drm/intel/issues/478 [i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49 [i915#51]: https://gitlab.freedesktop.org/drm/intel/issues/51 [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54 [i915#56]: https://gitlab.freedesktop.org/drm/intel/issues/56 [i915#58]: https://gitlab.freedesktop.org/drm/intel/issues/58 [i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61 [i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644 [i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677 [i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72 [i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82 [i915#899]: https://gitlab.freedesktop.org/drm/intel/issues/899 [i915#977]: https://gitlab.freedesktop.org/drm/intel/issues/977 [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133 Participating hosts (8 -> 8) ------------------------------ No changes in participating hosts Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_5470 -> IGTPW_4230 CI-20190529: 20190529 CI_DRM_8008: 13b6e2575f2c05722679bc1c9d0b97c13bde49a1 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_4230: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/index.html IGT_5470: 386b71eb9de6610107bf3cbc523b9a68243c6213 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4230/index.html _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/3] lib/igt_debugfs: Add igt_crc_get_for_frame() 2020-02-21 20:50 [igt-dev] [PATCH i-g-t 1/3] lib/igt_debugfs: Add igt_crc_get_for_frame() Ville Syrjala ` (5 preceding siblings ...) 2020-02-27 12:01 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork @ 2020-02-27 13:59 ` Juha-Pekka Heikkila 6 siblings, 0 replies; 10+ messages in thread From: Juha-Pekka Heikkila @ 2020-02-27 13:59 UTC (permalink / raw) To: Ville Syrjala, igt-dev Series including v2 patches look ok Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> On 21.2.2020 22.50, Ville Syrjala wrote: > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > Add a new helper to return the crc for a specific frame. > Useful when we pipeline flips and crc captures more deeply > to eliminate dead time between the flips. > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > --- > lib/igt_debugfs.c | 31 ++++++++++++++++++++++++------- > lib/igt_debugfs.h | 2 ++ > 2 files changed, 26 insertions(+), 7 deletions(-) > > diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c > index 8cac9d1e148e..bf6be552057a 100644 > --- a/lib/igt_debugfs.c > +++ b/lib/igt_debugfs.c > @@ -945,17 +945,16 @@ void igt_pipe_crc_get_single(igt_pipe_crc_t *pipe_crc, igt_crc_t *crc) > * igt_pipe_crc_get_current: > * @drm_fd: Pointer to drm fd for vblank counter > * @pipe_crc: pipe CRC object > + * @vblank: frame counter value we're looking for > * @crc: buffer pointer for the captured CRC value > * > - * Same as igt_pipe_crc_get_single(), but will wait until a new CRC can be captured. > - * This is useful for retrieving the current CRC in a more race free way than > - * igt_pipe_crc_drain() + igt_pipe_crc_get_single(). > + * Same as igt_pipe_crc_get_single(), but will wait until a CRC has been captured > + * for frame @vblank. > */ > void > -igt_pipe_crc_get_current(int drm_fd, igt_pipe_crc_t *pipe_crc, igt_crc_t *crc) > +igt_pipe_crc_get_for_frame(int drm_fd, igt_pipe_crc_t *pipe_crc, > + unsigned int vblank, igt_crc_t *crc) > { > - unsigned vblank = kmstest_get_vblank(drm_fd, pipe_crc->pipe, 0); > - > do { > read_one_crc(pipe_crc, crc); > > @@ -965,11 +964,29 @@ igt_pipe_crc_get_current(int drm_fd, igt_pipe_crc_t *pipe_crc, igt_crc_t *crc) > igt_pipe_crc_get_single(pipe_crc, crc); > return; > } > - } while (igt_vblank_before_eq(crc->frame, vblank)); > + } while (igt_vblank_before(crc->frame, vblank)); > > crc_sanity_checks(pipe_crc, crc); > } > > +/** > + * igt_pipe_crc_get_current: > + * @drm_fd: Pointer to drm fd for vblank counter > + * @pipe_crc: pipe CRC object > + * @crc: buffer pointer for the captured CRC value > + * > + * Same as igt_pipe_crc_get_single(), but will wait until a new CRC can be captured. > + * This is useful for retrieving the current CRC in a more race free way than > + * igt_pipe_crc_drain() + igt_pipe_crc_get_single(). > + */ > +void > +igt_pipe_crc_get_current(int drm_fd, igt_pipe_crc_t *pipe_crc, igt_crc_t *crc) > +{ > + unsigned vblank = kmstest_get_vblank(drm_fd, pipe_crc->pipe, 0) + 1; > + > + return igt_pipe_crc_get_for_frame(drm_fd, pipe_crc, vblank, crc); > +} > + > /** > * igt_pipe_crc_collect_crc: > * @pipe_crc: pipe CRC object > diff --git a/lib/igt_debugfs.h b/lib/igt_debugfs.h > index 1e0cc108d6fb..7d1a6175ed64 100644 > --- a/lib/igt_debugfs.h > +++ b/lib/igt_debugfs.h > @@ -104,6 +104,8 @@ int igt_pipe_crc_get_crcs(igt_pipe_crc_t *pipe_crc, int n_crcs, > void igt_pipe_crc_drain(igt_pipe_crc_t *pipe_crc); > void igt_pipe_crc_get_single(igt_pipe_crc_t *pipe_crc, igt_crc_t *out_crc); > void igt_pipe_crc_get_current(int drm_fd, igt_pipe_crc_t *pipe_crc, igt_crc_t *crc); > +void igt_pipe_crc_get_for_frame(int drm_fd, igt_pipe_crc_t *pipe_crc, > + unsigned int vblank, igt_crc_t *crc); > > void igt_pipe_crc_collect_crc(igt_pipe_crc_t *pipe_crc, igt_crc_t *out_crc); > > _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-02-27 14:00 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-02-21 20:50 [igt-dev] [PATCH i-g-t 1/3] lib/igt_debugfs: Add igt_crc_get_for_frame() Ville Syrjala 2020-02-21 20:50 ` [igt-dev] [PATCH i-g-t 2/3] tests/kms_plane: Pipeline crc capture and flips Ville Syrjala 2020-02-26 20:51 ` [igt-dev] [PATCH i-g-t v2 " Ville Syrjala 2020-02-21 20:50 ` [igt-dev] [PATCH i-g-t 3/3] tests/kms_plane: Use non-blocking commits for pixel format tests Ville Syrjala 2020-02-26 20:52 ` [igt-dev] [PATCH i-g-t v2 " Ville Syrjala 2020-02-21 21:21 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] lib/igt_debugfs: Add igt_crc_get_for_frame() Patchwork 2020-02-24 12:49 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 2020-02-26 21:50 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] lib/igt_debugfs: Add igt_crc_get_for_frame() (rev3) Patchwork 2020-02-27 12:01 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 2020-02-27 13:59 ` [igt-dev] [PATCH i-g-t 1/3] lib/igt_debugfs: Add igt_crc_get_for_frame() Juha-Pekka Heikkila
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox