From: Petri Latvala <petri.latvala@intel.com>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: IGT development <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t v3] ts/core_setmaster: new test for drop/set master semantics
Date: Mon, 9 Mar 2020 13:01:05 +0200 [thread overview]
Message-ID: <20200309110105.GZ3839@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <CACvgo523NjixBgqZL9naqmga4XtxRkSRUB8rukL9wfVWePwETg@mail.gmail.com>
On Fri, Mar 06, 2020 at 04:32:19PM +0000, Emil Velikov wrote:
> On Fri, 6 Mar 2020 at 14:28, Petri Latvala <petri.latvala@intel.com> wrote:
>
> > It is _extremely_ likely that we (i915 CI) could sometimes run
> > igt@i915_module_load@reload right before this test. Or
> > igt@i915_selftest@live. When we do, there's no /dev/dri/card0 at the
> > time of chmodding but is at the time of __drm_open_driver().
> >
> If I understand you correctly, if a test which does rmmod/modprobe
> fails, the CI will still continue to run other tests.
It's worse than that. All subtests of i915_module_load except @reload
leave the module unloaded also on _success_. i915_selftest likewise
leaves the module unloaded. If they loaded the module back on success,
running module loading tests back-to-back would do an additional
module reload roundtrip.
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-03-09 11:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 17:33 [igt-dev] [PATCH i-g-t v3] ts/core_setmaster: new test for drop/set master semantics Emil Velikov
2020-03-02 18:52 ` [igt-dev] ✓ Fi.CI.BAT: success for ts/core_setmaster: new test for drop/set master semantics (rev3) Patchwork
2020-03-03 8:03 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2020-03-03 13:13 ` [igt-dev] [PATCH i-g-t v3] ts/core_setmaster: new test for drop/set master semantics Petri Latvala
2020-03-03 14:46 ` Emil Velikov
2020-03-04 11:25 ` Petri Latvala
2020-03-04 13:26 ` Emil Velikov
2020-03-04 14:17 ` Petri Latvala
2020-03-06 14:17 ` Emil Velikov
2020-03-06 14:28 ` Petri Latvala
2020-03-06 16:32 ` Emil Velikov
2020-03-09 11:01 ` Petri Latvala [this message]
2020-03-09 13:53 ` Emil Velikov
2020-03-03 13:13 ` Petri Latvala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200309110105.GZ3839@platvala-desk.ger.corp.intel.com \
--to=petri.latvala@intel.com \
--cc=emil.l.velikov@gmail.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox