public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "José Roberto de Souza" <jose.souza@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH v2 3/4] tests/kms_frontbuffer_tracking: Enable positive test on linear tiling
Date: Tue, 10 Mar 2020 17:42:34 -0700	[thread overview]
Message-ID: <20200311004235.138072-3-jose.souza@intel.com> (raw)
In-Reply-To: <20200311004235.138072-1-jose.souza@intel.com>

i915 is making fences not mandatory to enable FBC in newer platforms.
As BSpec do not have restrictions against tiling formats to enable
FBC it will be possible to enable FBC with linear tiling, so lets test
it.

v2:
- changed from GEN11 to GEN9 following kernel patches

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 tests/kms_frontbuffer_tracking.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
index 12ba9bba..76bd22e6 100644
--- a/tests/kms_frontbuffer_tracking.c
+++ b/tests/kms_frontbuffer_tracking.c
@@ -2172,11 +2172,15 @@ static void format_draw_subtest(const struct test_mode *t)
 
 static bool tiling_is_valid(int feature_flags, enum tiling_type tiling)
 {
+	int devid = intel_get_drm_devid(drm.fd);
+
 	if (!(feature_flags & FEATURE_FBC))
 		return true;
 
 	switch (tiling) {
 	case TILING_LINEAR:
+		if (AT_LEAST_GEN(devid, 9))
+			return true;
 		return false;
 	case TILING_X:
 	case TILING_Y:
-- 
2.25.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2020-03-11  0:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-11  0:42 [igt-dev] [PATCH v2 1/4] tests/kms_frontbuffer_tracking: Add tiling to test_mode José Roberto de Souza
2020-03-11  0:42 ` [igt-dev] [PATCH v2 2/4] tests/kms_frontbuffer_tracking: Improve tiling test coverage José Roberto de Souza
2020-03-11  0:42 ` José Roberto de Souza [this message]
2020-03-11  7:30   ` [igt-dev] [PATCH v2 3/4] tests/kms_frontbuffer_tracking: Enable positive test on linear tiling Petri Latvala
2020-03-11 16:57     ` Souza, Jose
2020-03-11  0:42 ` [igt-dev] [PATCH v2 4/4] DO_NOT_MERGE: Revert "tests/kms_frontbuffer_tracking: Enable positive test on linear tiling" José Roberto de Souza
2020-03-11  5:34 ` [igt-dev] ✗ GitLab.Pipeline: failure for series starting with [v2,1/4] tests/kms_frontbuffer_tracking: Add tiling to test_mode Patchwork
2020-03-11 17:26   ` Souza, Jose
2020-03-11  9:23 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2020-03-11 21:20 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200311004235.138072-3-jose.souza@intel.com \
    --to=jose.souza@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox