Re: [igt-dev] [PATCH v2 3/4] tests/kms_frontbuffer_tracking: Enable positive test on linear tiling

["Souza, Jose" <jose.souza@intel.com>]

On Wed, 2020-03-11 at 09:30 +0200, Petri Latvala wrote:
> On Tue, Mar 10, 2020 at 05:42:34PM -0700, José Roberto de Souza
> wrote:
> > i915 is making fences not mandatory to enable FBC in newer
> > platforms.
> > As BSpec do not have restrictions against tiling formats to enable
> > FBC it will be possible to enable FBC with linear tiling, so lets
> > test
> > it.
> > 
> > v2:
> > - changed from GEN11 to GEN9 following kernel patches
> > 
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > ---
> >  tests/kms_frontbuffer_tracking.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/tests/kms_frontbuffer_tracking.c
> > b/tests/kms_frontbuffer_tracking.c
> > index 12ba9bba..76bd22e6 100644
> > --- a/tests/kms_frontbuffer_tracking.c
> > +++ b/tests/kms_frontbuffer_tracking.c
> > @@ -2172,11 +2172,15 @@ static void format_draw_subtest(const
> > struct test_mode *t)
> >  
> >  static bool tiling_is_valid(int feature_flags, enum tiling_type
> > tiling)
> >  {
> > +	int devid = intel_get_drm_devid(drm.fd);
> > +
> >  	if (!(feature_flags & FEATURE_FBC))
> >  		return true;
> >  
> >  	switch (tiling) {
> >  	case TILING_LINEAR:
> > +		if (AT_LEAST_GEN(devid, 9))
> > +			return true;
> >  		return false;
> 
> return AT_LEAST_GEN(devid, 9);
> 
> ?
> 

Yeah, sounds better.
Will do this change

> 
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev