public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t 1/5] tests/kms_tiled_display: Get rid of DP stuff
@ 2020-03-13 16:11 Ville Syrjala
  2020-03-13 16:11 ` [igt-dev] [PATCH i-g-t 2/5] tests/kms_tiled_display: Replace the igt_display pointer with a struct Ville Syrjala
                   ` (5 more replies)
  0 siblings, 6 replies; 8+ messages in thread
From: Ville Syrjala @ 2020-03-13 16:11 UTC (permalink / raw)
  To: igt-dev; +Cc: Madhumitha Tolakanahalli Pradeep

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

There is nothing DP specific about the tile property. So
remove any mention of DP (and port sync which is an i915
hardware feature). Let's just talk about genlocked CRTCs
and tiled connectors, which is pretty generic.

Cc: Madhumitha Tolakanahalli Pradeep <madhumitha.tolakanahalli.pradeep@intel.com>
Cc: Manasi Navare <manasi.d.navare@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
---
 tests/Makefile.sources                              |  2 +-
 .../{kms_dp_tiled_display.c => kms_tiled_display.c} | 13 +++----------
 tests/meson.build                                   |  2 +-
 3 files changed, 5 insertions(+), 12 deletions(-)
 rename tests/{kms_dp_tiled_display.c => kms_tiled_display.c} (96%)

diff --git a/tests/Makefile.sources b/tests/Makefile.sources
index 4ac6e35cae37..67445ca21177 100644
--- a/tests/Makefile.sources
+++ b/tests/Makefile.sources
@@ -44,7 +44,6 @@ TESTS_progs = \
 	kms_cursor_legacy \
 	kms_dp_aux_dev \
 	kms_dp_dsc \
-	kms_dp_tiled_display \
 	kms_draw_crc \
 	kms_fbcon_fbt \
 	kms_fence_pin_leak \
@@ -81,6 +80,7 @@ TESTS_progs = \
 	kms_sequence \
 	kms_setmode \
 	kms_sysfs_edid_timing \
+	kms_tiled_display \
 	kms_tv_load_detect \
 	kms_universal_plane \
 	kms_vblank \
diff --git a/tests/kms_dp_tiled_display.c b/tests/kms_tiled_display.c
similarity index 96%
rename from tests/kms_dp_tiled_display.c
rename to tests/kms_tiled_display.c
index b1160fee3b0e..f01152f86395 100644
--- a/tests/kms_dp_tiled_display.c
+++ b/tests/kms_tiled_display.c
@@ -25,7 +25,7 @@
  *      <madhumitha.tolakanahalli.pradeep@intel.com>
  *  Manasi Navare <manasi.d.navare@intel.com>
  *
- * Display Port Tiled Display Test
+ * Tiled display genlocked CRTC test
  * This test parses the tile information of the connectors that have TILE
  * property set, sets up the framebuffer with correct offsets corresponding to
  * the tile offsets and does an atomic modeset with two CRTCs for two
@@ -41,7 +41,7 @@
 #include "drm_mode.h"
 #include "drm_fourcc.h"
 
-IGT_TEST_DESCRIPTION("Test for Transcoder Port Sync for Display Port Tiled Displays");
+IGT_TEST_DESCRIPTION("Test for genlocked CRTCs with tiled displays");
 
 typedef struct {
 	igt_output_t *output;
@@ -113,8 +113,7 @@ static void get_number_of_h_tiles(data_t *data)
 						       res->connectors[i]);
 		igt_assert(connector);
 
-		if (connector->connection == DRM_MODE_CONNECTED &&
-		    connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort) {
+		if (connector->connection == DRM_MODE_CONNECTED) {
 			get_connector_tile_props(data, connector, &tile);
 
 			data->num_h_tiles = tile.num_h_tile;
@@ -138,12 +137,6 @@ static void get_connectors(data_t *data)
 
 		igt_assert(conns[count].connector);
 
-		if (conns[count].connector->connector_type !=
-		    DRM_MODE_CONNECTOR_DisplayPort) {
-			drmModeFreeConnector(conns[count].connector);
-			continue;
-		}
-
 		get_connector_tile_props(data, conns[count].connector,
 					 &conns[count].tile);
 
diff --git a/tests/meson.build b/tests/meson.build
index 9280eb3d867d..4c3f5b5c91aa 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -28,7 +28,6 @@ test_progs = [
 	'kms_cursor_legacy',
 	'kms_dp_aux_dev',
 	'kms_dp_dsc',
-	'kms_dp_tiled_display',
 	'kms_draw_crc',
 	'kms_fbcon_fbt',
 	'kms_fence_pin_leak',
@@ -65,6 +64,7 @@ test_progs = [
 	'kms_sequence',
 	'kms_setmode',
 	'kms_sysfs_edid_timing',
+	'kms_tiled_display',
 	'kms_tv_load_detect',
 	'kms_universal_plane',
 	'kms_vblank',
-- 
2.24.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [igt-dev] [PATCH i-g-t 0/5] kms: Run tiled display tests on any set of connectors
@ 2021-10-19 20:19 Ville Syrjala
  2021-10-19 20:19 ` [igt-dev] [PATCH i-g-t 2/5] tests/kms_tiled_display: Replace the igt_display pointer with a struct Ville Syrjala
  0 siblings, 1 reply; 8+ messages in thread
From: Ville Syrjala @ 2021-10-19 20:19 UTC (permalink / raw)
  To: igt-dev

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reposting of the old "let's test port sync everywhere" thing.

Since this was last posted we seem to have gained a chamelium
variant of the same thing. But it requires chamelium for some reason,
so not genrally very useful. Also it seems to use a fixed override
EDID so it's not going to be useful for any kind of visual tests since
likely you won't get a picture on your screens. The stuff I'm adding
here allows one to slap on the tile blocks to the existing displays
so as long as you have a battery of mostly identical displays hooked
up you can run them in sync with the fake tile info.

There were a few oddball things now in igt_edid on account of the
two approaches, but I didn't bother refactoring the chamelium stuff
at this time.

The reason I remembered this is that we seem to have some odd
transcoder readout failures in CI, and so far the one common thing
I've noticed across all of them is port sync seemingly being enabled.
So far can't explain what is going on, so I'd like to give CI a bit
more ammunition to trip that stuff up.

Ville Syrjälä (5):
  tests/kms_tiled_display: Get rid of DP stuff
  tests/kms_tiled_display: Replace the igt_display pointer with a struct
  tests/kms_tiled_display: Limit the difference in the timestamps to one
    scanline
  lib/edid: Add support for making DisplayID tile blocks
  tests/kms_tiled_display: Override the EDID to fake some tiles

 lib/igt_edid.c                                |  76 +++++++
 lib/igt_edid.h                                |  49 +++++
 ...dp_tiled_display.c => kms_tiled_display.c} | 203 ++++++++++++++----
 tests/meson.build                             |   2 +-
 4 files changed, 292 insertions(+), 38 deletions(-)
 rename tests/{kms_dp_tiled_display.c => kms_tiled_display.c} (71%)

-- 
2.32.0

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-10-19 20:19 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-13 16:11 [igt-dev] [PATCH i-g-t 1/5] tests/kms_tiled_display: Get rid of DP stuff Ville Syrjala
2020-03-13 16:11 ` [igt-dev] [PATCH i-g-t 2/5] tests/kms_tiled_display: Replace the igt_display pointer with a struct Ville Syrjala
2020-03-13 16:11 ` [igt-dev] [PATCH i-g-t 3/5] tests/kms_tiled_display: Limit the difference in the timestamps to one scanline Ville Syrjala
2020-03-13 16:11 ` [igt-dev] [PATCH i-g-t 4/5] lib/edid: Add support for making DisplayID tile blocks Ville Syrjala
2020-03-13 16:11 ` [igt-dev] [PATCH i-g-t 5/5] tests/kms_tiled_display: Override the EDID to fake some tiles Ville Syrjala
2020-03-13 17:11 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/5] tests/kms_tiled_display: Get rid of DP stuff Patchwork
2020-03-13 23:10 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2021-10-19 20:19 [igt-dev] [PATCH i-g-t 0/5] kms: Run tiled display tests on any set of connectors Ville Syrjala
2021-10-19 20:19 ` [igt-dev] [PATCH i-g-t 2/5] tests/kms_tiled_display: Replace the igt_display pointer with a struct Ville Syrjala

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox