From: Anshuman Gupta <anshuman.gupta@intel.com>
To: "Peres, Martin" <martin.peres@intel.com>
Cc: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t v2 4/5] tests/i915_pm_lpsp: screens-disabled subtest use igt_wait
Date: Mon, 23 Mar 2020 15:07:20 +0530 [thread overview]
Message-ID: <20200323093719.GA7154@intel.com> (raw)
In-Reply-To: <140df64efa22434ea6c4e349ccd2bf71@intel.com>
On 2020-03-23 at 12:35:29 +0530, Peres, Martin wrote:
> On 2020-03-23 08:32, Anshuman Gupta wrote:
> > Some times delayed audio codec disabling causes failure
> > of test, using igt_wait to check lpsp after disabling all outputs.
>
> Seems like this answers my question on patch 2/5: We are sending audio
> to the screen even when we do not have anything to send...
>
> I know there are some screens that take ages to re-enable sound after
> not getting any for a while, but waiting 10 or even 30s without sound
> before disabling it does not sound like a terrible idea. My TV
> automatically disables sound after way less than that anyway.
>
> So, to me, this is a driver bug.
>
> That being said, the patch is fine even if your reason for it is not
> acceptable.
Thanks Martin for comment, i will drop this patch, remove the
unloading of sound moudles from 2/5 patch, and will send an update.
Thanks,
Anshuman Gupta,
>
> Martin
> >
> > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> > ---
> > tests/i915/i915_pm_lpsp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/i915/i915_pm_lpsp.c b/tests/i915/i915_pm_lpsp.c
> > index 0ce694e6..5f15c034 100644
> > --- a/tests/i915/i915_pm_lpsp.c
> > +++ b/tests/i915/i915_pm_lpsp.c
> > @@ -91,7 +91,7 @@ static void screens_disabled_subtest(data_t *data)
> > igt_display_commit(&data->display);
> > }
> >
> > - igt_assert(lpsp_is_enabled(data));
> > + igt_assert(igt_wait(lpsp_is_enabled(data), 1000, 100));
> > }
> >
> > static void check_output_lpsp(data_t *data)
> >
>
> pub 2048R/33A53379 2019-12-02 Martin Peres <martin.peres@linux.intel.com>
> sub 2048R/C5E7DE5F 2019-12-02 [expires: 2020-12-01]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-03-23 9:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 6:32 [igt-dev] [PATCH i-g-t v2 0/5] lpsp platform agnostic support Anshuman Gupta
2020-03-23 6:32 ` [igt-dev] [PATCH i-g-t v2 1/5] lib/igt_pm: Add lib func to get lpsp capability Anshuman Gupta
2020-03-23 6:55 ` Peres, Martin
2020-03-24 6:05 ` Anshuman Gupta
2020-03-23 6:32 ` [igt-dev] [PATCH i-g-t v2 2/5] tests/i915_pm_lpsp: lpsp platform agnostic support Anshuman Gupta
2020-03-23 7:00 ` Peres, Martin
2020-03-23 7:46 ` Anshuman Gupta
2020-03-23 8:04 ` Peres, Martin
2020-03-23 12:48 ` Kai Vehmanen
2020-03-23 15:33 ` Anshuman Gupta
2020-03-23 6:32 ` [igt-dev] [PATCH i-g-t v2 3/5] tests/i915_pm_lpsp: Skip panel-fitter subtest for 1024x768 panels Anshuman Gupta
2020-03-23 7:00 ` Peres, Martin
2020-03-23 6:32 ` [igt-dev] [PATCH i-g-t v2 4/5] tests/i915_pm_lpsp: screens-disabled subtest use igt_wait Anshuman Gupta
2020-03-23 7:05 ` Peres, Martin
2020-03-23 9:37 ` Anshuman Gupta [this message]
2020-03-23 6:32 ` [igt-dev] [PATCH i-g-t v2 5/5] tests/i915_pm_rpm: lpsp/non-lpsp screen mode_set_data Anshuman Gupta
2020-03-23 7:10 ` Peres, Martin
2020-03-23 7:27 ` [igt-dev] ✗ Fi.CI.BAT: failure for lpsp platform agnostic support (rev3) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200323093719.GA7154@intel.com \
--to=anshuman.gupta@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=martin.peres@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox