public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Peres, Martin" <martin.peres@intel.com>
To: "Gupta, Anshuman" <anshuman.gupta@intel.com>,
	"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Cc: "Peres, Martin" <martin.peres@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t v2 1/5] lib/igt_pm: Add lib func to get lpsp capability
Date: Mon, 23 Mar 2020 06:55:25 +0000	[thread overview]
Message-ID: <ed6f16b6a7384617b0214849ce0c6ed3@intel.com> (raw)
In-Reply-To: 20200323063248.5261-2-anshuman.gupta@intel.com

[-- Attachment #1: Type: text/plain, Size: 2118 bytes --]

On 2020-03-23 08:32, Anshuman Gupta wrote:
> This lib function evaluate the lpsp capability from
> the connector specific debugfs attribute i915_lpsp_info.
> 
> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> ---
>  lib/igt_pm.c | 27 +++++++++++++++++++++++++++
>  lib/igt_pm.h |  1 +
>  2 files changed, 28 insertions(+)
> 
> diff --git a/lib/igt_pm.c b/lib/igt_pm.c
> index 9d441e1b..7a6cab7c 100644
> --- a/lib/igt_pm.c
> +++ b/lib/igt_pm.c
> @@ -37,6 +37,7 @@
>  #include <dirent.h>
>  
>  #include "drmtest.h"
> +#include "igt_kms.h"
>  #include "igt_pm.h"
>  #include "igt_aux.h"
>  #include "igt_sysfs.h"
> @@ -827,3 +828,29 @@ bool igt_pm_pc8_plus_residencies_enabled(int msr_fd)
>  
>  	return true;
>  }
> +
> +/**
> + * igt_output_is_lpsp_capable:
> + * @drm_fd: fd to drm device
> + * @output: igt output for which lpsp capability need to be evaluated
> + * Check lpsp capability for a given output.
> + *
> + * Returns:
> + * True if given output is lpsp capable otherwise false.
> + */
> +bool igt_output_is_lpsp_capable(int drm_fd, igt_output_t *output)

Do we have a file for i915-specific features? If not, maybe prefixing
the function with i915 would help readers understand that this is an
i915-specific function.

> +{
> +	char buf[256];
> +	int fd, len;
> +
> +	fd = igt_debugfs_connector_dir(drm_fd, output->name, O_RDONLY);
> +	igt_require(fd >= 0);
> +	len = igt_debugfs_simple_read(fd, "i915_lpsp_info", buf, sizeof(buf));
> +
> +	if (len < 0)
> +		igt_assert_eq(len, -ENODEV);
> +
> +	close(fd);
> +
> +	return strstr(buf, "LPSP capable");
> +}
> diff --git a/lib/igt_pm.h b/lib/igt_pm.h
> index 5e438452..076d8c27 100644
> --- a/lib/igt_pm.h
> +++ b/lib/igt_pm.h
> @@ -53,5 +53,6 @@ enum igt_runtime_pm_status igt_get_runtime_pm_status(void);
>  bool igt_wait_for_pm_status(enum igt_runtime_pm_status status);
>  bool igt_pm_dmc_loaded(int debugfs);
>  bool igt_pm_pc8_plus_residencies_enabled(int msr_fd);
> +bool igt_output_is_lpsp_capable(int drm_fd, igt_output_t *output);
>  
>  #endif /* IGT_PM_H */
> 


[-- Attachment #2: pEpkey.asc --]
[-- Type: application/pgp-keys, Size: 1774 bytes --]

[-- Attachment #3: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2020-03-23  6:55 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-23  6:32 [igt-dev] [PATCH i-g-t v2 0/5] lpsp platform agnostic support Anshuman Gupta
2020-03-23  6:32 ` [igt-dev] [PATCH i-g-t v2 1/5] lib/igt_pm: Add lib func to get lpsp capability Anshuman Gupta
2020-03-23  6:55   ` Peres, Martin [this message]
2020-03-24  6:05     ` Anshuman Gupta
2020-03-23  6:32 ` [igt-dev] [PATCH i-g-t v2 2/5] tests/i915_pm_lpsp: lpsp platform agnostic support Anshuman Gupta
2020-03-23  7:00   ` Peres, Martin
2020-03-23  7:46     ` Anshuman Gupta
2020-03-23  8:04       ` Peres, Martin
2020-03-23 12:48       ` Kai Vehmanen
2020-03-23 15:33         ` Anshuman Gupta
2020-03-23  6:32 ` [igt-dev] [PATCH i-g-t v2 3/5] tests/i915_pm_lpsp: Skip panel-fitter subtest for 1024x768 panels Anshuman Gupta
2020-03-23  7:00   ` Peres, Martin
2020-03-23  6:32 ` [igt-dev] [PATCH i-g-t v2 4/5] tests/i915_pm_lpsp: screens-disabled subtest use igt_wait Anshuman Gupta
2020-03-23  7:05   ` Peres, Martin
2020-03-23  9:37     ` Anshuman Gupta
2020-03-23  6:32 ` [igt-dev] [PATCH i-g-t v2 5/5] tests/i915_pm_rpm: lpsp/non-lpsp screen mode_set_data Anshuman Gupta
2020-03-23  7:10   ` Peres, Martin
2020-03-23  7:27 ` [igt-dev] ✗ Fi.CI.BAT: failure for lpsp platform agnostic support (rev3) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed6f16b6a7384617b0214849ce0c6ed3@intel.com \
    --to=martin.peres@intel.com \
    --cc=anshuman.gupta@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox