public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] kms_flip: Skip interruptible testing for negative and hangs tests
@ 2020-04-04 10:41 Chris Wilson
  2020-04-04 11:10 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Chris Wilson @ 2020-04-04 10:41 UTC (permalink / raw)
  To: igt-dev; +Cc: Chris Wilson

Negative tests are API tests that will be rejected before we either
waiting. Repeating them expecting it to be interrupted is a forlorn
hope.

Hang tests are expected to be blocked until they can be resolved by
hangcheck. Repeating those to see how a long wait responds when
interrupted is counter purpose, just a waste of time.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/kms_flip.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index 9ce83c53d..c95838c73 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -1600,10 +1600,17 @@ igt_main
 			continue;
 
 		/*
+		 * -EINVAL are negative API tests, they are rejected before
+		 *  any waits and so not subject to interruptiblity.
+		 *
 		 * -EBUSY needs to complete in a single vblank, skip them for
 		 * interruptible tests
+		 *
+		 * HANGs are slow enough and interruptible hang testing is
+		 * an oxymoron (can't force the wait-for-hang if being
+		 * interrupted all the time).
 		 */
-		if (tests[i].flags & TEST_EBUSY)
+		if (tests[i].flags & (TEST_EINVAL | TEST_EBUSY | TEST_HANG))
 			continue;
 
 		igt_subtest_f( "%s-interruptible", tests[i].name)
-- 
2.26.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-04-05  2:16 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-04 10:41 [igt-dev] [PATCH i-g-t] kms_flip: Skip interruptible testing for negative and hangs tests Chris Wilson
2020-04-04 11:10 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-04-04 15:11 ` [igt-dev] [PATCH i-g-t] " Andi Shyti
2020-04-05  2:16 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox