public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: igt-dev@lists.freedesktop.org
Cc: Petri Latvala <petri.latvala@intel.com>,
	Chris Wilson <chris@chris-wilson.co.uk>
Subject: [igt-dev] [PATCH i-g-t] kms_atomic_transition: Make the available pipe discovery dynamic
Date: Mon, 20 Apr 2020 15:03:12 +0100	[thread overview]
Message-ID: <20200420140312.3401290-1-chris@chris-wilson.co.uk> (raw)

All of the per-plane tests are run on all available matching pipes. A
natural case for igt_subtest_with_dynamic + igt_dynamic_f

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Petri Latvala <petri.latvala@intel.com>
---
 tests/kms_atomic_transition.c | 86 +++++++++++++++++++++--------------
 1 file changed, 52 insertions(+), 34 deletions(-)

diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c
index 44f01109d..d28a8cdf5 100644
--- a/tests/kms_atomic_transition.c
+++ b/tests/kms_atomic_transition.c
@@ -924,71 +924,89 @@ igt_main
 		for_each_pipe_with_valid_output(&display, pipe, output)
 			run_primary_test(&display, pipe, output);
 
-	igt_subtest("plane-all-transition")
-		for_each_pipe_with_valid_output(&display, pipe, output)
-			run_transition_test(&display, pipe, output, TRANSITION_PLANES, false, false);
+	igt_subtest_with_dynamic("plane-all-transition") {
+		for_each_pipe_with_valid_output(&display, pipe, output) {
+			igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe))
+				run_transition_test(&display, pipe, output, TRANSITION_PLANES, false, false);
+		}
+	}
 
-	igt_subtest("plane-all-transition-fencing")
-		for_each_pipe_with_valid_output(&display, pipe, output)
-			run_transition_test(&display, pipe, output, TRANSITION_PLANES, false, true);
+	igt_subtest_with_dynamic("plane-all-transition-fencing") {
+		for_each_pipe_with_valid_output(&display, pipe, output) {
+			igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe))
+				run_transition_test(&display, pipe, output, TRANSITION_PLANES, false, true);
+		}
+	}
 
-	igt_subtest("plane-all-transition-nonblocking")
-		for_each_pipe_with_valid_output(&display, pipe, output)
-			run_transition_test(&display, pipe, output, TRANSITION_PLANES, true, false);
+	igt_subtest_with_dynamic("plane-all-transition-nonblocking") {
+		for_each_pipe_with_valid_output(&display, pipe, output) {
+			igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe))
+				run_transition_test(&display, pipe, output, TRANSITION_PLANES, true, false);
+		}
+	}
 
-	igt_subtest("plane-all-transition-nonblocking-fencing")
-		for_each_pipe_with_valid_output(&display, pipe, output)
-			run_transition_test(&display, pipe, output, TRANSITION_PLANES, true, true);
+	igt_subtest_with_dynamic("plane-all-transition-nonblocking-fencing") {
+		for_each_pipe_with_valid_output(&display, pipe, output) {
+			igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe))
+				run_transition_test(&display, pipe, output, TRANSITION_PLANES, true, true);
+		}
+	}
 
-	igt_subtest("plane-use-after-nonblocking-unbind")
-		for_each_pipe_with_valid_output(&display, pipe, output)
-			run_transition_test(&display, pipe, output, TRANSITION_AFTER_FREE, true, false);
+	igt_subtest_with_dynamic("plane-use-after-nonblocking-unbind") {
+		for_each_pipe_with_valid_output(&display, pipe, output) {
+			igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe))
+				run_transition_test(&display, pipe, output, TRANSITION_AFTER_FREE, true, false);
+		}
+	}
 
-	igt_subtest("plane-use-after-nonblocking-unbind-fencing")
-		for_each_pipe_with_valid_output(&display, pipe, output)
-			run_transition_test(&display, pipe, output, TRANSITION_AFTER_FREE, true, true);
+	igt_subtest_with_dynamic("plane-use-after-nonblocking-unbind-fencing") {
+		for_each_pipe_with_valid_output(&display, pipe, output) {
+			igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe))
+				run_transition_test(&display, pipe, output, TRANSITION_AFTER_FREE, true, true);
+		}
+	}
 
 	/*
 	 * Test modeset cases on internal panels separately with a reduced
 	 * number of combinations, to avoid long runtimes due to modesets on
 	 * panels with long power cycle delays.
 	 */
-	igt_subtest("plane-all-modeset-transition")
+	igt_subtest_with_dynamic("plane-all-modeset-transition")
 		for_each_pipe_with_valid_output(&display, pipe, output) {
 			if (output_is_internal_panel(output))
 				continue;
-			run_transition_test(&display, pipe, output, TRANSITION_MODESET, false, false);
+
+			igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe))
+				run_transition_test(&display, pipe, output, TRANSITION_MODESET, false, false);
 		}
 
-	igt_subtest("plane-all-modeset-transition-fencing")
+	igt_subtest_with_dynamic("plane-all-modeset-transition-fencing")
 		for_each_pipe_with_valid_output(&display, pipe, output) {
 			if (output_is_internal_panel(output))
 				continue;
-			run_transition_test(&display, pipe, output, TRANSITION_MODESET, false, true);
-		}
 
-	igt_subtest("plane-all-modeset-transition-internal-panels") {
-		int tested = 0;
+			igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe))
+				run_transition_test(&display, pipe, output, TRANSITION_MODESET, false, true);
+		}
 
+	igt_subtest_with_dynamic("plane-all-modeset-transition-internal-panels") {
 		for_each_pipe_with_valid_output(&display, pipe, output) {
 			if (!output_is_internal_panel(output))
 				continue;
-			run_transition_test(&display, pipe, output, TRANSITION_MODESET_FAST, false, false);
-			tested++;
+
+			igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe))
+				run_transition_test(&display, pipe, output, TRANSITION_MODESET_FAST, false, false);
 		}
-		igt_skip_on_f(!tested, "No output with internal panel found\n");
 	}
 
-	igt_subtest("plane-all-modeset-transition-fencing-internal-panels") {
-		int tested = 0;
-
+	igt_subtest_with_dynamic("plane-all-modeset-transition-fencing-internal-panels") {
 		for_each_pipe_with_valid_output(&display, pipe, output) {
 			if (!output_is_internal_panel(output))
 				continue;
-			run_transition_test(&display, pipe, output, TRANSITION_MODESET_FAST, false, true);
-			tested++;
+
+			igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe))
+				run_transition_test(&display, pipe, output, TRANSITION_MODESET_FAST, false, true);
 		}
-		igt_skip_on_f(!tested, "No output with internal panel found\n");
 	}
 
 	igt_subtest("plane-toggle-modeset-transition")
-- 
2.26.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2020-04-20 14:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-20 14:03 Chris Wilson [this message]
2020-04-20 14:30 ` [igt-dev] ✓ Fi.CI.BAT: success for kms_atomic_transition: Make the available pipe discovery dynamic Patchwork
2020-04-20 19:02 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2020-04-21 11:38 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
2020-04-27  8:40 ` Petri Latvala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200420140312.3401290-1-chris@chris-wilson.co.uk \
    --to=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=petri.latvala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox