From: Petri Latvala <petri.latvala@intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] kms_atomic_transition: Make the available pipe discovery dynamic
Date: Mon, 27 Apr 2020 11:40:37 +0300 [thread overview]
Message-ID: <20200427084037.GP9497@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20200420140312.3401290-1-chris@chris-wilson.co.uk>
On Mon, Apr 20, 2020 at 03:03:12PM +0100, Chris Wilson wrote:
> All of the per-plane tests are run on all available matching pipes. A
> natural case for igt_subtest_with_dynamic + igt_dynamic_f
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Petri Latvala <petri.latvala@intel.com>
> ---
A side note, now that this change has been in effect for a bit and
properly skips when no matching pipe/output combos are found:
We're using for_each_pipe_with_valid_output, omitting the loop
elements with a (non-)internal panel. However, that loop only loops
through pipes, trying one output valid for that pipe. In effect, we
only test internal panels even if we have non-internal outputs
available, if the pipe can also drive the internal panel's output.
Maarten, do we really need the non/internal panel separation for this
test?
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2020-04-27 8:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 14:03 [igt-dev] [PATCH i-g-t] kms_atomic_transition: Make the available pipe discovery dynamic Chris Wilson
2020-04-20 14:30 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-04-20 19:02 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2020-04-21 11:38 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
2020-04-27 8:40 ` Petri Latvala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200427084037.GP9497@platvala-desk.ger.corp.intel.com \
--to=petri.latvala@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox