public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Allow modeset to surivive change of cdclk
@ 2020-04-20  6:46 Juha-Pekka Heikkila
  2020-04-20  9:03 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_big_fb: Allow modeset to surivive change of cdclk (rev2) Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Juha-Pekka Heikkila @ 2020-04-20  6:46 UTC (permalink / raw)
  To: igt-dev

When testing 64bpp formats there will come modeset to change cdclk.
Allow modesets on atomic commits so commits will not produce error.

Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
 tests/kms_big_fb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c
index eb144da9..a754b299 100644
--- a/tests/kms_big_fb.c
+++ b/tests/kms_big_fb.c
@@ -294,6 +294,7 @@ static bool test_plane(data_t *data)
 		 */
 		if (i == 0 && data->display.is_atomic &&
 		    igt_display_try_commit_atomic(&data->display,
+						  DRM_MODE_ATOMIC_ALLOW_MODESET |
 						  DRM_MODE_ATOMIC_TEST_ONLY,
 						  NULL) != 0) {
 			if (igt_plane_has_prop(plane, IGT_PLANE_ROTATION))
-- 
2.26.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Allow modeset to surivive change of cdclk
@ 2020-04-17  9:24 Juha-Pekka Heikkila
  2020-04-17 13:17 ` Ville Syrjälä
  0 siblings, 1 reply; 7+ messages in thread
From: Juha-Pekka Heikkila @ 2020-04-17  9:24 UTC (permalink / raw)
  To: igt-dev

When testing 64bpp formats there will come modeset to change cdclk.
Allow modesets on atomic commits so commits will not produce error.

Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
 tests/kms_big_fb.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c
index eb144da9..8ea7b5d1 100644
--- a/tests/kms_big_fb.c
+++ b/tests/kms_big_fb.c
@@ -294,6 +294,7 @@ static bool test_plane(data_t *data)
 		 */
 		if (i == 0 && data->display.is_atomic &&
 		    igt_display_try_commit_atomic(&data->display,
+						  DRM_MODE_ATOMIC_ALLOW_MODESET |
 						  DRM_MODE_ATOMIC_TEST_ONLY,
 						  NULL) != 0) {
 			if (igt_plane_has_prop(plane, IGT_PLANE_ROTATION))
@@ -318,8 +319,11 @@ static bool test_plane(data_t *data)
 		copy_pattern(data, small_fb, 0, 0, big_fb, x, y,
 			     small_fb->width, small_fb->height);
 
-		igt_display_commit2(&data->display, data->display.is_atomic ?
-				    COMMIT_ATOMIC : COMMIT_UNIVERSAL);
+		if (data->display.is_atomic) {
+			igt_display_commit_atomic(&data->display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
+		} else {
+			igt_display_commit2(&data->display, COMMIT_UNIVERSAL);
+		}
 
 
 		igt_pipe_crc_collect_crc(data->pipe_crc, &small_crc);
-- 
2.26.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-04-20 17:17 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-20  6:46 [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Allow modeset to surivive change of cdclk Juha-Pekka Heikkila
2020-04-20  9:03 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_big_fb: Allow modeset to surivive change of cdclk (rev2) Patchwork
2020-04-20 11:49 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_big_fb: Allow modeset to surivive change of cdclk (rev3) Patchwork
2020-04-20 16:32 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2020-04-20 17:17 ` [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Allow modeset to surivive change of cdclk Ville Syrjälä
  -- strict thread matches above, loose matches on Subject: below --
2020-04-17  9:24 Juha-Pekka Heikkila
2020-04-17 13:17 ` Ville Syrjälä

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox