* [igt-dev] [PATCH i-g-t 0/2] tests/kms_chamelium Handle DP FSM more reliably
@ 2020-05-10 19:35 Kunal Joshi
2020-05-10 19:35 ` [igt-dev] [PATCH i-g-t 1/2] tests/kms_chamelium Fix DP FSM in dp-mode-timings Kunal Joshi
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Kunal Joshi @ 2020-05-10 19:35 UTC (permalink / raw)
To: arkadiusz.hiler, igt-dev, imre.deak; +Cc: Kunal Joshi
Receiver reset is always required after we set a new mode, so let's disable
the mode (reset_state() does that) before we switch to a new mode.
With this we will get the HPD pulses reliably for each iteration over
all the supoprted modes.
Cc: Hiler Arkadiusz <arkadiusz.hiler@intel.com>
Cc: Imre Deak <imre.deak@intel.com>
Issue: https://gitlab.freedesktop.org/drm/intel/issues/262
Kunal Joshi (2):
tests/kms_chamelium Fix DP FSM in dp-mode-timings
HAX: Run in BAT
tests/intel-ci/fast-feedback.testlist | 1 +
tests/kms_chamelium.c | 46 +++++++++++++++++----------
2 files changed, 31 insertions(+), 16 deletions(-)
--
2.25.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 7+ messages in thread* [igt-dev] [PATCH i-g-t 1/2] tests/kms_chamelium Fix DP FSM in dp-mode-timings 2020-05-10 19:35 [igt-dev] [PATCH i-g-t 0/2] tests/kms_chamelium Handle DP FSM more reliably Kunal Joshi @ 2020-05-10 19:35 ` Kunal Joshi 2020-05-11 10:26 ` Arkadiusz Hiler 2020-05-10 19:35 ` [igt-dev] [PATCH i-g-t 2/2] HAX: Run in BAT Kunal Joshi ` (2 subsequent siblings) 3 siblings, 1 reply; 7+ messages in thread From: Kunal Joshi @ 2020-05-10 19:35 UTC (permalink / raw) To: arkadiusz.hiler, igt-dev, imre.deak; +Cc: Kunal Joshi Receiver reset is always required after we set a new mode, so let's disable the mode (reset_state() does that) before we switch to a new mode. With this we will get the HPD pulses reliably for each iteration over all the supoprted modes. For more details Refer commit: c8dc1fd926a550308b971ca7d83fe0a927a38152 Cc: Hiler Arkadiusz <arkadiusz.hiler@intel.com> Cc: Imre Deak <imre.deak@intel.com> Issue: https://gitlab.freedesktop.org/drm/intel/issues/262 Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com> --- tests/kms_chamelium.c | 46 ++++++++++++++++++++++++++++--------------- 1 file changed, 30 insertions(+), 16 deletions(-) diff --git a/tests/kms_chamelium.c b/tests/kms_chamelium.c index 421a9006..26bf4dd5 100644 --- a/tests/kms_chamelium.c +++ b/tests/kms_chamelium.c @@ -1017,24 +1017,39 @@ static const char test_mode_timings_desc[] = "mode detected by the Chamelium receiver matches the mode we set"; static void test_mode_timings(data_t *data, struct chamelium_port *port) { - igt_output_t *output; - igt_plane_t *primary; - drmModeConnector *connector; - int fb_id, i; - struct igt_fb fb; + int i, count_modes; + i = 0; igt_require(chamelium_supports_get_video_params(data->chamelium)); + do { + igt_output_t *output; + igt_plane_t *primary; + drmModeConnector *connector; + drmModeModeInfo *mode; + int fb_id; + struct igt_fb fb; - reset_state(data, port); + /* + * let's reset state each mode so we will get the + * HPD pulses realibably + */ + reset_state(data, port); - output = prepare_output(data, port, TEST_EDID_BASE); - connector = chamelium_port_get_connector(data->chamelium, port, false); - primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY); - igt_assert(primary); + /* + * modes may change due to mode pruining and link issues, so we + * need to refresh the connector + */ + output = prepare_output(data, port, TEST_EDID_BASE); + connector = chamelium_port_get_connector(data->chamelium, port, false); + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY); + igt_assert(primary); - igt_assert(connector->count_modes > 0); - for (i = 0; i < connector->count_modes; i++) { - drmModeModeInfo *mode = &connector->modes[i]; + /* we may skip some modes due to above but that's ok */ + count_modes = connector->count_modes; + if (i >= count_modes) + break; + + mode = &connector->modes[i]; fb_id = igt_create_color_pattern_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, @@ -1051,9 +1066,8 @@ static void test_mode_timings(data_t *data, struct chamelium_port *port) check_mode(data->chamelium, port, mode); igt_remove_fb(data->drm_fd, &fb); - } - - drmModeFreeConnector(connector); + drmModeFreeConnector(connector); + } while (++i < count_modes); } /* Set of Video Identification Codes advertised in the EDID */ -- 2.25.1 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/2] tests/kms_chamelium Fix DP FSM in dp-mode-timings 2020-05-10 19:35 ` [igt-dev] [PATCH i-g-t 1/2] tests/kms_chamelium Fix DP FSM in dp-mode-timings Kunal Joshi @ 2020-05-11 10:26 ` Arkadiusz Hiler 0 siblings, 0 replies; 7+ messages in thread From: Arkadiusz Hiler @ 2020-05-11 10:26 UTC (permalink / raw) To: Kunal Joshi; +Cc: igt-dev On Mon, May 11, 2020 at 01:05:50AM +0530, Kunal Joshi wrote: > Receiver reset is always required after we set a new mode, so let's disable > the mode (reset_state() does that) before we switch to a new mode. > With this we will get the HPD pulses reliably for each iteration over > all the supoprted modes. > > For more details > Refer commit: c8dc1fd926a550308b971ca7d83fe0a927a38152 Please refer to commits using this format: c8dc1fd926a5 ("tests/kms_chamelium: Capture on type-c") You can get that easily with: git log -1 --abbrev=12 --format='%h ("%s")' $SHA1 > Cc: Hiler Arkadiusz <arkadiusz.hiler@intel.com> > Cc: Imre Deak <imre.deak@intel.com> > Issue: https://gitlab.freedesktop.org/drm/intel/issues/262 > Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com> Pretty much the same treatment you gave the other subtests in the mentioned commit, looks straightforward Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com> _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 7+ messages in thread
* [igt-dev] [PATCH i-g-t 2/2] HAX: Run in BAT 2020-05-10 19:35 [igt-dev] [PATCH i-g-t 0/2] tests/kms_chamelium Handle DP FSM more reliably Kunal Joshi 2020-05-10 19:35 ` [igt-dev] [PATCH i-g-t 1/2] tests/kms_chamelium Fix DP FSM in dp-mode-timings Kunal Joshi @ 2020-05-10 19:35 ` Kunal Joshi 2020-05-11 3:03 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_chamelium Handle DP FSM more reliably (rev2) Patchwork 2020-05-11 5:16 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork 3 siblings, 0 replies; 7+ messages in thread From: Kunal Joshi @ 2020-05-10 19:35 UTC (permalink / raw) To: arkadiusz.hiler, igt-dev, imre.deak; +Cc: Kunal Joshi Run in bat Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com> --- tests/intel-ci/fast-feedback.testlist | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist index 2ccad438..11833c6d 100644 --- a/tests/intel-ci/fast-feedback.testlist +++ b/tests/intel-ci/fast-feedback.testlist @@ -85,6 +85,7 @@ igt@kms_addfb_basic@unused-offsets igt@kms_addfb_basic@unused-pitches igt@kms_busy@basic igt@kms_chamelium@dp-hpd-fast +igt@kms_chamelium@dp-mode-timings igt@kms_chamelium@dp-edid-read igt@kms_chamelium@dp-crc-fast igt@kms_chamelium@hdmi-hpd-fast -- 2.25.1 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_chamelium Handle DP FSM more reliably (rev2) 2020-05-10 19:35 [igt-dev] [PATCH i-g-t 0/2] tests/kms_chamelium Handle DP FSM more reliably Kunal Joshi 2020-05-10 19:35 ` [igt-dev] [PATCH i-g-t 1/2] tests/kms_chamelium Fix DP FSM in dp-mode-timings Kunal Joshi 2020-05-10 19:35 ` [igt-dev] [PATCH i-g-t 2/2] HAX: Run in BAT Kunal Joshi @ 2020-05-11 3:03 ` Patchwork 2020-05-11 5:16 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork 3 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2020-05-11 3:03 UTC (permalink / raw) To: Kunal Joshi; +Cc: igt-dev == Series Details == Series: tests/kms_chamelium Handle DP FSM more reliably (rev2) URL : https://patchwork.freedesktop.org/series/77071/ State : success == Summary == CI Bug Log - changes from CI_DRM_8461 -> IGTPW_4552 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4552/index.html Known issues ------------ Here are the changes found in IGTPW_4552 that come from known issues: ### IGT changes ### #### Possible fixes #### * igt@i915_selftest@live@hangcheck: - fi-icl-y: [INCOMPLETE][1] ([i915#1580]) -> [PASS][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8461/fi-icl-y/igt@i915_selftest@live@hangcheck.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4552/fi-icl-y/igt@i915_selftest@live@hangcheck.html [i915#1580]: https://gitlab.freedesktop.org/drm/intel/issues/1580 Participating hosts (48 -> 39) ------------------------------ Additional (1): fi-kbl-7560u Missing (10): fi-ilk-m540 fi-bxt-dsi fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-cfl-8700k fi-whl-u fi-byt-clapper fi-bdw-samus fi-kbl-r Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_5644 -> IGTPW_4552 CI-20190529: 20190529 CI_DRM_8461: c0be14b9502e54c9ece4f4fc25872d665c6a6553 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_4552: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4552/index.html IGT_5644: 16f067ae42a6a93b8f0c5835210e2575a883001b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4552/index.html _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 7+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_chamelium Handle DP FSM more reliably (rev2) 2020-05-10 19:35 [igt-dev] [PATCH i-g-t 0/2] tests/kms_chamelium Handle DP FSM more reliably Kunal Joshi ` (2 preceding siblings ...) 2020-05-11 3:03 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_chamelium Handle DP FSM more reliably (rev2) Patchwork @ 2020-05-11 5:16 ` Patchwork 3 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2020-05-11 5:16 UTC (permalink / raw) To: Kunal Joshi; +Cc: igt-dev == Series Details == Series: tests/kms_chamelium Handle DP FSM more reliably (rev2) URL : https://patchwork.freedesktop.org/series/77071/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8461_full -> IGTPW_4552_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with IGTPW_4552_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in IGTPW_4552_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4552/index.html Possible new issues ------------------- Here are the unknown changes that may have been introduced in IGTPW_4552_full: ### IGT changes ### #### Possible regressions #### * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render: - shard-tglb: [PASS][1] -> [INCOMPLETE][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8461/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4552/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html Known issues ------------ Here are the changes found in IGTPW_4552_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_softpin@noreloc-s3: - shard-kbl: [PASS][3] -> [INCOMPLETE][4] ([i915#155]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8461/shard-kbl7/igt@gem_softpin@noreloc-s3.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4552/shard-kbl2/igt@gem_softpin@noreloc-s3.html * igt@gem_workarounds@suspend-resume-context: - shard-apl: [PASS][5] -> [DMESG-WARN][6] ([i915#180]) +1 similar issue [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8461/shard-apl6/igt@gem_workarounds@suspend-resume-context.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4552/shard-apl4/igt@gem_workarounds@suspend-resume-context.html * igt@kms_cursor_crc@pipe-c-cursor-256x256-onscreen: - shard-glk: [PASS][7] -> [FAIL][8] ([i915#54]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8461/shard-glk4/igt@kms_cursor_crc@pipe-c-cursor-256x256-onscreen.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4552/shard-glk7/igt@kms_cursor_crc@pipe-c-cursor-256x256-onscreen.html * igt@kms_cursor_legacy@flip-vs-cursor-crc-legacy: - shard-kbl: [PASS][9] -> [FAIL][10] ([i915#1566] / [i915#93] / [i915#95]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8461/shard-kbl2/igt@kms_cursor_legacy@flip-vs-cursor-crc-legacy.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4552/shard-kbl1/igt@kms_cursor_legacy@flip-vs-cursor-crc-legacy.html * igt@kms_hdmi_inject@inject-audio: - shard-tglb: [PASS][11] -> [SKIP][12] ([i915#433]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8461/shard-tglb2/igt@kms_hdmi_inject@inject-audio.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4552/shard-tglb3/igt@kms_hdmi_inject@inject-audio.html * igt@kms_mmap_write_crc@main: - shard-kbl: [PASS][13] -> [FAIL][14] ([i915#93] / [i915#95]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8461/shard-kbl4/igt@kms_mmap_write_crc@main.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4552/shard-kbl1/igt@kms_mmap_write_crc@main.html * igt@kms_plane_cursor@pipe-a-viewport-size-64: - shard-kbl: [PASS][15] -> [FAIL][16] ([i915#1559] / [i915#93] / [i915#95]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8461/shard-kbl7/igt@kms_plane_cursor@pipe-a-viewport-size-64.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4552/shard-kbl6/igt@kms_plane_cursor@pipe-a-viewport-size-64.html - shard-apl: [PASS][17] -> [FAIL][18] ([i915#1559] / [i915#95]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8461/shard-apl8/igt@kms_plane_cursor@pipe-a-viewport-size-64.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4552/shard-apl6/igt@kms_plane_cursor@pipe-a-viewport-size-64.html * igt@kms_psr2_su@frontbuffer: - shard-iclb: [PASS][19] -> [SKIP][20] ([fdo#109642] / [fdo#111068]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8461/shard-iclb2/igt@kms_psr2_su@frontbuffer.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4552/shard-iclb1/igt@kms_psr2_su@frontbuffer.html * igt@kms_psr@psr2_primary_mmap_cpu: - shard-iclb: [PASS][21] -> [SKIP][22] ([fdo#109441]) +2 similar issues [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8461/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4552/shard-iclb5/igt@kms_psr@psr2_primary_mmap_cpu.html #### Possible fixes #### * {igt@gem_ctx_isolation@preservation-s3@rcs0}: - shard-kbl: [INCOMPLETE][23] ([i915#155]) -> [PASS][24] [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8461/shard-kbl3/igt@gem_ctx_isolation@preservation-s3@rcs0.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4552/shard-kbl1/igt@gem_ctx_isolation@preservation-s3@rcs0.html * igt@gen9_exec_parse@allowed-all: - shard-kbl: [DMESG-WARN][25] ([i915#1436] / [i915#716]) -> [PASS][26] [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8461/shard-kbl1/igt@gen9_exec_parse@allowed-all.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4552/shard-kbl4/igt@gen9_exec_parse@allowed-all.html * igt@i915_suspend@sysfs-reader: - shard-apl: [DMESG-WARN][27] ([i915#180]) -> [PASS][28] +1 similar issue [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8461/shard-apl6/igt@i915_suspend@sysfs-reader.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4552/shard-apl4/igt@i915_suspend@sysfs-reader.html * igt@kms_cursor_legacy@cursor-vs-flip-toggle: - shard-hsw: [FAIL][29] ([i915#57]) -> [PASS][30] [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8461/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4552/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html * igt@kms_draw_crc@draw-method-xrgb8888-mmap-gtt-untiled: - shard-apl: [FAIL][31] ([i915#52] / [i915#54] / [i915#95]) -> [PASS][32] [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8461/shard-apl7/igt@kms_draw_crc@draw-method-xrgb8888-mmap-gtt-untiled.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4552/shard-apl8/igt@kms_draw_crc@draw-method-xrgb8888-mmap-gtt-untiled.html - shard-kbl: [FAIL][33] ([i915#177] / [i915#52] / [i915#54] / [i915#93] / [i915#95]) -> [PASS][34] [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8461/shard-kbl2/igt@kms_draw_crc@draw-method-xrgb8888-mmap-gtt-untiled.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4552/shard-kbl2/igt@kms_draw_crc@draw-method-xrgb8888-mmap-gtt-untiled.html * {igt@kms_flip@2x-flip-vs-suspend-interruptible@bc-vga1-hdmi-a1}: - shard-hsw: [INCOMPLETE][35] ([i915#61]) -> [PASS][36] [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8461/shard-hsw6/igt@kms_flip@2x-flip-vs-suspend-interruptible@bc-vga1-hdmi-a1.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4552/shard-hsw4/igt@kms_flip@2x-flip-vs-suspend-interruptible@bc-vga1-hdmi-a1.html * {igt@kms_flip@flip-vs-suspend-interruptible@a-dp1}: - shard-kbl: [DMESG-WARN][37] ([i915#180]) -> [PASS][38] +1 similar issue [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8461/shard-kbl3/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4552/shard-kbl3/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html * igt@kms_flip_tiling@flip-changes-tiling-yf: - shard-kbl: [FAIL][39] ([i915#699] / [i915#93] / [i915#95]) -> [PASS][40] [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8461/shard-kbl6/igt@kms_flip_tiling@flip-changes-tiling-yf.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4552/shard-kbl4/igt@kms_flip_tiling@flip-changes-tiling-yf.html - shard-apl: [FAIL][41] ([i915#95]) -> [PASS][42] +1 similar issue [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8461/shard-apl2/igt@kms_flip_tiling@flip-changes-tiling-yf.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4552/shard-apl1/igt@kms_flip_tiling@flip-changes-tiling-yf.html * igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant: - shard-kbl: [FAIL][43] ([fdo#108145] / [i915#265] / [i915#93] / [i915#95]) -> [PASS][44] [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8461/shard-kbl4/igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4552/shard-kbl6/igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant.html - shard-apl: [FAIL][45] ([fdo#108145] / [i915#265] / [i915#95]) -> [PASS][46] [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8461/shard-apl4/igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4552/shard-apl1/igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant.html * igt@kms_psr@psr2_cursor_render: - shard-iclb: [SKIP][47] ([fdo#109441]) -> [PASS][48] +3 similar issues [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8461/shard-iclb5/igt@kms_psr@psr2_cursor_render.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4552/shard-iclb2/igt@kms_psr@psr2_cursor_render.html * igt@kms_setmode@basic: - shard-kbl: [FAIL][49] ([i915#31]) -> [PASS][50] [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8461/shard-kbl7/igt@kms_setmode@basic.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4552/shard-kbl2/igt@kms_setmode@basic.html * {igt@perf@blocking-parameterized}: - shard-hsw: [FAIL][51] ([i915#1542]) -> [PASS][52] [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8461/shard-hsw6/igt@perf@blocking-parameterized.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4552/shard-hsw4/igt@perf@blocking-parameterized.html #### Warnings #### * igt@i915_pm_dc@dc6-dpms: - shard-tglb: [FAIL][53] ([i915#454]) -> [SKIP][54] ([i915#468]) [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8461/shard-tglb7/igt@i915_pm_dc@dc6-dpms.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4552/shard-tglb2/igt@i915_pm_dc@dc6-dpms.html * igt@kms_content_protection@lic: - shard-apl: [FAIL][55] ([fdo#110321]) -> [TIMEOUT][56] ([i915#1319]) [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8461/shard-apl4/igt@kms_content_protection@lic.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4552/shard-apl6/igt@kms_content_protection@lic.html * igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb: - shard-apl: [FAIL][57] ([fdo#108145] / [i915#265] / [i915#95]) -> [FAIL][58] ([fdo#108145] / [i915#265]) [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8461/shard-apl6/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4552/shard-apl4/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html - shard-kbl: [FAIL][59] ([fdo#108145] / [i915#265] / [i915#93] / [i915#95]) -> [FAIL][60] ([fdo#108145] / [i915#265]) [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8461/shard-kbl6/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4552/shard-kbl7/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html * igt@kms_plane_alpha_blend@pipe-c-alpha-basic: - shard-kbl: [FAIL][61] ([fdo#108145] / [i915#265]) -> [FAIL][62] ([fdo#108145] / [i915#265] / [i915#93] / [i915#95]) [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8461/shard-kbl3/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4552/shard-kbl3/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html - shard-apl: [FAIL][63] ([fdo#108145] / [i915#265]) -> [FAIL][64] ([fdo#108145] / [i915#265] / [i915#95]) [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8461/shard-apl3/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4552/shard-apl7/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319 [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436 [i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542 [i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155 [i915#1559]: https://gitlab.freedesktop.org/drm/intel/issues/1559 [i915#1566]: https://gitlab.freedesktop.org/drm/intel/issues/1566 [i915#177]: https://gitlab.freedesktop.org/drm/intel/issues/177 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 [i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31 [i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433 [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454 [i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468 [i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52 [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54 [i915#57]: https://gitlab.freedesktop.org/drm/intel/issues/57 [i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61 [i915#699]: https://gitlab.freedesktop.org/drm/intel/issues/699 [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716 [i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 Participating hosts (11 -> 8) ------------------------------ Missing (3): pig-skl-6260u pig-glk-j5005 pig-icl-1065g7 Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_5644 -> IGTPW_4552 * Piglit: piglit_4509 -> None CI-20190529: 20190529 CI_DRM_8461: c0be14b9502e54c9ece4f4fc25872d665c6a6553 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_4552: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4552/index.html IGT_5644: 16f067ae42a6a93b8f0c5835210e2575a883001b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4552/index.html _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 7+ messages in thread
* [igt-dev] [PATCH i-g-t 0/2] tests/kms_chamelium Handle DP FSM more reliably @ 2020-05-08 2:26 Kunal Joshi 2020-05-08 2:26 ` [igt-dev] [PATCH i-g-t 1/2] tests/kms_chamelium Fix DP FSM in dp-mode-timings Kunal Joshi 0 siblings, 1 reply; 7+ messages in thread From: Kunal Joshi @ 2020-05-08 2:26 UTC (permalink / raw) To: arkadiusz.hiler, igt-dev, imre.deak; +Cc: Kunal Joshi Receiver reset is always required after we set a new mode, so let's disable the mode (reset_state() does that) before we switch to a new mode. With this we will get the HPD pulses reliably for each iteration over all the supoprted modes. For more details Refer commit: c8dc1fd926a550308b971ca7d83fe0a927a38152 Cc: Hiler Arkadiusz <arkadiusz.hiler@intel.com> Cc: Imre Deak <imre.deak@intel.com> Issue: https://gitlab.freedesktop.org/drm/intel/issues/262 Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com> Kunal Joshi (2): tests/kms_chamelium Fix DP FSM in dp-mode-timings HAX: Run in BAT tests/intel-ci/fast-feedback.testlist | 1 + tests/kms_chamelium.c | 43 +++++++++++++++++---------- 2 files changed, 29 insertions(+), 15 deletions(-) -- 2.25.1 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 7+ messages in thread
* [igt-dev] [PATCH i-g-t 1/2] tests/kms_chamelium Fix DP FSM in dp-mode-timings 2020-05-08 2:26 [igt-dev] [PATCH i-g-t 0/2] tests/kms_chamelium Handle DP FSM more reliably Kunal Joshi @ 2020-05-08 2:26 ` Kunal Joshi 0 siblings, 0 replies; 7+ messages in thread From: Kunal Joshi @ 2020-05-08 2:26 UTC (permalink / raw) To: arkadiusz.hiler, igt-dev, imre.deak; +Cc: Kunal Joshi Receiver reset is always required after we set a new mode, so let's disable the mode (reset_state() does that) before we switch to a new mode. With this we will get the HPD pulses reliably for each iteration over all the supoprted modes. For more details Refer commit: c8dc1fd926a550308b971ca7d83fe0a927a38152 Cc: Hiler Arkadiusz <arkadiusz.hiler@intel.com> Cc: Imre Deak <imre.deak@intel.com> Issue: https://gitlab.freedesktop.org/drm/intel/issues/262 Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com> --- tests/kms_chamelium.c | 43 ++++++++++++++++++++++++++++--------------- 1 file changed, 28 insertions(+), 15 deletions(-) diff --git a/tests/kms_chamelium.c b/tests/kms_chamelium.c index 421a9006..4fe26d61 100644 --- a/tests/kms_chamelium.c +++ b/tests/kms_chamelium.c @@ -1017,23 +1017,37 @@ static const char test_mode_timings_desc[] = "mode detected by the Chamelium receiver matches the mode we set"; static void test_mode_timings(data_t *data, struct chamelium_port *port) { - igt_output_t *output; - igt_plane_t *primary; - drmModeConnector *connector; - int fb_id, i; - struct igt_fb fb; + int i, count_modes; + i = 0; igt_require(chamelium_supports_get_video_params(data->chamelium)); + do { + igt_output_t *output; + igt_plane_t *primary; + drmModeConnector *connector; + int fb_id, i; + struct igt_fb fb; - reset_state(data, port); + /* + * let's reset state each mode so we will get the + * HPD pulses realibably + */ + reset_state(data, port); - output = prepare_output(data, port, TEST_EDID_BASE); - connector = chamelium_port_get_connector(data->chamelium, port, false); - primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY); - igt_assert(primary); + /* + * modes may change due to mode pruining and link issues, so we + * need to refresh the connector + */ + output = prepare_output(data, port, TEST_EDID_BASE); + connector = chamelium_port_get_connector(data->chamelium, port, false); + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY); + igt_assert(primary); - igt_assert(connector->count_modes > 0); - for (i = 0; i < connector->count_modes; i++) { + /* we may skip some modes due to above but that's ok */ + count_modes = connector->count_modes; + if (i >= count_modes) + break; + drmModeModeInfo *mode = &connector->modes[i]; fb_id = igt_create_color_pattern_fb(data->drm_fd, @@ -1051,9 +1065,8 @@ static void test_mode_timings(data_t *data, struct chamelium_port *port) check_mode(data->chamelium, port, mode); igt_remove_fb(data->drm_fd, &fb); - } - - drmModeFreeConnector(connector); + drmModeFreeConnector(connector); + } (++i < count_modes); } /* Set of Video Identification Codes advertised in the EDID */ -- 2.25.1 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-05-11 10:26 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-05-10 19:35 [igt-dev] [PATCH i-g-t 0/2] tests/kms_chamelium Handle DP FSM more reliably Kunal Joshi 2020-05-10 19:35 ` [igt-dev] [PATCH i-g-t 1/2] tests/kms_chamelium Fix DP FSM in dp-mode-timings Kunal Joshi 2020-05-11 10:26 ` Arkadiusz Hiler 2020-05-10 19:35 ` [igt-dev] [PATCH i-g-t 2/2] HAX: Run in BAT Kunal Joshi 2020-05-11 3:03 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_chamelium Handle DP FSM more reliably (rev2) Patchwork 2020-05-11 5:16 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork -- strict thread matches above, loose matches on Subject: below -- 2020-05-08 2:26 [igt-dev] [PATCH i-g-t 0/2] tests/kms_chamelium Handle DP FSM more reliably Kunal Joshi 2020-05-08 2:26 ` [igt-dev] [PATCH i-g-t 1/2] tests/kms_chamelium Fix DP FSM in dp-mode-timings Kunal Joshi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox