From: Petri Latvala <petri.latvala@intel.com>
To: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Cc: igt-dev@lists.freedesktop.org,
Michael Hebenstreit <michael.hebenstreit@intel.com>,
Fei Yang <fei.yang@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] lib/igt_core: Don't kill the world after a failed fork
Date: Thu, 4 Jun 2020 11:39:22 +0300 [thread overview]
Message-ID: <20200604083922.GV9497@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20200603125414.1027845-1-arkadiusz.hiler@intel.com>
On Wed, Jun 03, 2020 at 03:54:14PM +0300, Arkadiusz Hiler wrote:
> If we fail to fork (e.g. due to restrictive limits) -1 gets written as
> PID of our child and we assert out.
>
> The cleanup that happens afterwards tries to kill all our children,
> which ends up in kill(-1, SIGKILL) which is not good.
>
> This patch makes sure of two things:
> * -1 doesn't get written down as our child
> * when we are killing children we make sure that pid > 0
>
> Reported-by: Fei Yang <fei.yang@intel.com>
> Cc: Michael Hebenstreit <michael.hebenstreit@intel.com>
> Cc: Petri Latvala <petri.latvala@intel.com>
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-06-04 8:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 12:54 [igt-dev] [PATCH i-g-t] lib/igt_core: Don't kill the world after a failed fork Arkadiusz Hiler
2020-06-03 14:55 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-06-03 15:43 ` [igt-dev] [PATCH i-g-t] " Hebenstreit, Michael
2020-06-03 16:24 ` Arkadiusz Hiler
2020-06-03 16:30 ` Hebenstreit, Michael
2020-06-04 4:35 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
2020-06-04 8:39 ` Petri Latvala [this message]
2020-06-04 8:48 ` [igt-dev] ✗ Fi.CI.BUILD: failure for lib/igt_core: Don't kill the world after a failed fork (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200604083922.GV9497@platvala-desk.ger.corp.intel.com \
--to=petri.latvala@intel.com \
--cc=arkadiusz.hiler@intel.com \
--cc=fei.yang@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=michael.hebenstreit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox