* [igt-dev] [PATCH i-g-t] scripts/run-tests.sh: also search path for runner binaries
@ 2020-06-11 18:04 Stefan Agner
2020-06-11 18:49 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2020-06-12 5:01 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
0 siblings, 2 replies; 4+ messages in thread
From: Stefan Agner @ 2020-06-11 18:04 UTC (permalink / raw)
To: igt-dev
To make the script also useful when igt_runner/igt_resume binarires are
installed, also search PATH for the binaries.
Signed-off-by: Stefan Agner <stefan@agner.ch>
---
scripts/run-tests.sh | 21 ++++++++++++++++-----
1 file changed, 16 insertions(+), 5 deletions(-)
diff --git a/scripts/run-tests.sh b/scripts/run-tests.sh
index b7e2faa3..8399b6d1 100755
--- a/scripts/run-tests.sh
+++ b/scripts/run-tests.sh
@@ -67,10 +67,21 @@ fi
IGT_TEST_ROOT="`readlink -f ${IGT_TEST_ROOT}`"
-function find_runner_binaries
+function find_runner_binary # basename
{
- IGT_RUNNER=$(find_file igt_runner "$ROOT/build/runner" "$ROOT/runner")
- IGT_RESUME=$(find_file igt_resume "$ROOT/build/runner" "$ROOT/runner")
+ base=$1
+ shift
+
+ binary=$(find_file "$base" "$ROOT/build/runner" "$ROOT/runner")
+ if [ -x "$binary" ]; then
+ echo "$binary"
+ return 0
+ elif binary=$(which "$base"); then
+ echo "$binary"
+ return 0
+ fi
+
+ return 1
}
function download_piglit {
@@ -177,8 +188,8 @@ if [ "$USE_PIGLIT" -eq "1" ]; then
RESUME_ARGS="resume $NORETRY"
LIST_ARGS="print-cmd igt --format {name}"
else
- find_runner_binaries
- if [ ! -x "$IGT_RUNNER" -o ! -x "$IGT_RESUME" ]; then
+ if ! IGT_RUNNER=$(find_runner_binary igt_runner) ||
+ ! IGT_RESUME=$(find_runner_binary igt_resume); then
echo "Could not find igt_runner binaries."
echo "Please build the runner, or use Piglit with the -p flag."
exit 1
--
2.27.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for scripts/run-tests.sh: also search path for runner binaries
2020-06-11 18:04 [igt-dev] [PATCH i-g-t] scripts/run-tests.sh: also search path for runner binaries Stefan Agner
@ 2020-06-11 18:49 ` Patchwork
2020-06-12 5:01 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
1 sibling, 0 replies; 4+ messages in thread
From: Patchwork @ 2020-06-11 18:49 UTC (permalink / raw)
To: Stefan Agner; +Cc: igt-dev
== Series Details ==
Series: scripts/run-tests.sh: also search path for runner binaries
URL : https://patchwork.freedesktop.org/series/78234/
State : failure
== Summary ==
CI Bug Log - changes from IGT_5704 -> IGTPW_4671
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_4671 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_4671, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4671/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_4671:
### IGT changes ###
#### Possible regressions ####
* igt@runner@aborted:
- fi-bdw-5557u: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4671/fi-bdw-5557u/igt@runner@aborted.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@runner@aborted:
- {fi-kbl-7560u}: [FAIL][2] ([i915#1569] / [i915#192] / [i915#193] / [i915#194]) -> [FAIL][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5704/fi-kbl-7560u/igt@runner@aborted.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4671/fi-kbl-7560u/igt@runner@aborted.html
Known issues
------------
Here are the changes found in IGTPW_4671 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-whl-u: [PASS][4] -> [DMESG-WARN][5] ([i915#95])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5704/fi-whl-u/igt@i915_pm_rpm@basic-pci-d3-state.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4671/fi-whl-u/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@i915_pm_rpm@module-reload:
- fi-glk-dsi: [PASS][6] -> [DMESG-WARN][7] ([i915#1982])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5704/fi-glk-dsi/igt@i915_pm_rpm@module-reload.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4671/fi-glk-dsi/igt@i915_pm_rpm@module-reload.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-icl-u2: [PASS][8] -> [DMESG-WARN][9] ([i915#1982]) +1 similar issue
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5704/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4671/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
* igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
- fi-tgl-u2: [PASS][10] -> [DMESG-WARN][11] ([i915#402])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5704/fi-tgl-u2/igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4671/fi-tgl-u2/igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0:
- fi-tgl-u2: [FAIL][12] ([i915#1888]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5704/fi-tgl-u2/igt@gem_exec_suspend@basic-s0.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4671/fi-tgl-u2/igt@gem_exec_suspend@basic-s0.html
* igt@i915_module_load@reload:
- {fi-tgl-dsi}: [DMESG-WARN][14] ([i915#1982]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5704/fi-tgl-dsi/igt@i915_module_load@reload.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4671/fi-tgl-dsi/igt@i915_module_load@reload.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-bsw-kefka: [DMESG-WARN][16] ([i915#1982]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5704/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4671/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-7500u: [FAIL][18] ([i915#262]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5704/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4671/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
#### Warnings ####
* igt@gem_exec_suspend@basic-s0:
- fi-kbl-x1275: [DMESG-WARN][20] ([i915#1982] / [i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][21] ([i915#62] / [i915#92] / [i915#95])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5704/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4671/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html
* igt@i915_pm_rpm@module-reload:
- fi-kbl-x1275: [DMESG-FAIL][22] ([i915#62]) -> [SKIP][23] ([fdo#109271])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5704/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4671/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html
* igt@kms_flip@basic-flip-vs-modeset@a-dp1:
- fi-kbl-x1275: [DMESG-WARN][24] ([i915#62] / [i915#92]) -> [DMESG-WARN][25] ([i915#62] / [i915#92] / [i915#95]) +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5704/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset@a-dp1.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4671/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset@a-dp1.html
* igt@kms_force_connector_basic@force-edid:
- fi-kbl-x1275: [DMESG-WARN][26] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][27] ([i915#62] / [i915#92]) +2 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5704/fi-kbl-x1275/igt@kms_force_connector_basic@force-edid.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4671/fi-kbl-x1275/igt@kms_force_connector_basic@force-edid.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1569]: https://gitlab.freedesktop.org/drm/intel/issues/1569
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#192]: https://gitlab.freedesktop.org/drm/intel/issues/192
[i915#193]: https://gitlab.freedesktop.org/drm/intel/issues/193
[i915#194]: https://gitlab.freedesktop.org/drm/intel/issues/194
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (50 -> 43)
------------------------------
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5704 -> IGTPW_4671
CI-20190529: 20190529
CI_DRM_8618: 88841e30e7f8c60ff464be277e5b8fef49ebaea0 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4671: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4671/index.html
IGT_5704: a8c256b4feb90201c727d72c168288a676c9d6ef @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4671/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] scripts/run-tests.sh: also search path for runner binaries
2020-06-11 18:04 [igt-dev] [PATCH i-g-t] scripts/run-tests.sh: also search path for runner binaries Stefan Agner
2020-06-11 18:49 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
@ 2020-06-12 5:01 ` Petri Latvala
2020-06-12 5:06 ` Petri Latvala
1 sibling, 1 reply; 4+ messages in thread
From: Petri Latvala @ 2020-06-12 5:01 UTC (permalink / raw)
To: Stefan Agner; +Cc: igt-dev
On Thu, Jun 11, 2020 at 08:04:06PM +0200, Stefan Agner wrote:
> To make the script also useful when igt_runner/igt_resume binarires are
> installed, also search PATH for the binaries.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
> ---
> scripts/run-tests.sh | 21 ++++++++++++++++-----
> 1 file changed, 16 insertions(+), 5 deletions(-)
>
> diff --git a/scripts/run-tests.sh b/scripts/run-tests.sh
> index b7e2faa3..8399b6d1 100755
> --- a/scripts/run-tests.sh
> +++ b/scripts/run-tests.sh
> @@ -67,10 +67,21 @@ fi
>
> IGT_TEST_ROOT="`readlink -f ${IGT_TEST_ROOT}`"
>
> -function find_runner_binaries
> +function find_runner_binary # basename
> {
> - IGT_RUNNER=$(find_file igt_runner "$ROOT/build/runner" "$ROOT/runner")
> - IGT_RESUME=$(find_file igt_resume "$ROOT/build/runner" "$ROOT/runner")
> + base=$1
> + shift
> +
> + binary=$(find_file "$base" "$ROOT/build/runner" "$ROOT/runner")
> + if [ -x "$binary" ]; then
> + echo "$binary"
> + return 0
> + elif binary=$(which "$base"); then
> + echo "$binary"
> + return 0
> + fi
> +
> + return 1
> }
>
> function download_piglit {
> @@ -177,8 +188,8 @@ if [ "$USE_PIGLIT" -eq "1" ]; then
> RESUME_ARGS="resume $NORETRY"
> LIST_ARGS="print-cmd igt --format {name}"
> else
> - find_runner_binaries
> - if [ ! -x "$IGT_RUNNER" -o ! -x "$IGT_RESUME" ]; then
> + if ! IGT_RUNNER=$(find_runner_binary igt_runner) ||
> + ! IGT_RESUME=$(find_runner_binary igt_resume); then
> echo "Could not find igt_runner binaries."
> echo "Please build the runner, or use Piglit with the -p flag."
> exit 1
> --
> 2.27.0
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] scripts/run-tests.sh: also search path for runner binaries
2020-06-12 5:01 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
@ 2020-06-12 5:06 ` Petri Latvala
0 siblings, 0 replies; 4+ messages in thread
From: Petri Latvala @ 2020-06-12 5:06 UTC (permalink / raw)
To: Stefan Agner; +Cc: igt-dev
On Fri, Jun 12, 2020 at 08:01:08AM +0300, Petri Latvala wrote:
> On Thu, Jun 11, 2020 at 08:04:06PM +0200, Stefan Agner wrote:
> > To make the script also useful when igt_runner/igt_resume binarires are
> > installed, also search PATH for the binaries.
> >
> > Signed-off-by: Stefan Agner <stefan@agner.ch>
>
>
> Reviewed-by: Petri Latvala <petri.latvala@intel.com>
And merged, thanks for the patch!
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-12 5:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-11 18:04 [igt-dev] [PATCH i-g-t] scripts/run-tests.sh: also search path for runner binaries Stefan Agner
2020-06-11 18:49 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2020-06-12 5:01 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
2020-06-12 5:06 ` Petri Latvala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox