Re: [igt-dev] [Intel-gfx] [PATCH i-g-t 1/2] test/kms_cursor_crc: release old pipe_crc before create a new one

[Melissa Wen <melissa.srw@gmail.com>]

On 07/15, Arkadiusz Hiler wrote:
> On Mon, Jun 22, 2020 at 01:37:55PM -0300, Melissa Wen wrote:
> > When a subtest fails, it skips the cleanup, and its pipe_crc remains allocated.
> > As a consequence, the following subtest also fails (timeout) when trying to
> > create a new one. This patch releases any remaining pipe_crc to enable the
> > creation of a new one for the next subtest.
> > 
> > Signed-off-by: Melissa Wen <melissa.srw@gmail.com>
> > ---
> >  tests/kms_cursor_crc.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c
> > index f105e295..5976df5f 100644
> > --- a/tests/kms_cursor_crc.c
> > +++ b/tests/kms_cursor_crc.c
> > @@ -423,6 +423,8 @@ static void prepare_crtc(data_t *data, igt_output_t *output,
> >  	igt_display_commit(display);
> >  
> >  	/* create the pipe_crc object for this pipe */
> > +	if (data->pipe_crc)
> > +		igt_pipe_crc_free(data->pipe_crc);
> 
> That's a welcome improvement, but you may want to also look at
> 06333955bf3d ("tests/kms_cursor_crc: start crc only once per test")
> for some extra inspiration for future work on this.
> 
> It should be possible to initiate pipe crc to be initalized only once
> per each tested pipe in run_tests_on_pipe() - igt_pipe_crc_new() can be
> costly on some real panels.

Hi,

Thanks for the advice! 
As I have one more refactoring in mind for this test, I will add this in
the works and send a patchset with everything together.

For now, I just submitted a v2 of this patch because I dropped the other
one that was in the same patchset.

Melissa
> 
> Anyway,
> Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> 
> 
> >  	data->pipe_crc = igt_pipe_crc_new(data->drm_fd, data->pipe,
> >  					  INTEL_PIPE_CRC_SOURCE_AUTO);
> >  
> > -- 
> > 2.27.0
> > 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev