Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Melissa Wen <melissa.srw@gmail.com>
To: igt-dev@lists.freedesktop.org
Cc: kernel-usp@googlegroups.com, twoerner@gmail.com
Subject: [igt-dev] [PATCH i-g-t 0/2] test/kms_cursor_crc: tie some loose ends in prepare_crtc
Date: Thu, 25 Jun 2020 07:34:51 -0300	[thread overview]
Message-ID: <cover.1592840756.git.melissa.srw@gmail.com> (raw)

Using vkms, when running a sequence of subtests from kms_cursor_crc,
several strange timeout failures occurred. For example, running the
alpha-opaque cursor twice, the first run is successful and the second
fails. In addition, if we run the entire test in a call (i.e.: sudo
IGT_FORCE_DRIVER=vkms build/tests/kms_cursor_crc), the first subtest
passes and the rest of the subtests fail - even those that succeed when
run in isolation.

igt_debugfs-DEBUG: Opening debugfs directory '/sys/kernel/debug/dri/0'
igt_core-INFO: Timed out: Opening crc fd, and poll for first CRC.

During my debugging process, I found two issues that were blocking
execution and the solution is in this patchset:

1 - When a subtest fails, it exits and skips the cleaning step, leaving
the pipe_crc allocated and blocked for the next subtest. The first patch
fixes it by releasing any old pipe_crc before creating a new one.

2 - When the CRC capture process starts, it enters an endless wait; this
seems to be related to the fact that the VKMS simulates vblank events,
generating a time mismatch between vblank and CRC capture. Waiting for
vblank before starting the capture process sets the pace, as shown in
the second patch.

Melissa Wen (2):
  test/kms_cursor_crc: release old pipe_crc before create a new one
  test/kms_cursor_crc: align the start of the CRC capture to a vblank

 tests/kms_cursor_crc.c | 3 +++
 1 file changed, 3 insertions(+)

-- 
2.27.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2020-06-25 10:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-25 10:34 Melissa Wen [this message]
2020-06-25 10:35 ` [igt-dev] [PATCH i-g-t 1/2] test/kms_cursor_crc: release old pipe_crc before create a new one Melissa Wen
     [not found]   ` <20200715124706.f6bvf7g7dqbcnyaj@ahiler-desk1.fi.intel.com>
2020-07-16 11:40     ` [igt-dev] [Intel-gfx] " Melissa Wen
2020-06-25 10:36 ` [igt-dev] [PATCH i-g-t 2/2] test/kms_cursor_crc: align the start of the CRC capture to a vblank Melissa Wen
2020-06-25 15:14 ` [igt-dev] ✓ Fi.CI.BAT: success for test/kms_cursor_crc: tie some loose ends in prepare_crtc Patchwork
2020-06-25 16:11 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1592840756.git.melissa.srw@gmail.com \
    --to=melissa.srw@gmail.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kernel-usp@googlegroups.com \
    --cc=twoerner@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox