From: Anshuman Gupta <anshuman.gupta@intel.com>
To: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH] [i-g-t] tests/i915_pm_lpsp: remove screens-disabled subtest
Date: Mon, 31 Aug 2020 17:25:17 +0530 [thread overview]
Message-ID: <20200831115514.GL25390@intel.com> (raw)
In-Reply-To: <20200831115515.16531-1-tejaskumarx.surendrakumar.upadhyay@intel.com>
On 2020-08-31 at 17:25:15 +0530, Tejas Upadhyay wrote:
> screens-disabled subtest is not required to run when
> DMC firmware is loaded. Thus this test code becomes
> redundant and increases needless SKIP counts.
>
> Cc: Anshuman Gupta <Anshuman.Gupta@intel.com>
> Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
> ---
> tests/i915/i915_pm_lpsp.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/tests/i915/i915_pm_lpsp.c b/tests/i915/i915_pm_lpsp.c
> index 4a187810..d1efd9e0 100644
> --- a/tests/i915/i915_pm_lpsp.c
> +++ b/tests/i915/i915_pm_lpsp.c
> @@ -185,13 +185,6 @@ igt_main
> igt_require(igt_pm_dmc_loaded(data.debugfs_fd));
> }
>
> - igt_describe("This test validates lpsp while all crtc are disabled");
> - igt_subtest("screens-disabled") {
> - igt_require_f(!dmc_supported(data.debugfs_fd),
> - "DC states supported platform don't have ROI for this subtest\n");
> - screens_disabled_subtest(&data);
> - }
> -
Platfrom like HASWELL still need this test, you can't simply remove the test, this is a valid skip
for platform above skl+.
Thanks,
Anshuman Gupta.
> igt_describe("This test validates lpsp on all connected outputs on low power PIPE_A");
> igt_subtest_with_dynamic_f("kms-lpsp") {
> igt_display_t *display = &data.display;
> --
> 2.25.1
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next parent reply other threads:[~2020-08-31 12:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200831115515.16531-1-tejaskumarx.surendrakumar.upadhyay@intel.com>
2020-08-31 11:55 ` Anshuman Gupta [this message]
2020-08-31 12:10 ` [igt-dev] [PATCH] [i-g-t] tests/i915_pm_lpsp: remove screens-disabled subtest Surendrakumar Upadhyay, TejaskumarX
2020-08-31 12:07 ` Anshuman Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200831115514.GL25390@intel.com \
--to=anshuman.gupta@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=tejaskumarx.surendrakumar.upadhyay@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox