Re: [igt-dev] [PATCH] [i-g-t] tests/i915_pm_lpsp: remove screens-disabled subtest

Re: [igt-dev] [PATCH] [i-g-t] tests/i915_pm_lpsp: remove screens-disabled subtest

[Anshuman Gupta]

On 2020-08-31 at 17:25:15 +0530, Tejas Upadhyay wrote:
> screens-disabled subtest is not required to run when
> DMC firmware is loaded. Thus this test code becomes
> redundant and increases needless SKIP counts.
> 
> Cc: Anshuman Gupta <Anshuman.Gupta@intel.com>
> Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
> ---
>  tests/i915/i915_pm_lpsp.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/tests/i915/i915_pm_lpsp.c b/tests/i915/i915_pm_lpsp.c
> index 4a187810..d1efd9e0 100644
> --- a/tests/i915/i915_pm_lpsp.c
> +++ b/tests/i915/i915_pm_lpsp.c
> @@ -185,13 +185,6 @@ igt_main
>  		igt_require(igt_pm_dmc_loaded(data.debugfs_fd));
>  	}
>  
> -	igt_describe("This test validates lpsp while all crtc are disabled");
> -	igt_subtest("screens-disabled") {
> -		igt_require_f(!dmc_supported(data.debugfs_fd),
> -			      "DC states supported platform don't have ROI for this subtest\n");
> -		screens_disabled_subtest(&data);
> -	}
> -
Platfrom like HASWELL still need this test, you can't simply remove the test, this is a valid skip
for platform above skl+.
Thanks,
Anshuman Gupta.  
>  	igt_describe("This test validates lpsp on all connected outputs on low power PIPE_A");
>  	igt_subtest_with_dynamic_f("kms-lpsp") {
>  		igt_display_t *display = &data.display;
> -- 
> 2.25.1
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH] [i-g-t] tests/i915_pm_lpsp: remove screens-disabled subtest

[Anshuman Gupta]

On 2020-08-31 at 17:40:18 +0530, Surendrakumar Upadhyay, TejaskumarX wrote:
> Inline
> 
> -----Original Message-----
> From: Anshuman Gupta <anshuman.gupta@intel.com>
> Sent: 31 August 2020 17:25
> To: Surendrakumar Upadhyay, TejaskumarX <tejaskumarx.surendrakumar.upadhyay@intel.com>
> Cc: igt-dev@lists.freedesktop.org
> Subject: Re: [PATCH] [i-g-t] tests/i915_pm_lpsp: remove screens-disabled subtest
> 
> On 2020-08-31 at 17:25:15 +0530, Tejas Upadhyay wrote:
> > screens-disabled subtest is not required to run when DMC firmware is
> > loaded. Thus this test code becomes redundant and increases needless
> > SKIP counts.
> >
> > Cc: Anshuman Gupta <Anshuman.Gupta@intel.com>
> > Signed-off-by: Tejas Upadhyay
> > <tejaskumarx.surendrakumar.upadhyay@intel.com>
> > ---
> >  tests/i915/i915_pm_lpsp.c | 7 -------
> >  1 file changed, 7 deletions(-)
> >
> > diff --git a/tests/i915/i915_pm_lpsp.c b/tests/i915/i915_pm_lpsp.c
> > index 4a187810..d1efd9e0 100644
> > --- a/tests/i915/i915_pm_lpsp.c
> > +++ b/tests/i915/i915_pm_lpsp.c
> > @@ -185,13 +185,6 @@ igt_main
> >  igt_require(igt_pm_dmc_loaded(data.debugfs_fd));
> >  }
> >
> > -igt_describe("This test validates lpsp while all crtc are disabled");
> > -igt_subtest("screens-disabled") {
> > -igt_require_f(!dmc_supported(data.debugfs_fd),
> > -      "DC states supported platform don't have ROI for this subtest\n");
> > -screens_disabled_subtest(&data);
> > -}
> > -
> Platfrom like HASWELL still need this test, you can't simply remove the test, this is a valid skip for platform above skl+.
> Thanks,
> Anshuman Gupta.
> 
> Tejas : But those platforms will have DMC loaded? If DMC not loaded test will not enter in. And if DMC loaded this subtest will not run. How it will get executed?
DMC is not supported on platfrom prior to SKL.
Check igt_pm_dmc_loaded() carefully, it will return true in case DMC is not supported.
> 
> >  igt_describe("This test validates lpsp on all connected outputs on low power PIPE_A");
> >  igt_subtest_with_dynamic_f("kms-lpsp") {
> >  igt_display_t *display = &data.display;
> > --
> > 2.25.1
> >
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH] [i-g-t] tests/i915_pm_lpsp: remove screens-disabled subtest

[Surendrakumar Upadhyay, TejaskumarX]

Inline

-----Original Message-----
From: Anshuman Gupta <anshuman.gupta@intel.com> 
Sent: 31 August 2020 17:25
To: Surendrakumar Upadhyay, TejaskumarX <tejaskumarx.surendrakumar.upadhyay@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [PATCH] [i-g-t] tests/i915_pm_lpsp: remove screens-disabled subtest

On 2020-08-31 at 17:25:15 +0530, Tejas Upadhyay wrote:
> screens-disabled subtest is not required to run when DMC firmware is 
> loaded. Thus this test code becomes redundant and increases needless 
> SKIP counts.
> 
> Cc: Anshuman Gupta <Anshuman.Gupta@intel.com>
> Signed-off-by: Tejas Upadhyay 
> <tejaskumarx.surendrakumar.upadhyay@intel.com>
> ---
>  tests/i915/i915_pm_lpsp.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/tests/i915/i915_pm_lpsp.c b/tests/i915/i915_pm_lpsp.c 
> index 4a187810..d1efd9e0 100644
> --- a/tests/i915/i915_pm_lpsp.c
> +++ b/tests/i915/i915_pm_lpsp.c
> @@ -185,13 +185,6 @@ igt_main
>  		igt_require(igt_pm_dmc_loaded(data.debugfs_fd));
>  	}
>  
> -	igt_describe("This test validates lpsp while all crtc are disabled");
> -	igt_subtest("screens-disabled") {
> -		igt_require_f(!dmc_supported(data.debugfs_fd),
> -			      "DC states supported platform don't have ROI for this subtest\n");
> -		screens_disabled_subtest(&data);
> -	}
> -
Platfrom like HASWELL still need this test, you can't simply remove the test, this is a valid skip for platform above skl+.
Thanks,
Anshuman Gupta.  

Tejas : But those platforms will have DMC loaded? If DMC not loaded test will not enter in. And if DMC loaded this subtest will not run. How it will get executed?

>  	igt_describe("This test validates lpsp on all connected outputs on low power PIPE_A");
>  	igt_subtest_with_dynamic_f("kms-lpsp") {
>  		igt_display_t *display = &data.display;
> --
> 2.25.1
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev