* [igt-dev] [PATCH v2] drm: Quieten [zero] EDID carping [not found] <20201029110030.9959-1-chris@chris-wilson.co.uk> @ 2020-10-29 16:44 ` Chris Wilson 2020-10-29 16:59 ` Ville Syrjälä 2020-10-29 16:55 ` [igt-dev] ✗ Fi.CI.BUILD: failure for " Patchwork 1 sibling, 1 reply; 3+ messages in thread From: Chris Wilson @ 2020-10-29 16:44 UTC (permalink / raw) To: dri-devel; +Cc: igt-dev, Chris Wilson We have a few displays in CI that always report their EDID as a bunch of zeroes. This is consistent behaviour, so one assumes intentional indication of an "absent" EDID. Flagging these consistent warnings detracts from CI. One option would be to ignore the zero EDIDs as intentional behaviour, but Ville would like to keep the information available for debugging. The simple alternative then is to reduce the loglevel for all the EDID dumping from WARN to DEBUG so the information is present but not annoy CI. Note that the bad EDID dumping is already only shown if drm.debug=KMS, it's just the loglevel chosen was set to be caught by CI if it ever occurred as it was expected to be an internal error not external. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2203 Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> --- drivers/gpu/drm/drm_edid.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 631125b46e04..c7363af731b4 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -1844,7 +1844,7 @@ static void connector_bad_edid(struct drm_connector *connector, if (connector->bad_edid_counter++ && !drm_debug_enabled(DRM_UT_KMS)) return; - drm_warn(connector->dev, "%s: EDID is invalid:\n", connector->name); + drm_dbg_kms(connector->dev, "%s: EDID is invalid:\n", connector->name); for (i = 0; i < num_blocks; i++) { u8 *block = edid + i * EDID_LENGTH; char prefix[20]; @@ -1856,7 +1856,7 @@ static void connector_bad_edid(struct drm_connector *connector, else sprintf(prefix, "\t[%02x] GOOD ", i); - print_hex_dump(KERN_WARNING, + print_hex_dump(KERN_DEBUG, prefix, DUMP_PREFIX_NONE, 16, 1, block, EDID_LENGTH, false); } -- 2.20.1 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [igt-dev] [PATCH v2] drm: Quieten [zero] EDID carping 2020-10-29 16:44 ` [igt-dev] [PATCH v2] drm: Quieten [zero] EDID carping Chris Wilson @ 2020-10-29 16:59 ` Ville Syrjälä 0 siblings, 0 replies; 3+ messages in thread From: Ville Syrjälä @ 2020-10-29 16:59 UTC (permalink / raw) To: Chris Wilson; +Cc: igt-dev, dri-devel On Thu, Oct 29, 2020 at 04:44:17PM +0000, Chris Wilson wrote: > We have a few displays in CI that always report their EDID as a bunch of > zeroes. This is consistent behaviour, so one assumes intentional > indication of an "absent" EDID. Flagging these consistent warnings > detracts from CI. > > One option would be to ignore the zero EDIDs as intentional behaviour, > but Ville would like to keep the information available for debugging. > The simple alternative then is to reduce the loglevel for all the EDID > dumping from WARN to DEBUG so the information is present but not annoy > CI. Note that the bad EDID dumping is already only shown if > drm.debug=KMS, it's just the loglevel chosen was set to be caught by CI > if it ever occurred as it was expected to be an internal error not > external. Indeed. That makes this even less controversial. Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2203 > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > --- > drivers/gpu/drm/drm_edid.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 631125b46e04..c7363af731b4 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -1844,7 +1844,7 @@ static void connector_bad_edid(struct drm_connector *connector, > if (connector->bad_edid_counter++ && !drm_debug_enabled(DRM_UT_KMS)) > return; > > - drm_warn(connector->dev, "%s: EDID is invalid:\n", connector->name); > + drm_dbg_kms(connector->dev, "%s: EDID is invalid:\n", connector->name); > for (i = 0; i < num_blocks; i++) { > u8 *block = edid + i * EDID_LENGTH; > char prefix[20]; > @@ -1856,7 +1856,7 @@ static void connector_bad_edid(struct drm_connector *connector, > else > sprintf(prefix, "\t[%02x] GOOD ", i); > > - print_hex_dump(KERN_WARNING, > + print_hex_dump(KERN_DEBUG, > prefix, DUMP_PREFIX_NONE, 16, 1, > block, EDID_LENGTH, false); > } > -- > 2.20.1 -- Ville Syrjälä Intel _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 3+ messages in thread
* [igt-dev] ✗ Fi.CI.BUILD: failure for drm: Quieten [zero] EDID carping [not found] <20201029110030.9959-1-chris@chris-wilson.co.uk> 2020-10-29 16:44 ` [igt-dev] [PATCH v2] drm: Quieten [zero] EDID carping Chris Wilson @ 2020-10-29 16:55 ` Patchwork 1 sibling, 0 replies; 3+ messages in thread From: Patchwork @ 2020-10-29 16:55 UTC (permalink / raw) To: Chris Wilson; +Cc: igt-dev == Series Details == Series: drm: Quieten [zero] EDID carping URL : https://patchwork.freedesktop.org/series/83208/ State : failure == Summary == Applying: drm: Quieten [zero] EDID carping Patch failed at 0001 drm: Quieten [zero] EDID carping When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-29 16:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20201029110030.9959-1-chris@chris-wilson.co.uk>
2020-10-29 16:44 ` [igt-dev] [PATCH v2] drm: Quieten [zero] EDID carping Chris Wilson
2020-10-29 16:59 ` Ville Syrjälä
2020-10-29 16:55 ` [igt-dev] ✗ Fi.CI.BUILD: failure for " Patchwork
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox