From: Imre Deak <imre.deak@intel.com>
To: "Kahola, Mika" <mika.kahola@intel.com>
Cc: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t v7 2/2] tests/kms_ccs: CCS Clear Color test
Date: Thu, 5 Nov 2020 16:26:02 +0200 [thread overview]
Message-ID: <20201105142602.GA177799@ideak-desk.fi.intel.com> (raw)
In-Reply-To: <d600c631c0c0478ab43d96a40d8e4d59@intel.com>
On Thu, Nov 05, 2020 at 03:33:57PM +0200, Kahola, Mika wrote:
> [....]
> > > @@ -274,16 +279,25 @@ gen7_fill_vertex_buffer_data(struct intel_bb
> > *ibb,
> > > offset = intel_bb_offset(ibb);
> > >
> > > emit_vertex_2s(ibb, dst_x + width, dst_y + height);
> > > - emit_vertex_normalized(ibb, src_x + width, intel_buf_width(src));
> > > - emit_vertex_normalized(ibb, src_y + height, intel_buf_height(src));
> > > +
> > > + if (src != NULL) {
> > > + emit_vertex_normalized(ibb, src_x + width, intel_buf_width(src));
> > > + emit_vertex_normalized(ibb, src_y + height, intel_buf_height(src));
> > > + }
> >
> > For the !src case you also need to emit the two source vertex elements to
> > keep the VUE format we defined in gen6_emit_vertex_elements().
>
> In this case we don't have src, what should we define as source vertex
> element? Are those src_*, width/height and intel_buf_width/height()
> just zeros?
Yes, just two 0s in float format, so two emit_vertex(0). The alternative
would be to change the vertex layout, but I think it's simpler this way.
--Imre
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-11-05 14:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 13:05 [igt-dev] [PATCH i-g-t v7 0/2] tests/kms_ccs: CCS Clear Color test Mika Kahola
2020-10-23 13:05 ` [igt-dev] [PATCH i-g-t v7 1/2] tests/kms_ccs: Add debug information on format modifier Mika Kahola
2020-10-23 13:05 ` [igt-dev] [PATCH i-g-t v7 2/2] tests/kms_ccs: CCS Clear Color test Mika Kahola
2020-11-02 17:27 ` Imre Deak
2020-11-02 18:12 ` Imre Deak
2020-11-03 8:15 ` Kahola, Mika
2020-11-03 13:55 ` Kahola, Mika
2020-11-03 14:00 ` Imre Deak
2020-11-05 13:33 ` Kahola, Mika
2020-11-05 14:26 ` Imre Deak [this message]
2020-11-05 14:33 ` Kahola, Mika
2020-10-23 13:36 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_ccs: CCS Clear Color test (rev8) Patchwork
2020-10-23 16:22 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201105142602.GA177799@ideak-desk.fi.intel.com \
--to=imre.deak@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=mika.kahola@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox