Re: [igt-dev] [PATCH i-g-t v7 2/2] tests/kms_ccs: CCS Clear Color test

["Kahola, Mika" <mika.kahola@intel.com>]

> -----Original Message-----
> From: Imre Deak <imre.deak@intel.com>
> Sent: Thursday, November 5, 2020 4:26 PM
> To: Kahola, Mika <mika.kahola@intel.com>
> Cc: igt-dev@lists.freedesktop.org
> Subject: Re: [PATCH i-g-t v7 2/2] tests/kms_ccs: CCS Clear Color test
> 
> On Thu, Nov 05, 2020 at 03:33:57PM +0200, Kahola, Mika wrote:
> > [....]
> > > > @@ -274,16 +279,25 @@ gen7_fill_vertex_buffer_data(struct intel_bb
> > > *ibb,
> > > >  	offset = intel_bb_offset(ibb);
> > > >
> > > >  	emit_vertex_2s(ibb, dst_x + width, dst_y + height);
> > > > -	emit_vertex_normalized(ibb, src_x + width, intel_buf_width(src));
> > > > -	emit_vertex_normalized(ibb, src_y + height, intel_buf_height(src));
> > > > +
> > > > +	if (src != NULL) {
> > > > +		emit_vertex_normalized(ibb, src_x + width,
> intel_buf_width(src));
> > > > +		emit_vertex_normalized(ibb, src_y + height,
> intel_buf_height(src));
> > > > +	}
> > >
> > > For the !src case you also need to emit the two source vertex
> > > elements to keep the VUE format we defined in
> gen6_emit_vertex_elements().
> >
> > In this case we don't have src, what should we define as source vertex
> > element? Are those src_*, width/height and intel_buf_width/height()
> > just zeros?
> 
> Yes, just two 0s in float format, so two emit_vertex(0). The alternative would
> be to change the vertex layout, but I think it's simpler this way.
Ok, thanks! I will do the first alternative.

Cheers,
Mika

> 
> --Imre
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev