Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t v4 1/2] tests/kms_rotation_crc: reduce execution time
@ 2021-01-20 11:41 Jeevan B
  2021-01-20 11:41 ` [igt-dev] [PATCH i-g-t v4 2/2] HAX remove rotation tests from blacklist Jeevan B
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Jeevan B @ 2021-01-20 11:41 UTC (permalink / raw)
  To: igt-dev

Restricting the execution to 2 pipes
with this change we see 50% improvement in time efficiency.

v2: Updated commit message.

Signed-off-by: Jeevan B <jeevan.b@intel.com>
Reviewed-by: Uma Shankar <uma.shankar@intel.com>
---
 tests/kms_rotation_crc.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
index 33a97cca..cc404a61 100644
--- a/tests/kms_rotation_crc.c
+++ b/tests/kms_rotation_crc.c
@@ -421,6 +421,10 @@ static void test_plane_rotation(data_t *data, int plane_type, bool test_bad_form
 		if (IS_CHERRYVIEW(data->devid) && pipe != PIPE_B)
 			continue;
 
+		/* restricting the execution to 2 pipes to reduce execution time*/
+		if (pipe > PIPE_B && !data->extended)
+			break;
+
 		igt_output_set_pipe(output, pipe);
 
 		plane = igt_output_get_plane_type(output, plane_type);
-- 
2.19.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [igt-dev] [PATCH i-g-t v4 2/2] HAX remove rotation tests from blacklist
  2021-01-20 11:41 [igt-dev] [PATCH i-g-t v4 1/2] tests/kms_rotation_crc: reduce execution time Jeevan B
@ 2021-01-20 11:41 ` Jeevan B
  2021-01-20 12:20 ` [igt-dev] [PATCH i-g-t v4 1/2] tests/kms_rotation_crc: reduce execution time Petri Latvala
  2021-01-20 13:33 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,v4,1/2] " Patchwork
  2 siblings, 0 replies; 6+ messages in thread
From: Jeevan B @ 2021-01-20 11:41 UTC (permalink / raw)
  To: igt-dev

Signed-off-by: Jeevan B <jeevan.b@intel.com>
---
 tests/intel-ci/blacklist-pre-merge.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/intel-ci/blacklist-pre-merge.txt b/tests/intel-ci/blacklist-pre-merge.txt
index cddb77c1..b46c7d05 100644
--- a/tests/intel-ci/blacklist-pre-merge.txt
+++ b/tests/intel-ci/blacklist-pre-merge.txt
@@ -17,7 +17,7 @@
 #
 # Data acquired on 2020-02-19 by Martin Peres
 ###############################################################################
-igt@kms_rotation_crc@.*
+#igt@kms_rotation_crc@.*
 
 
 ###############################################################################
-- 
2.19.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v4 1/2] tests/kms_rotation_crc: reduce execution time
  2021-01-20 11:41 [igt-dev] [PATCH i-g-t v4 1/2] tests/kms_rotation_crc: reduce execution time Jeevan B
  2021-01-20 11:41 ` [igt-dev] [PATCH i-g-t v4 2/2] HAX remove rotation tests from blacklist Jeevan B
@ 2021-01-20 12:20 ` Petri Latvala
  2021-01-21  9:59   ` B, Jeevan
  2021-01-20 13:33 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,v4,1/2] " Patchwork
  2 siblings, 1 reply; 6+ messages in thread
From: Petri Latvala @ 2021-01-20 12:20 UTC (permalink / raw)
  To: Jeevan B; +Cc: igt-dev

On Wed, Jan 20, 2021 at 05:11:43PM +0530, Jeevan B wrote:
> Restricting the execution to 2 pipes
> with this change we see 50% improvement in time efficiency.
> 
> v2: Updated commit message.
> 
> Signed-off-by: Jeevan B <jeevan.b@intel.com>
> Reviewed-by: Uma Shankar <uma.shankar@intel.com>
> ---
>  tests/kms_rotation_crc.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
> index 33a97cca..cc404a61 100644
> --- a/tests/kms_rotation_crc.c
> +++ b/tests/kms_rotation_crc.c
> @@ -421,6 +421,10 @@ static void test_plane_rotation(data_t *data, int plane_type, bool test_bad_form
>  		if (IS_CHERRYVIEW(data->devid) && pipe != PIPE_B)
>  			continue;
>  
> +		/* restricting the execution to 2 pipes to reduce execution time*/
> +		if (pipe > PIPE_B && !data->extended)
> +			break;
> +

What's the plan for platforms that might have two pipes as A+C?


-- 
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,v4,1/2] tests/kms_rotation_crc: reduce execution time
  2021-01-20 11:41 [igt-dev] [PATCH i-g-t v4 1/2] tests/kms_rotation_crc: reduce execution time Jeevan B
  2021-01-20 11:41 ` [igt-dev] [PATCH i-g-t v4 2/2] HAX remove rotation tests from blacklist Jeevan B
  2021-01-20 12:20 ` [igt-dev] [PATCH i-g-t v4 1/2] tests/kms_rotation_crc: reduce execution time Petri Latvala
@ 2021-01-20 13:33 ` Patchwork
  2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2021-01-20 13:33 UTC (permalink / raw)
  To: Jeevan B; +Cc: igt-dev


[-- Attachment #1.1: Type: text/plain, Size: 4565 bytes --]

== Series Details ==

Series: series starting with [i-g-t,v4,1/2] tests/kms_rotation_crc: reduce execution time
URL   : https://patchwork.freedesktop.org/series/86084/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_9650 -> IGTPW_5408
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_5408 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_5408, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5408/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_5408:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_selftest@live@hangcheck:
    - fi-byt-j1900:       [PASS][1] -> [DMESG-WARN][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9650/fi-byt-j1900/igt@i915_selftest@live@hangcheck.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5408/fi-byt-j1900/igt@i915_selftest@live@hangcheck.html

  
Known issues
------------

  Here are the changes found in IGTPW_5408 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@debugfs_test@read_all_entries:
    - fi-tgl-y:           [PASS][3] -> [DMESG-WARN][4] ([i915#402]) +2 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9650/fi-tgl-y/igt@debugfs_test@read_all_entries.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5408/fi-tgl-y/igt@debugfs_test@read_all_entries.html

  * igt@i915_pm_rpm@module-reload:
    - fi-kbl-7500u:       [PASS][5] -> [DMESG-WARN][6] ([i915#2605])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9650/fi-kbl-7500u/igt@i915_pm_rpm@module-reload.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5408/fi-kbl-7500u/igt@i915_pm_rpm@module-reload.html

  * igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
    - fi-snb-2600:        NOTRUN -> [SKIP][7] ([fdo#109271]) +30 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5408/fi-snb-2600/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html

  * igt@kms_chamelium@hdmi-crc-fast:
    - fi-snb-2600:        NOTRUN -> [SKIP][8] ([fdo#109271] / [fdo#111827]) +8 similar issues
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5408/fi-snb-2600/igt@kms_chamelium@hdmi-crc-fast.html

  
#### Possible fixes ####

  * igt@gem_exec_suspend@basic-s3:
    - fi-snb-2600:        [DMESG-WARN][9] ([i915#2772]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9650/fi-snb-2600/igt@gem_exec_suspend@basic-s3.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5408/fi-snb-2600/igt@gem_exec_suspend@basic-s3.html

  * igt@prime_self_import@basic-with_one_bo_two_files:
    - fi-tgl-y:           [DMESG-WARN][11] ([i915#402]) -> [PASS][12] +1 similar issue
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9650/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5408/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
  [i915#2605]: https://gitlab.freedesktop.org/drm/intel/issues/2605
  [i915#2772]: https://gitlab.freedesktop.org/drm/intel/issues/2772
  [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402


Participating hosts (43 -> 37)
------------------------------

  Missing    (6): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-dg1-1 fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5960 -> IGTPW_5408

  CI-20190529: 20190529
  CI_DRM_9650: 3f989d1bb4cfd91e25549f9fd7a750412581dcc4 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_5408: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5408/index.html
  IGT_5960: ace82fcd5f3623f8dde7c220a825873dc53dfae4 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5408/index.html

[-- Attachment #1.2: Type: text/html, Size: 5346 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v4 1/2] tests/kms_rotation_crc: reduce execution time
  2021-01-20 12:20 ` [igt-dev] [PATCH i-g-t v4 1/2] tests/kms_rotation_crc: reduce execution time Petri Latvala
@ 2021-01-21  9:59   ` B, Jeevan
  2021-01-21 10:04     ` Petri Latvala
  0 siblings, 1 reply; 6+ messages in thread
From: B, Jeevan @ 2021-01-21  9:59 UTC (permalink / raw)
  To: Latvala, Petri; +Cc: igt-dev@lists.freedesktop.org

>-----Original Message-----
>From: Petri Latvala <petri.latvala@intel.com>
>Sent: Wednesday, January 20, 2021 5:51 PM
>To: B, Jeevan <jeevan.b@intel.com>
>Cc: igt-dev@lists.freedesktop.org
>Subject: Re: [igt-dev] [PATCH i-g-t v4 1/2] tests/kms_rotation_crc: reduce
>execution time
>
>On Wed, Jan 20, 2021 at 05:11:43PM +0530, Jeevan B wrote:
>> Restricting the execution to 2 pipes
>> with this change we see 50% improvement in time efficiency.
>>
>> v2: Updated commit message.
>>
>> Signed-off-by: Jeevan B <jeevan.b@intel.com>
>> Reviewed-by: Uma Shankar <uma.shankar@intel.com>
>> ---
>>  tests/kms_rotation_crc.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c index
>> 33a97cca..cc404a61 100644
>> --- a/tests/kms_rotation_crc.c
>> +++ b/tests/kms_rotation_crc.c
>> @@ -421,6 +421,10 @@ static void test_plane_rotation(data_t *data, int
>plane_type, bool test_bad_form
>>  		if (IS_CHERRYVIEW(data->devid) && pipe != PIPE_B)
>>  			continue;
>>
>> +		/* restricting the execution to 2 pipes to reduce execution
>time*/
>> +		if (pipe > PIPE_B && !data->extended)
>> +			break;
>> +
>
>What's the plan for platforms that might have two pipes as A+C?
Hmm, Can we add a flag check here ?? 
So that I can exit when tests gets executed on 2 pipes. 

Thanks
Jeevan B 
>
>
>--
>Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v4 1/2] tests/kms_rotation_crc: reduce execution time
  2021-01-21  9:59   ` B, Jeevan
@ 2021-01-21 10:04     ` Petri Latvala
  0 siblings, 0 replies; 6+ messages in thread
From: Petri Latvala @ 2021-01-21 10:04 UTC (permalink / raw)
  To: B, Jeevan; +Cc: igt-dev@lists.freedesktop.org

On Thu, Jan 21, 2021 at 11:59:48AM +0200, B, Jeevan wrote:
> >-----Original Message-----
> >From: Petri Latvala <petri.latvala@intel.com>
> >Sent: Wednesday, January 20, 2021 5:51 PM
> >To: B, Jeevan <jeevan.b@intel.com>
> >Cc: igt-dev@lists.freedesktop.org
> >Subject: Re: [igt-dev] [PATCH i-g-t v4 1/2] tests/kms_rotation_crc: reduce
> >execution time
> >
> >On Wed, Jan 20, 2021 at 05:11:43PM +0530, Jeevan B wrote:
> >> Restricting the execution to 2 pipes
> >> with this change we see 50% improvement in time efficiency.
> >>
> >> v2: Updated commit message.
> >>
> >> Signed-off-by: Jeevan B <jeevan.b@intel.com>
> >> Reviewed-by: Uma Shankar <uma.shankar@intel.com>
> >> ---
> >>  tests/kms_rotation_crc.c | 4 ++++
> >>  1 file changed, 4 insertions(+)
> >>
> >> diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c index
> >> 33a97cca..cc404a61 100644
> >> --- a/tests/kms_rotation_crc.c
> >> +++ b/tests/kms_rotation_crc.c
> >> @@ -421,6 +421,10 @@ static void test_plane_rotation(data_t *data, int
> >plane_type, bool test_bad_form
> >>  		if (IS_CHERRYVIEW(data->devid) && pipe != PIPE_B)
> >>  			continue;
> >>
> >> +		/* restricting the execution to 2 pipes to reduce execution
> >time*/
> >> +		if (pipe > PIPE_B && !data->extended)
> >> +			break;
> >> +
> >
> >What's the plan for platforms that might have two pipes as A+C?
> Hmm, Can we add a flag check here ?? 
> So that I can exit when tests gets executed on 2 pipes. 

Yeah a separate counter is what you need to do here.


-- 
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-01-21 10:04 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-20 11:41 [igt-dev] [PATCH i-g-t v4 1/2] tests/kms_rotation_crc: reduce execution time Jeevan B
2021-01-20 11:41 ` [igt-dev] [PATCH i-g-t v4 2/2] HAX remove rotation tests from blacklist Jeevan B
2021-01-20 12:20 ` [igt-dev] [PATCH i-g-t v4 1/2] tests/kms_rotation_crc: reduce execution time Petri Latvala
2021-01-21  9:59   ` B, Jeevan
2021-01-21 10:04     ` Petri Latvala
2021-01-20 13:33 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,v4,1/2] " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox