From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 1/2] tests/kms_rmfb: Use COMMIT_UNIVERSAL for overlay/cursor planes
Date: Tue, 23 Feb 2021 15:49:23 +0200 [thread overview]
Message-ID: <20210223134924.10045-1-ville.syrjala@linux.intel.com> (raw)
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Using COMMIT_LEGACY for the cursor plane makes the test fail
because the cursor framebuffer is never handed over to the
kernel, and instead only the BO gets passed in via the
legacy cursor ioctl. Thus the rmfb ioctl will not turn off
the cursor plane since the kernel is using an internal fb
for the cursor. Let's avoid that by treating the cursor as
just another universal plane.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
tests/kms_rmfb.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/kms_rmfb.c b/tests/kms_rmfb.c
index 81932e0d830c..2d49be8ea399 100644
--- a/tests/kms_rmfb.c
+++ b/tests/kms_rmfb.c
@@ -87,8 +87,10 @@ test_rmfb(struct rmfb_data *data, igt_output_t *output, enum pipe pipe, bool reo
igt_plane_set_fb(plane, &fb);
}
- if (igt_display_try_commit2(&data->display, data->display.is_atomic ?
- COMMIT_ATOMIC : COMMIT_LEGACY)) {
+ if (igt_display_try_commit2(&data->display,
+ data->display.is_atomic ? COMMIT_ATOMIC :
+ plane->type == DRM_PLANE_TYPE_PRIMARY ?
+ COMMIT_LEGACY : COMMIT_UNIVERSAL)) {
/*
* Disable any plane that fails (presumably
* due to exceeding some hardware limit).
--
2.26.2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2021-02-23 13:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 13:49 Ville Syrjala [this message]
2021-02-23 13:49 ` [igt-dev] [PATCH i-g-t 2/2] tests/kms_plane: Restore RGB pixel format tests for non-atomic drivers Ville Syrjala
2021-02-23 15:12 ` Juha-Pekka Heikkila
2021-02-23 17:56 ` [igt-dev] [PATCH i-g-t 1/2] tests/kms_rmfb: Use COMMIT_UNIVERSAL for overlay/cursor planes Juha-Pekka Heikkila
2021-02-24 7:50 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] " Patchwork
2021-02-24 8:52 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210223134924.10045-1-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox