Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 2/2] tests/kms_plane: Restore RGB pixel format tests for non-atomic drivers
Date: Tue, 23 Feb 2021 15:49:24 +0200	[thread overview]
Message-ID: <20210223134924.10045-2-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20210223134924.10045-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Restore the capability to run RGB pixel format tests when the driver
doesn't advertize the atomic capability.

Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Fixes: e96c0d8e6952 ("tests/kms_plane: optimize pixel format tests")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 tests/kms_plane.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/kms_plane.c b/tests/kms_plane.c
index ecba197c80f5..298a9375b9f4 100644
--- a/tests/kms_plane.c
+++ b/tests/kms_plane.c
@@ -567,8 +567,8 @@ static void capture_format_crcs_packed(data_t *data, enum pipe pipe,
 	prepare_format_color(data, pipe, plane, format, modifier,
 			     width, height, encoding, range, &black, fb, true);
 
-	igt_display_commit_atomic(&data->display, DRM_MODE_ATOMIC_ALLOW_MODESET,
-				  NULL);
+	igt_display_commit2(&data->display, data->display.is_atomic ?
+			    COMMIT_ATOMIC : COMMIT_UNIVERSAL);
 
 	igt_remove_fb(data->drm_fd, &old_fb);
 
-- 
2.26.2

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2021-02-23 13:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-23 13:49 [igt-dev] [PATCH i-g-t 1/2] tests/kms_rmfb: Use COMMIT_UNIVERSAL for overlay/cursor planes Ville Syrjala
2021-02-23 13:49 ` Ville Syrjala [this message]
2021-02-23 15:12   ` [igt-dev] [PATCH i-g-t 2/2] tests/kms_plane: Restore RGB pixel format tests for non-atomic drivers Juha-Pekka Heikkila
2021-02-23 17:56 ` [igt-dev] [PATCH i-g-t 1/2] tests/kms_rmfb: Use COMMIT_UNIVERSAL for overlay/cursor planes Juha-Pekka Heikkila
2021-02-24  7:50 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] " Patchwork
2021-02-24  8:52 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210223134924.10045-2-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox