From: Anshuman Gupta <anshuman.gupta@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v3 2/5] i915/i915_pm_rpm: optimize modeset-pc8-residency-stress test
Date: Wed, 3 Mar 2021 10:37:34 +0530 [thread overview]
Message-ID: <20210303050737.22056-3-anshuman.gupta@intel.com> (raw)
In-Reply-To: <20210303050737.22056-1-anshuman.gupta@intel.com>
modeset-pc8-residency-stress checks PC8 residency with modeset
stress, It is sufficient to validate PC8 while all displays
being off with modeset stress.
Negative testing of PC8 residency on HASWELL/BROADWELL while
display being "on" is removed as it saves CI time and there is
no ROI of such testing. wait_for_active() already covers that
for platform without runtime_pm.
v2: Used optimum pc8 timeout value and commit log changes.
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
tests/i915/i915_pm_rpm.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c
index 067d1b91..c78277aa 100644
--- a/tests/i915/i915_pm_rpm.c
+++ b/tests/i915/i915_pm_rpm.c
@@ -882,7 +882,7 @@ static void modeset_subtest(enum screen_type type, int rounds, int wait_flags)
if (wait_flags & WAIT_STATUS)
igt_assert(wait_for_suspended());
if (wait_flags & WAIT_PC8_RES)
- igt_assert(pc8_plus_residency_changed(30));
+ igt_assert(pc8_plus_residency_changed(PC8_TIMEOUT));
if (wait_flags & WAIT_EXTRA)
sleep(5);
@@ -891,8 +891,6 @@ static void modeset_subtest(enum screen_type type, int rounds, int wait_flags)
igt_require(enable_one_screen_with_type(&ms_data, type));
if (wait_flags & WAIT_STATUS)
igt_assert(wait_for_active());
- if (wait_flags & WAIT_PC8_RES)
- igt_assert(!pc8_plus_residency_changed(5));
if (wait_flags & WAIT_EXTRA)
sleep(5);
}
--
2.26.2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2021-03-03 5:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 5:07 [igt-dev] [PATCH i-g-t v3 0/5] PC state igt test Anshuman Gupta
2021-03-03 5:07 ` [igt-dev] [PATCH i-g-t v3 1/5] i915/i915_pm_rpm: Enable PC8+ residency test Anshuman Gupta
2021-03-03 5:07 ` Anshuman Gupta [this message]
2021-03-03 5:07 ` [igt-dev] [PATCH i-g-t v3 3/5] i915/i915_pm_rpm: gem-execbuf-stress PC8 timeout Anshuman Gupta
2021-03-03 5:07 ` [igt-dev] [PATCH i-g-t v3 4/5] i915/i915_pm_rpm: Add PC10 display off test Anshuman Gupta
2021-04-18 19:37 ` Shankar, Uma
2021-03-03 5:07 ` [igt-dev] [PATCH i-g-t v3 5/5] i915/i915_pm_rpm: Add PC10 idle display on test Anshuman Gupta
2021-03-03 15:28 ` [igt-dev] ✓ Fi.CI.BAT: success for PC state igt test (rev3) Patchwork
2021-03-03 17:24 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2021-03-22 7:14 ` Gupta, Anshuman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210303050737.22056-3-anshuman.gupta@intel.com \
--to=anshuman.gupta@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox