Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Anshuman Gupta <anshuman.gupta@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v3 4/5] i915/i915_pm_rpm: Add PC10 display off test
Date: Wed,  3 Mar 2021 10:37:36 +0530	[thread overview]
Message-ID: <20210303050737.22056-5-anshuman.gupta@intel.com> (raw)
In-Reply-To: <20210303050737.22056-1-anshuman.gupta@intel.com>

Add a test to validate PC10 residencies while all output's
display is off.

v2: used optimum pc10 timeout value.

Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
 tests/i915/i915_pm_rpm.c | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c
index 290d1223..b27c20bd 100644
--- a/tests/i915/i915_pm_rpm.c
+++ b/tests/i915/i915_pm_rpm.c
@@ -102,6 +102,7 @@ enum plane_type {
  * Let's keep 3 seconds timeout for PC8 and 5 seconds for PC10.
  */
 #define PC8_TIMEOUT 3
+#define PC10_TIMEOUT 5
 
 int drm_fd, msr_fd, pc8_status_fd;
 int debugfs;
@@ -187,6 +188,16 @@ static bool pc8_plus_residency_changed(unsigned int timeout_sec)
 			timeout_sec * 1000, 100);
 }
 
+static bool pc10_residency_changed(unsigned int timeout_sec)
+{
+	uint64_t res_pc10;
+
+	res_pc10 = get_residency(MSR_PC10_RES);
+
+	return igt_wait(res_pc10 != get_residency(MSR_PC10_RES),
+			timeout_sec * 1000, 100);
+}
+
 static enum pc8_status get_pc8_status(void)
 {
 	ssize_t n_read;
@@ -863,6 +874,19 @@ static void pc8_residency_subtest(bool display_on)
 	}
 }
 
+static void pc10_residency_subtest(bool display_on)
+{
+	igt_require(has_pc8);
+	igt_require(AT_LEAST_GEN(ms_data.devid, 9));
+
+	if (!display_on) {
+		/* Make sure PC10 residencies move! */
+		disable_all_screens_and_wait(&ms_data);
+		igt_assert_f(pc10_residency_changed(PC10_TIMEOUT),
+			     "Machine is not reaching PC10 state with all screens disabled.\n");
+	}
+}
+
 static void modeset_subtest(enum screen_type type, int rounds, int wait_flags)
 {
 	int i;
@@ -2097,6 +2121,8 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
 		pc8_residency_subtest(true);
 	igt_subtest("pc8-residency-display-off")
 		pc8_residency_subtest(false);
+	igt_subtest("pc10-residency-display-off")
+		pc10_residency_subtest(false);
 	igt_subtest("debugfs-read")
 		debugfs_read_subtest();
 	igt_subtest("debugfs-forcewake-user")
-- 
2.26.2

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2021-03-03  5:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-03  5:07 [igt-dev] [PATCH i-g-t v3 0/5] PC state igt test Anshuman Gupta
2021-03-03  5:07 ` [igt-dev] [PATCH i-g-t v3 1/5] i915/i915_pm_rpm: Enable PC8+ residency test Anshuman Gupta
2021-03-03  5:07 ` [igt-dev] [PATCH i-g-t v3 2/5] i915/i915_pm_rpm: optimize modeset-pc8-residency-stress test Anshuman Gupta
2021-03-03  5:07 ` [igt-dev] [PATCH i-g-t v3 3/5] i915/i915_pm_rpm: gem-execbuf-stress PC8 timeout Anshuman Gupta
2021-03-03  5:07 ` Anshuman Gupta [this message]
2021-04-18 19:37   ` [igt-dev] [PATCH i-g-t v3 4/5] i915/i915_pm_rpm: Add PC10 display off test Shankar, Uma
2021-03-03  5:07 ` [igt-dev] [PATCH i-g-t v3 5/5] i915/i915_pm_rpm: Add PC10 idle display on test Anshuman Gupta
2021-03-03 15:28 ` [igt-dev] ✓ Fi.CI.BAT: success for PC state igt test (rev3) Patchwork
2021-03-03 17:24 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2021-03-22  7:14   ` Gupta, Anshuman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210303050737.22056-5-anshuman.gupta@intel.com \
    --to=anshuman.gupta@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox