Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/core_hotunplug: Be more specific on sysfs vs. debugfs issues
@ 2021-03-18 12:05 Janusz Krzysztofik
  2021-03-18 13:03 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Janusz Krzysztofik @ 2021-03-18 12:05 UTC (permalink / raw)
  To: igt-dev

Messages displayed on sysfs health check failures don't provide
information which subtree of sysfs actually failed - device sysfs
itself or device debugfs.  That information could make debugging more
easy if available.

Be more specific when reporting sysfs health check failures.

Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
---
 tests/core_hotunplug.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c
index e7d2a4472..56a88fefd 100644
--- a/tests/core_hotunplug.c
+++ b/tests/core_hotunplug.c
@@ -351,11 +351,13 @@ static void node_healthcheck(struct hotunplug *priv, unsigned flags)
 	if (!priv->failure) {
 		char path[200];
 
-		priv->failure = "Device sysfs healthckeck failure!";
 		local_debug("%s\n", "running device sysfs healthcheck");
-		if (igt_sysfs_path(fd_drm, path, sizeof(path)) &&
-		    igt_debugfs_path(fd_drm, path, sizeof(path)))
-			priv->failure = NULL;
+		priv->failure = "Device sysfs healthckeck failure!";
+		if (igt_sysfs_path(fd_drm, path, sizeof(path))) {
+			priv->failure = "Device debugfs healthckeck failure!";
+			if (igt_debugfs_path(fd_drm, path, sizeof(path)))
+				priv->failure = NULL;
+		}
 	}
 
 	fd_drm = close_device(fd_drm, "", "health checked ");
-- 
2.25.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-03-23 17:48 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-18 12:05 [igt-dev] [PATCH i-g-t] tests/core_hotunplug: Be more specific on sysfs vs. debugfs issues Janusz Krzysztofik
2021-03-18 13:03 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-03-18 15:41 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-03-23 10:02   ` Janusz Krzysztofik
2021-03-23 17:48     ` Vudum, Lakshminarayana
2021-03-23  9:13 ` [igt-dev] [i-g-t] " Adam Miszczak
2021-03-23 10:31   ` Janusz Krzysztofik
2021-03-23 17:31 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox