Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Stylon Wang <stylon.wang@amd.com>
To: igt-dev@lists.freedesktop.org
Cc: nicholas.choi@amd.com, rodrigo.siqueira@amd.com,
	Stylon Wang <stylon.wang@amd.com>
Subject: [igt-dev] [PATCH i-g-t] tests/kms_hdr: Fix failure to read output_bpc on AMD hardware
Date: Fri, 1 Oct 2021 16:53:19 +0800	[thread overview]
Message-ID: <20211001085319.789392-1-stylon.wang@amd.com> (raw)

The first commit with TEST_ONLY flag in bpc-switch subtests
could in some cases cause reading of output_bpc on connectors
to fail on AMD hardware.

Use ALLOW_MODESET to prevent this from happening.

Signed-off-by: Stylon Wang <stylon.wang@amd.com>
---
 tests/kms_hdr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kms_hdr.c b/tests/kms_hdr.c
index 5b8529c8..a4983b9a 100644
--- a/tests/kms_hdr.c
+++ b/tests/kms_hdr.c
@@ -217,7 +217,7 @@ static void test_bpc_switch_on_output(data_t *data, igt_output_t *output,
 		igt_plane_set_fb(data->primary, &afb);
 		igt_plane_set_size(data->primary, data->w, data->h);
 		igt_output_set_prop_value(data->output, IGT_CONNECTOR_MAX_BPC, 8);
-		ret = igt_display_try_commit_atomic(display, DRM_MODE_ATOMIC_TEST_ONLY, NULL);
+		ret = igt_display_try_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
 		if (!ret) {
 			data->w = afb.width;
 			data->h = afb.height;
-- 
2.32.0

             reply	other threads:[~2021-10-01  8:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-01  8:53 Stylon Wang [this message]
2021-10-02 15:15 ` [igt-dev] [PATCH i-g-t] tests/kms_hdr: Fix failure to read output_bpc on AMD hardware Rodrigo Siqueira
2021-10-04 11:13   ` Petri Latvala
2021-10-04 14:18     ` Rodrigo Siqueira
2021-10-04 15:42       ` Vudum, Lakshminarayana
2021-10-04 17:07         ` Saarinen, Jani
2021-10-07 14:40           ` Rodrigo Siqueira
2021-10-07 14:49             ` Simon Ser
2021-10-07 14:54               ` Kazlauskas, Nicholas
2021-10-07 14:56                 ` Harry Wentland
2021-10-07 14:59                   ` Kazlauskas, Nicholas
2021-10-08  5:45                     ` Wang, Chao-kai (Stylon)
2021-10-08  6:33                       ` Simon Ser
2021-10-04 12:00 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-10-04 14:08 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-10-04 15:36 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211001085319.789392-1-stylon.wang@amd.com \
    --to=stylon.wang@amd.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=nicholas.choi@amd.com \
    --cc=rodrigo.siqueira@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox